From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zailiang.sun@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Wed, 10 Jul 2019 21:48:23 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 21:48:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="193280532" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 10 Jul 2019 21:48:22 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 21:48:22 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 21:48:22 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 12:48:20 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Gary Lin , "Qian, Yi" Subject: Re: [edk2-platforms Patch 08/28] Vlv2TbltDevicePkg/bld_vlv.sh: Remove BiosId.env completely Thread-Topic: [edk2-platforms Patch 08/28] Vlv2TbltDevicePkg/bld_vlv.sh: Remove BiosId.env completely Thread-Index: AQHVN1J0XMG6/NmYnUOGd1rQKvqS36bE2RDw Date: Thu, 11 Jul 2019 04:48:20 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C95DAD@SHSMSX104.ccr.corp.intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> <20190710190516.6012-9-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-9-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qia= n, > Yi > Subject: [edk2-platforms Patch 08/28] Vlv2TbltDevicePkg/bld_vlv.sh: > Remove BiosId.env completely >=20 > From: Gary Lin >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Michael D Kinney > Signed-off-by: Gary Lin > --- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 25 +++------------------ > 1 file changed, 3 insertions(+), 22 deletions(-) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > index 0aa1edfb22..bceea99b2d 100755 > --- a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > +++ b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > @@ -53,10 +53,6 @@ if [ -e $CORE_PATH/Conf/target.txt ]; then > rm $CORE_PATH/Conf/target.txt > fi >=20 > -if [ -e $CORE_PATH/Conf/BiosId.env ]; then > - rm $CORE_PATH/Conf/BiosId.env > -fi > - > if [ -e $CORE_PATH/Conf/tools_def.txt ]; then > rm $CORE_PATH/Conf/tools_def.txt > fi > @@ -119,18 +115,11 @@ if [ "$2" =3D=3D "" ]; then > Usage > fi >=20 > -## Remove the values for Platform_Type and Build_Target from BiosIdX.env > and stage in Conf if [ $Arch =3D=3D "IA32" ]; then > - cp $PLATFORM_PKG_PATH/BiosIdR.env Conf/BiosId.env > - echo DEFINE X64_CONFIG =3D FALSE >> $auto_config_inc > + echo DEFINE X64_CONFIG =3D FALSE >> $auto_config_inc > else > - cp $PLATFORM_PKG_PATH/BiosIdx64R.env Conf/BiosId.env > - echo DEFINE X64_CONFIG =3D TRUE >> $auto_config_inc > + echo DEFINE X64_CONFIG =3D TRUE >> $auto_config_inc > fi > -sed -i '/^BOARD_ID/d' Conf/BiosId.env > -sed -i '/^BUILD_TYPE/d' Conf/BiosId.env > - > - >=20 > ## -- Build flags settings for each Platform -- > ## AlpineValley (ALPV): SVP_PF_BUILD =3D TRUE, ENBDT_PF_BUILD =3D > FALSE, TABLET_PF_BUILD =3D FALSE, BYTI_PF_BUILD =3D FALSE, IVI_PF_BUILD= =3D > FALSE > @@ -141,26 +130,18 @@ sed -i '/^BUILD_TYPE/d' Conf/BiosId.env > ## FFD8 (BLAK): SVP_PF_BUILD =3D FALSE, ENBDT_PF_BUILD =3D = FALSE, > TABLET_PF_BUILD =3D TRUE, BYTI_PF_BUILD =3D FALSE, IVI_PF_BUILD =3D FAL= SE > echo "Setting $1 platform configuration and BIOS ID..." > if [ "$(echo $1 | tr 'a-z' 'A-Z')" =3D=3D "MNW2" ]; then > - echo BOARD_ID =3D MNW2MAX >> Conf/BiosId.env > - echo DEFINE ENBDT_PF_BUILD =3D TRUE >> $auto_config_inc > + echo DEFINE ENBDT_PF_BUILD =3D TRUE >> $auto_config_inc > else > echo "Error - Unsupported PlatformType: $1" > Usage > fi >=20 > -Platform_Type=3D$1 > - > if [ "$(echo $2 | tr 'a-z' 'A-Z')" =3D=3D "RELEASE" ]; then > export TARGET=3DRELEASE > - BUILD_TYPE=3DR > - echo BUILD_TYPE =3D R >> Conf/BiosId.env else > export TARGET=3DDEBUG > - BUILD_TYPE=3DD > - echo BUILD_TYPE =3D D >> Conf/BiosId.env fi >=20 > - >=20 > ##******************************************************** > ************** > ## Additional EDK Build Setup/Configuration >=20 > ##******************************************************** > ************** > -- > 2.21.0.windows.1