From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zailiang.sun@intel.com)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by groups.io with SMTP; Wed, 10 Jul 2019 21:52:12 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 21:52:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; 
   d="scan'208";a="193281115"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
  by fmsmga002.fm.intel.com with ESMTP; 10 Jul 2019 21:52:12 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 10 Jul 2019 21:52:12 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.109]) with mapi id 14.03.0439.000;
 Thu, 11 Jul 2019 12:52:11 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: Gary Lin <glin@suse.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>
CC: "Kinney, Michael D" <michael.d.kinney@intel.com>, "Qian, Yi"
	<yi.qian@intel.com>
Subject: Re: [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM
Thread-Topic: [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh:
 Create Vlv.ROM
Thread-Index: AQHVN1J0HQDHQDEfTkSq1hmuTAZXg6bE2SKQ
Date: Thu, 11 Jul 2019 04:52:10 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C95DEE@SHSMSX104.ccr.corp.intel.com>
References: <20190710190516.6012-1-michael.d.kinney@intel.com>
 <20190710190516.6012-11-michael.d.kinney@intel.com>
In-Reply-To: <20190710190516.6012-11-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Gary,

I suggest remove the first line "From: Gary Lin <glin@suse.com>" from the d=
escription section since you have appended the "signed-off-by" declaration.

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, July 11, 2019 3:05 AM
> To: devel@edk2.groups.io
> Cc: Gary Lin <glin@suse.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qia=
n,
> Yi <yi.qian@intel.com>
> Subject: [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Creat=
e
> Vlv.ROM
>=20
> From: Gary Lin <glin@suse.com>
>=20
> The scripts for PlatformCapsuleGcc.dsc need Vlv.ROM.
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
>  Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> index 7fd5f44264..c68e59398a 100755
> --- a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> @@ -199,6 +199,8 @@ echo Skip "Running fce..."
>=20
> ##********************************************************
> **************
>  ## Build Capsules
>=20
> ##********************************************************
> **************
> +cp -f
> $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN_TAG}/F
> V/VLV.fd \
> +
> $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN_TAG}/F
> V/Vlv.ROM
>  build -p $PLATFORM_PKG_PATH/PlatformCapsuleGcc.dsc
>=20
>  echo
> --
> 2.21.0.windows.1