From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zailiang.sun@intel.com)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by groups.io with SMTP; Wed, 10 Jul 2019 21:53:32 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 21:53:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; 
   d="scan'208";a="249672537"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by orsmga001.jf.intel.com with ESMTP; 10 Jul 2019 21:53:32 -0700
Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 10 Jul 2019 21:53:32 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 10 Jul 2019 21:53:31 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000;
 Thu, 11 Jul 2019 12:53:30 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Qian, Yi" <yi.qian@intel.com>, Gary Lin <glin@suse.com>
Subject: Re: [edk2-platforms Patch 20/28] Vlv2TbltDevicePkg: Remove redundant gEfiSpiProtocolGuid
Thread-Topic: [edk2-platforms Patch 20/28] Vlv2TbltDevicePkg: Remove
 redundant gEfiSpiProtocolGuid
Thread-Index: AQHVN1J41eh4D80BnUGXGxQD1/cnp6bE2n9A
Date: Thu, 11 Jul 2019 04:53:29 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C95E26@SHSMSX104.ccr.corp.intel.com>
References: <20190710190516.6012-1-michael.d.kinney@intel.com>
 <20190710190516.6012-21-michael.d.kinney@intel.com>
In-Reply-To: <20190710190516.6012-21-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-By: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, July 11, 2019 3:05 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>;
> Gary Lin <glin@suse.com>
> Subject: [edk2-platforms Patch 20/28] Vlv2TbltDevicePkg: Remove
> redundant gEfiSpiProtocolGuid
>=20
> Remove redundant declaration of gEfiSpiProtocolGuid.
> This protocol is defined in Vlv2DeviceRefCodePkg.
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Gary Lin <glin@suse.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.dec
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.dec
> index abe9d7e3a0..970d2db42a 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.dec
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.dec
> @@ -187,7 +187,6 @@ [Protocols]
>  #  gEfiSpiBusProtocolGuid =3D  { 0x137b3044, 0xf6d7, 0x473e, { 0xa6, 0x2=
5, 0x9f,
> 0xb9, 0x25, 0x5, 0xc1, 0x80 } }
>=20
>  #  gLpssDummyProtocolGuid =3D { 0xaf4cc162, 0xd41c, 0x455a, { 0xab, 0x45=
,
> 0x6d, 0xbc, 0xc1, 0xcd, 0x32, 0xf3 } }
> -  gEfiSpiProtocolGuid               =3D { 0x1156efc6, 0xea32, 0x4396, { =
0xb5, 0xd5,
> 0x26, 0x93, 0x2e, 0x83, 0xc3, 0x13 }}
>    gEfiGpioOperationProtocolGuid     =3D { 0x38DDFE8F, 0x8991, 0x44AA, { =
0x98,
> 0x89, 0x83, 0xF4, 0x91, 0x84, 0x65, 0xB0 }}
>    gEfiEsrtOperationProtocolGuid     =3D { 0x4549AB47, 0x6E60, 0x4293, { =
0xB9,
> 0x1D, 0x31, 0xB6, 0x10, 0xAD, 0x80, 0x56 }}
>=20
> --
> 2.21.0.windows.1