From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zailiang.sun@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 10 Jul 2019 21:55:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 21:54:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="166282361" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 10 Jul 2019 21:54:59 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 21:54:59 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 12:54:58 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Qian, Yi" , Gary Lin Subject: Re: [edk2-platforms Patch 25/28] Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error Thread-Topic: [edk2-platforms Patch 25/28] Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error Thread-Index: AQHVN1J72sGKjae+O06Du0BizgkK0abE2ugg Date: Thu, 11 Jul 2019 04:54:57 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C95E8B@SHSMSX104.ccr.corp.intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> <20190710190516.6012-26-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-26-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch 25/28] > Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error >=20 > Remove use of a method to read a register from a BAR and instead access > the register directly. Resolves the following error from the latest iasl > compiler. >=20 > Or(ShiftLeft(Derefof(Index(CDCT, \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, > PARM) >=20 > Error 6163 - Object is created temporarily in another method > and cannot be accessed ^ (\_SB.PCI0.GFX0.MCHK.DCFE) >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Gary Lin > Signed-off-by: Michael D Kinney > --- > .../AcpiTablesPCAT/IgdOGBDA.ASL | 14 ++++++++++++-- > .../AcpiTablesPCAT/IgdOpRn.ASL | 18 +----------------- > 2 files changed, 13 insertions(+), 19 deletions(-) >=20 > diff --git > a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL > b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL > index 4482db6906..379fca7379 100644 > --- a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL > +++ b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL > @@ -1,6 +1,6 @@ > /*++ >=20 > -Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved > +Copyright (c) 1999 - 2019, Intel Corporation. All rights reserved >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -125,7 +125,17 @@ Method (GBDA, 0, Serialized) >=20 > // Report the graphics frequency based on > DISPLAY_CLOCK_FREQUENCY_ENCODING [MMADR+0x20C8] >=20 > - Or(ShiftLeft(Derefof(Index(CDCT, \_SB.PCI0.GFX0.MCHK.DCFE)), > 21),PARM, PARM) > + If (LNotEqual (MADR, 0xFFFFFFFF)) > + { > + OperationRegion(IGMM,SystemMemory,MADR,0x3000) > + Field(IGMM,AnyAcc, NoLock, Preserve) > + { > + Offset(0X20C8), > + , 4, > + DCFE, 4, // DISPLAY_CLOCK_FREQUENCY_ENC= ODING > + } > + Or(ShiftLeft(Derefof(Index(CDCT, DCFE)), 21),PARM, PARM) > + } >=20 > Store(1, GESF) // Set the modified settings flag > Return(SUCC) > diff --git > a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL > b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL > index 8575fbfe6c..386ad3e65e 100644 > --- a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL > +++ b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL > @@ -1,6 +1,6 @@ > /*++ >=20 > -Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved > +Copyright (c) 1999 - 2019, Intel Corporation. All rights reserved >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -70,22 +70,6 @@ Field(IGDP, AnyAcc, NoLock, Preserve) > ASLS, 32, // Reg 0xFC, Address of the IGD OpRegion > } >=20 > -Method (MCHK, 0, Serialized) > -{ > - > - If (LNotEqual (MADR, 0xFFFFFFFF)) > - { > - OperationRegion(IGMM,SystemMemory,MADR,0x3000) > - Field(IGMM,AnyAcc, NoLock, Preserve) > - { > - Offset(0X20C8), > - , 4, > - DCFE, 4, // DISPLAY_CLOCK_FREQUENCY_ENCODIN= G > - } > - } > -} > - > - > // Define an OperationRegion to cover the IGD OpRegion layout. >=20 > OperationRegion(IGDM, SystemMemory, ASLB, 0x2000) > -- > 2.21.0.windows.1