From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zailiang.sun@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 11 Jul 2019 19:45:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 19:45:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,480,1557212400"; d="scan'208";a="160261757" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga008.jf.intel.com with ESMTP; 11 Jul 2019 19:45:10 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jul 2019 19:45:10 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jul 2019 19:45:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.60]) with mapi id 14.03.0439.000; Fri, 12 Jul 2019 10:37:54 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Gary Lin , "Qian, Yi" Subject: Re: [edk2-platforms Patch 18/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Check the WORKSPACE env variable Thread-Topic: [edk2-platforms Patch 18/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Check the WORKSPACE env variable Thread-Index: AQHVN1J480fpipkhPk6U3l8Wh17MvabGRvIQ Date: Fri, 12 Jul 2019 02:37:53 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C963E7@SHSMSX104.ccr.corp.intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> <20190710190516.6012-19-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-19-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Zailiang Sun -----Original Message----- From: Kinney, Michael D=20 Sent: Thursday, July 11, 2019 3:05 AM To: devel@edk2.groups.io Cc: Gary Lin ; Sun, Zailiang ; Qian,= Yi Subject: [edk2-platforms Patch 18/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Chec= k the WORKSPACE env variable From: Gary Lin Check WORKSPACE before running the script and notify the user to export the= variable if the variable doesn't exist Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh b/Platform/Inte= l/Vlv2TbltDevicePkg/Build_IFWI.sh index f8954cc9cd..422e90ca6c 100755 --- a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh +++ b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh @@ -6,7 +6,7 @@ function Usage ( ) { echo echo "Script to build BIOS firmware and stitch the entire IFWI." echo - echo "Usage: Build_IFWI.bat [options] PlatformType BuildTarget " + echo "Usage: Build_IFWI.sh [options] PlatformType BuildTarget " echo echo=20 echo " /yL [option] : Enable SPI lock" @@ -28,6 +28,18 @@ Stitch_Flags=3D Arch=3DX64 PLATFORM_PACKAGE=3DVlv2TbltDevicePkg =20 +## Check whether WORKSPACE is set or not if [[ -z "$WORKSPACE" ]]; then + echo "Please export WORKSPACE before running Build_IFWI.sh" + echo "See the details in Readme.md" + exit 1 +fi + +## Create $WORKSPACE/Conf if necessary +if [ ! -d $WORKSPACE/Conf ]; then + mkdir $WORKSPACE/Conf +fi + ## Parse Optional arguments if [ "$1" =3D=3D "/?" ]; then Usage -- 2.21.0.windows.1