Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

["Sun, Zailiang" <zailiang.sun@intel.com>]

Mike, That make sense for me. /Zailiang

-----Original Message-----
From: Kinney, Michael D 
Sent: Saturday, July 13, 2019 7:42 AM
To: devel@edk2.groups.io; glin@suse.com; Sun, Zailiang <zailiang.sun@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Qian, Yi <yi.qian@intel.com>
Subject: RE: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

Zailiang,

This appears to be the behavior of GIT when the Author of
a patch is not the same as the person who sends the patch
email.  The "From:" line is shows the Author of the patch
and is used to fill in the Author field when the patch
email is applied to a git repo.  So no edits to the commit
messages are required.  It will be correct when I push.
It is correct in my local git repo/log.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Gary Lin
> Sent: Wednesday, July 10, 2019 11:09 PM
> To: devel@edk2.groups.io; Sun, Zailiang
> <zailiang.sun@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Qian,
> Yi <yi.qian@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 10/28]
> Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM
> 
> On Thu, Jul 11, 2019 at 04:52:10AM +0000,  Sun, Zailiang
> wrote:
> > Gary,
> >
> > I suggest remove the first line "From: Gary Lin
> <glin@suse.com>" from the description section since you
> have appended the "signed-off-by" declaration.
> >
> Hi Zailiang,
> 
> That is added by Mike. I'm totally fine if you remove it
> when pushing the commits.
> 
> Thanks,
> 
> Gary Lin
> 
> > > -----Original Message-----
> > > From: Kinney, Michael D
> > > Sent: Thursday, July 11, 2019 3:05 AM
> > > To: devel@edk2.groups.io
> > > Cc: Gary Lin <glin@suse.com>; Sun, Zailiang
> > > <zailiang.sun@intel.com>; Qian, Yi
> <yi.qian@intel.com>
> > > Subject: [edk2-platforms Patch 10/28]
> Vlv2TbltDevicePkg/bld_vlv.sh:
> > > Create Vlv.ROM
> > >
> > > From: Gary Lin <glin@suse.com>
> > >
> > > The scripts for PlatformCapsuleGcc.dsc need Vlv.ROM.
> > >
> > > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > > Cc: Yi Qian <yi.qian@intel.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Signed-off-by: Gary Lin <glin@suse.com>
> > > ---
> > >  Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> > > b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> > > index 7fd5f44264..c68e59398a 100755
> > > --- a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> > > +++ b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
> > > @@ -199,6 +199,8 @@ echo Skip "Running fce..."
> > >
> > >
> ##*******************************************************
> *
> > > **************
> > >  ## Build Capsules
> > >
> > >
> ##*******************************************************
> *
> > > **************
> > > +cp -f
> > >
> $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN
> _TAG}/F
> > > V/VLV.fd \
> > > +
> > >
> $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN
> _TAG}/F
> > > V/Vlv.ROM
> > >  build -p $PLATFORM_PKG_PATH/PlatformCapsuleGcc.dsc
> > >
> > >  echo
> > > --
> > > 2.21.0.windows.1
> >
> >
> >
> >
> >
> 
>