From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zailiang.sun@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Fri, 12 Jul 2019 21:17:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2019 21:17:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,485,1557212400"; d="scan'208";a="177689897" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 12 Jul 2019 21:17:07 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 12 Jul 2019 21:17:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 12 Jul 2019 21:17:06 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000; Sat, 13 Jul 2019 12:17:05 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" , "glin@suse.com" CC: "Qian, Yi" Subject: Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM Thread-Topic: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM Thread-Index: AQHVN1J0HQDHQDEfTkSq1hmuTAZXg6bE2SKQ//+QR4CAArivgIAA0r1Q Date: Sat, 13 Jul 2019 04:17:04 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C96843@SHSMSX104.ccr.corp.intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> <20190710190516.6012-11-michael.d.kinney@intel.com> <7CB7EF03E15B5D48981329A508747A9850C95DEE@SHSMSX104.ccr.corp.intel.com> <20190711060827.GJ5004@GaryWorkstation> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTZkODcwOWMtYmNkNC00NmI4LWJjOGQtMzJiMWEwOTFhNGM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY1ljUmRGRWE1cXRWQXVcL3pRcVpOQkt6N3pPVzY3RlUrWjlFd0J6ZkVpY2NsdHZOTDRTQWpEbng5OE9SandKYkgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike, That make sense for me. /Zailiang -----Original Message----- From: Kinney, Michael D=20 Sent: Saturday, July 13, 2019 7:42 AM To: devel@edk2.groups.io; glin@suse.com; Sun, Zailiang ; Kinney, Michael D Cc: Qian, Yi Subject: RE: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/b= ld_vlv.sh: Create Vlv.ROM Zailiang, This appears to be the behavior of GIT when the Author of a patch is not the same as the person who sends the patch email. The "From:" line is shows the Author of the patch and is used to fill in the Author field when the patch email is applied to a git repo. So no edits to the commit messages are required. It will be correct when I push. It is correct in my local git repo/log. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Gary Lin > Sent: Wednesday, July 10, 2019 11:09 PM > To: devel@edk2.groups.io; Sun, Zailiang > > Cc: Kinney, Michael D ; Qian, > Yi > Subject: Re: [edk2-devel] [edk2-platforms Patch 10/28] > Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM >=20 > On Thu, Jul 11, 2019 at 04:52:10AM +0000, Sun, Zailiang > wrote: > > Gary, > > > > I suggest remove the first line "From: Gary Lin > " from the description section since you > have appended the "signed-off-by" declaration. > > > Hi Zailiang, >=20 > That is added by Mike. I'm totally fine if you remove it > when pushing the commits. >=20 > Thanks, >=20 > Gary Lin >=20 > > > -----Original Message----- > > > From: Kinney, Michael D > > > Sent: Thursday, July 11, 2019 3:05 AM > > > To: devel@edk2.groups.io > > > Cc: Gary Lin ; Sun, Zailiang > > > ; Qian, Yi > > > > Subject: [edk2-platforms Patch 10/28] > Vlv2TbltDevicePkg/bld_vlv.sh: > > > Create Vlv.ROM > > > > > > From: Gary Lin > > > > > > The scripts for PlatformCapsuleGcc.dsc need Vlv.ROM. > > > > > > Cc: Zailiang Sun > > > Cc: Yi Qian > > > Cc: Michael D Kinney > > > Signed-off-by: Gary Lin > > > --- > > > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git > a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > > b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > > index 7fd5f44264..c68e59398a 100755 > > > --- a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > > +++ b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > > @@ -199,6 +199,8 @@ echo Skip "Running fce..." > > > > > > > ##******************************************************* > * > > > ************** > > > ## Build Capsules > > > > > > > ##******************************************************* > * > > > ************** > > > +cp -f > > > > $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN > _TAG}/F > > > V/VLV.fd \ > > > + > > > > $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN > _TAG}/F > > > V/Vlv.ROM > > > build -p $PLATFORM_PKG_PATH/PlatformCapsuleGcc.dsc > > > > > > echo > > > -- > > > 2.21.0.windows.1 > > > > > > > > > > >=20 >=20