From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zailiang.sun@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Mon, 22 Jul 2019 18:31:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 18:31:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,297,1559545200"; d="scan'208";a="180581465" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 22 Jul 2019 18:31:18 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jul 2019 18:31:18 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jul 2019 18:31:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000; Tue, 23 Jul 2019 09:31:16 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Qian, Yi" , Gary Lin Subject: Re: [edk2-platforms Patch V3 07/12] Vlv2Tbl2DevicePkg/EfiRegTableLib: Use S3_BOOT_SCRIPT_LIB_WIDTH Thread-Topic: [edk2-platforms Patch V3 07/12] Vlv2Tbl2DevicePkg/EfiRegTableLib: Use S3_BOOT_SCRIPT_LIB_WIDTH Thread-Index: AQHVQOEb/gk5RznFFEu36GiKLbx32abXatrQ Date: Tue, 23 Jul 2019 01:31:15 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C99090@SHSMSX104.ccr.corp.intel.com> References: <20190722225859.24724-1-michael.d.kinney@intel.com> <20190722225859.24724-8-michael.d.kinney@intel.com> In-Reply-To: <20190722225859.24724-8-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, July 23, 2019 6:59 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-platforms Patch V3 07/12] Vlv2Tbl2DevicePkg/EfiRegTableLib= : > Use S3_BOOT_SCRIPT_LIB_WIDTH >=20 > Update calls to S3BootScriptxxx() services to use type > S3_BOOT_SCRIPT_LIB_WIDTH instead of EFI_BOOT_SCRIPT_WIDTH. > Fixes XCODE5 build failures. >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Gary Lin > Signed-off-by: Michael D Kinney > --- > .../Library/EfiRegTableLib/EfiRegTableLib.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.= c > b/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.= c > index d698f3ada9..8b16585337 100644 > --- > a/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.= c > +++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTabl > +++ eLib.c > @@ -55,7 +55,7 @@ PciWrite ( >=20 > if (OPCODE_FLAGS (Entry->OpCode) & OPCODE_FLAG_S3SAVE) { > Status =3D S3BootScriptSavePciCfgWrite ( > - (EFI_BOOT_SCRIPT_WIDTH) (OPCODE_EXTRA_DATA (Entry- > >OpCode)), > + (S3_BOOT_SCRIPT_LIB_WIDTH) (OPCODE_EXTRA_DATA > + (Entry->OpCode)), > (UINT64) Entry->PciAddress, > 1, > &Entry->Data > @@ -111,7 +111,7 @@ PciReadModifyWrite ( >=20 > if (OPCODE_FLAGS (Entry->OpCode) & OPCODE_FLAG_S3SAVE) { > Status =3D S3BootScriptSavePciCfgReadWrite ( > - (EFI_BOOT_SCRIPT_WIDTH) (OPCODE_EXTRA_DATA (Entry- > >OpCode)), > + (S3_BOOT_SCRIPT_LIB_WIDTH) (OPCODE_EXTRA_DATA > + (Entry->OpCode)), > (UINT64) Entry->PciAddress, > &Entry->OrMask, > &Entry->AndMask > @@ -167,7 +167,7 @@ MemReadModifyWrite ( >=20 > if (OPCODE_FLAGS (Entry->OpCode) & OPCODE_FLAG_S3SAVE) { > Status =3D S3BootScriptSaveMemReadWrite ( > - (EFI_BOOT_SCRIPT_WIDTH) (OPCODE_EXTRA_DATA (Entry- > >OpCode)), > + (S3_BOOT_SCRIPT_LIB_WIDTH) (OPCODE_EXTRA_DATA > + (Entry->OpCode)), > Entry->MemAddress, > &Entry->OrMask, > &Entry->AndMask > -- > 2.21.0.windows.1