From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zailiang.sun@intel.com)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by groups.io with SMTP; Mon, 22 Jul 2019 18:31:30 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 18:31:29 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,297,1559545200"; 
   d="scan'208";a="160044357"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
  by orsmga007.jf.intel.com with ESMTP; 22 Jul 2019 18:31:29 -0700
Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 22 Jul 2019 18:31:29 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 22 Jul 2019 18:31:29 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000;
 Tue, 23 Jul 2019 09:31:27 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Qian, Yi" <yi.qian@intel.com>, Gary Lin <glin@suse.com>
Subject: Re: [edk2-platforms Patch V3 08/12] Vlv2TbltDevicePkg/PlatformDxe: Add missing #if
Thread-Topic: [edk2-platforms Patch V3 08/12] Vlv2TbltDevicePkg/PlatformDxe:
 Add missing #if
Thread-Index: AQHVQOEds6OARbgbXU+jWJ4fUGjROKbXauag
Date: Tue, 23 Jul 2019 01:31:27 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C990AB@SHSMSX104.ccr.corp.intel.com>
References: <20190722225859.24724-1-michael.d.kinney@intel.com>
 <20190722225859.24724-9-michael.d.kinney@intel.com>
In-Reply-To: <20190722225859.24724-9-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Tuesday, July 23, 2019 6:59 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>;
> Gary Lin <glin@suse.com>
> Subject: [edk2-platforms Patch V3 08/12] Vlv2TbltDevicePkg/PlatformDxe:
> Add missing #if
>=20
> Add missing #if for SENSOR_INFO_VAR_SUPPORT around the function
> InitializeSensorInfoVariable().  This function is referencing 2 global va=
riables
> that are not defined, and this breaks VS2017 for undefined global variabl=
es.
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Gary Lin <glin@suse.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SensorVar.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SensorVar.c
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SensorVar.c
> index 5d13e99443..6efb989bc0 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SensorVar.c
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SensorVar.c
> @@ -85,6 +85,7 @@ SENSOR_INFO_VAR               mSensorInfoData =3D
>      }
>  };
>=20
> +#if defined(SENSOR_INFO_VAR_SUPPORT) &&
> SENSOR_INFO_VAR_SUPPORT !=3D 0
>  /**
>=20
>    Write the Sensor Info variable if it does not already exist.
> @@ -109,4 +110,5 @@ InitializeSensorInfoVariable (
>           &mSensorInfoData
>           );
>  }
> +#endif
>=20
> --
> 2.21.0.windows.1