public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Gary Lin <glin@suse.com>
Subject: Re: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression
Date: Sun, 11 Aug 2019 15:37:00 +0000	[thread overview]
Message-ID: <7CB7EF03E15B5D48981329A508747A9850CAA6CE@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190809193403.7392-1-michael.d.kinney@intel.com>

Reviewed-by: Zailiang Sun <Zailiang.sun@intel.com>

-----Original Message-----
From: Kinney, Michael D 
Sent: Saturday, August 10, 2019 3:34 AM
To: devel@edk2.groups.io
Cc: Sun, Zailiang <zailiang.sun@intel.com>; Gary Lin <glin@suse.com>
Subject: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig().  This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.

https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5

The call to SetupInfo() is added back.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Gary Lin <glin@suse.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index 7a4987f656..f3850b2aff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -150,6 +150,7 @@ SystemConfigExtractConfig (
   OUT EFI_STRING                             *Results
   )
 {
+  SetupInfo();
   return EFI_UNSUPPORTED;
 }
 
-- 
2.21.0.windows.1


  reply	other threads:[~2019-08-11 15:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 19:34 [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Michael D Kinney
2019-08-11 15:37 ` Sun, Zailiang [this message]
2019-08-12  2:33 ` Gary Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7CB7EF03E15B5D48981329A508747A9850CAA6CE@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox