From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zailiang.sun@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Sun, 11 Aug 2019 08:37:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 08:37:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,373,1559545200"; d="scan'208";a="350960656" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 11 Aug 2019 08:37:02 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 08:37:02 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 08:37:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Sun, 11 Aug 2019 23:37:00 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Gary Lin Subject: Re: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Thread-Topic: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Thread-Index: AQHVTulqT0H5jAVsqEO75XXZGlYUC6b2F0cw Date: Sun, 11 Aug 2019 15:37:00 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850CAA6CE@SHSMSX104.ccr.corp.intel.com> References: <20190809193403.7392-1-michael.d.kinney@intel.com> In-Reply-To: <20190809193403.7392-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGNiZjcxYmMtYzY2ZS00OGIxLWJhZWItODAyNzU5MzJkNzhmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWHJVVGRrcVdFZkJkUDF4SmZubVJCRTZXVVplNlFmVFNJT0F3bzFkazE5TG56S1RnakU3dEZJNGl6TUJVUktveSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zailiang Sun -----Original Message----- From: Kinney, Michael D=20 Sent: Saturday, August 10, 2019 3:34 AM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Gary Lin Subject: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regress= ion The following commit removed the call to SetupInfo() from SystemConfigExtractConfig(). This caused the BIOS, Processor, Platform, and Memory information strings from being filled in with their proper values. https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4= 541bc2cb74c10ea5 The call to SetupInfo() is added back. Cc: Zailiang Sun Cc: Gary Lin Signed-off-by: Michael D Kinney --- .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetu= pDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe= .c index 7a4987f656..f3850b2aff 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c @@ -150,6 +150,7 @@ SystemConfigExtractConfig ( OUT EFI_STRING *Results ) { + SetupInfo(); return EFI_UNSUPPORTED; } =20 --=20 2.21.0.windows.1