From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zailiang.sun@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Sun, 11 Aug 2019 08:37:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 08:37:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,373,1559545200"; d="scan'208";a="180627475" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 11 Aug 2019 08:37:56 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 08:37:56 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 08:37:56 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Sun, 11 Aug 2019 23:37:54 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Gary Lin Subject: Re: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic Thread-Topic: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic Thread-Index: AQHVTvjB3owxedhi+keDzsJ+uTxEyqb2F4Ug Date: Sun, 11 Aug 2019 15:37:54 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850CAA6ED@SHSMSX104.ccr.corp.intel.com> References: <20190809212348.12492-1-michael.d.kinney@intel.com> In-Reply-To: <20190809212348.12492-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDhlZTdkYjctYWI2NC00YTYyLWIwYTgtMWMyMjUxZmE2YjkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVm9Pb21CcU9mSTlyd3JtMmllRkhtTjE4ZGFKbnBHRW5LYzQwUExORW5iU1hFTjRKR3d0cnREdG4rSUVEeDR3OSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, August 10, 2019 5:24 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Gary Lin > Subject: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instr= insic >=20 > VS2017 builds for X64 are failing due to the use of the > memset intrinsic. The local variable GopVersion is an > array that is initialied in the declaration. Update to > use ZeroMem() to intialize GopVersion. >=20 > Cc: Zailiang Sun > Cc: Gary Lin > Signed-off-by: Michael D Kinney > --- > .../Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpReg= ion.c > b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c > index fcd9e566ae..3815c8fa9c 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c > +++ b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c > @@ -493,9 +493,10 @@ SetGOPVersionCallback ( > IN VOID *Context > ) > { > - CHAR16 GopVersion[16] =3D {0}; > + CHAR16 GopVersion[16]; > EFI_STATUS Status; >=20 > + ZeroMem (GopVersion, sizeof (GopVersion)); > Status =3D GetGOPDriverVersion(GopVersion); > if(!EFI_ERROR(Status)) { > StrCpy((CHAR16*)&(mIgdOpRegion.OpRegion->Header.GOPV[0]), > GopVersion); > -- > 2.21.0.windows.1