From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.889.1581489109086202233 for ; Tue, 11 Feb 2020 22:31:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zailiang.sun@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 22:31:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="266552358" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 11 Feb 2020 22:31:48 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Feb 2020 22:31:48 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Feb 2020 22:31:47 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.5]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.158]) with mapi id 14.03.0439.000; Wed, 12 Feb 2020 14:31:46 +0800 From: "Sun, Zailiang" To: Gary Lin , "devel@edk2.groups.io" CC: "Qian, Yi" Subject: Re: [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules Thread-Topic: [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files with signed capsules Thread-Index: AQHV4W2CGRZGdpxK6Ui20ikuEvHLU6gXGPpg Date: Wed, 12 Feb 2020 06:31:46 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850D288D1@SHSMSX104.ccr.corp.intel.com> References: <20200212062403.21714-1-glin@suse.com> In-Reply-To: <20200212062403.21714-1-glin@suse.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Lin, Next time you might need have Mike Kinney in the cc list:) Reviewed-by: Zailiang Sun -----Original Message----- From: Gary Lin =20 Sent: Wednesday, February 12, 2020 2:24 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [PATCH 1/2] Vlv2TbltDevicePkg/GenerateCapsule: Create cab files wi= th signed capsules The cab file previously contained the unsigned payload without the FMP header, so the firmware would reject the capsule generated by fwupd based on the cab file. This commit copies the signed capsule into the cab file so that fwupd can generate a valid capsule. Cc: Zailiang Sun cc: Yi Qian Signed-off-by: Gary Lin --- .../Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py | = 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsu= le/GenCapsuleAll.py b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Gene= rateCapsule/GenCapsuleAll.py index a37648ac96..1a6c597c4a 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenC= apsuleAll.py +++ b/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenC= apsuleAll.py @@ -181,7 +181,7 @@ def GenCapsuleDevice (BaseName, PayloadFileName, Guid, = Version, Lsv, CapsulesPat LogAlways (ProcessOutput[0].decode()) Error ('GenerateCapsule returned an error') =20 - Copy (PayloadFileName, (CapsulesPath, 'firmware.bin')) + Copy (FmpCapsuleFile, (CapsulesPath, 'firmware.bin')) MetaInfoXml =3D MetaInfoXmlTemplate MetaInfoXml =3D MetaInfoXml.replace ('FMP_CAPSULE_GUID', Guid) MetaInfoXml =3D MetaInfoXml.replace ('FMP_CAPSULE_BASE_NAME', BaseName= ) --=20 2.16.4