From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C81EC820E6 for ; Wed, 8 Feb 2017 10:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1486577971; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=22ebqCqheMnKRTiHlp9gyh/1bnnOCIxkI/c4r0sTHJk=; b=sB04JSs9Ncfv1eaa9EzCjdXfrrSQeZkbJxD+ucHE4sgfEj+9f6xr67uiyvUaoms1 JbAAAn60W5K+sC8B9UEfnROvd1YPR9aTqBHALND7xs6H/EbWzscyfUtvIDlI7EGq aVLWDSp2Kn6cPWkwtIRvZ506bYcaff3GIsEXT3K7i1j9wqXyrVF1V/5IbHyUdeOL 8fktrSkQLrTbdOunZ3p9Wt01FP2sKj1yyfH48KAmc50nnyByVU/jC0gu8njQCk8x FKcAgtOZPlD10v4hUnAOENr6YrBMnD88iTiK6kJAGt9+0dZooToaZucD/lcPcPA8 vfP6zDJlBsH4H7w75nCpyg==; Received: from relay2.apple.com (relay2.apple.com [17.128.113.67]) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id FA.3C.14588.3316B985; Wed, 8 Feb 2017 10:19:31 -0800 (PST) X-AuditID: 11973e16-fa0ae9a0000038fc-ef-589b61330451 Received: from nwk-mmpp-sz06.apple.com (nwk-mmpp-sz06.apple.com [17.128.115.234]) by relay2.apple.com (Apple SCV relay) with SMTP id 00.C6.11444.3316B985; Wed, 8 Feb 2017 10:19:31 -0800 (PST) MIME-version: 1.0 Received: from [17.153.49.34] (unknown [17.153.49.34]) by nwk-mmpp-sz06.apple.com (Oracle Communications Messaging Server 8.0.1.2.0 64bit (built Dec 14 2016)) with ESMTPSA id <0OL200IE3IWHUI30@nwk-mmpp-sz06.apple.com>; Wed, 08 Feb 2017 10:19:31 -0800 (PST) Sender: afish@apple.com From: Andrew Fish Message-id: <7E0E995C-B4E4-47A7-BB99-1F8A0455C85D@apple.com> Date: Wed, 08 Feb 2017 10:19:29 -0800 In-reply-to: Cc: Mike Kinney , "edk2-devel@lists.01.org" , "Gao, Liming" , "Yao, Jiewen" , "Zeng, Star" To: "Carsey, Jaben" References: <1486097737-12816-1-git-send-email-michael.d.kinney@intel.com> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsUi2FDorGucODvC4EGbtMWeQ0eZLTY2/WG1 WPfRw2LFvQ3sFh0d/5gs9vVaO7B5LN7zksmje/Y/lgCmKC6blNSczLLUIn27BK6MhY/3sxR8 yKu4+HYNawPjuoQuRg4OCQETiSufI7sYuTiEBPYySuzZtoSpi5ETLN616BILROIQo8S6pt3s IAleAUGJH5PvsYDYzAJhEpdbP7NBFHUwSXw/PZsVJCEsIC7x7swmZhCbTUBZYsX8D1DNNhLr PlxigahxlZh0qAMsziKgKnF9YwsLyEWcQEP3nBMFmckscJ1RYnb/DTaQGhEBHYnVtz6DzRQS mMIo0XvHBeIDWYnZv7xA6iUEXrNJ/Fq3gXkCo9AsJLfOQnIrhK0l8f1RK1CcA8iWlzh4XhYi rCnx7N4ndghbW+LJuwusCxjZVjEK5SZm5uhm5pnrJRYU5KTqJefnbmIERct0O7EdjA9XWR1i FOBgVOLhvWA9O0KINbGsuDL3EKM0B4uSOC+/ycwIIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxS DYz6q2t5Nlk2RQsd2ch4y90rrcd2sfOm7TkVl2eK+l1apv+r5HrUpk3NM7tTr8+u/n/rC4/N rrgH9+tihFyCLp2dH+4ltak6qGJbXQoPV9Cdy6eWfauPt1TcVuVptLF757Hw8Ik1m05E+T0K Oldd1dGyTXPB78qGqp0cs68fe+Kz6HPM0roSfj4lluKMREMt5qLiRABgp3JhdwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsUi2FD8Stc4cXaEwd+5QhZ7Dh1lttjY9IfV Yt1HD4sV9zawW3R0/GOy2Ndr7cDmsXjPSyaP7tn/WAKYorhsUlJzMstSi/TtErgyFj7ez1Lw Ia/i4ts1rA2M6xK6GDk5JARMJLoWXWKBsMUkLtxbz9bFyMUhJHCIUWJd0252kASvgKDEj8n3 wIqYBcIkLrd+hirqYJL4fno2K0hCWEBc4t2ZTcwgNpuAssSK+R+gmm0k1n2A2CAs4Cox6VAH WJxFQFXi+sYWoDgHByfQ0D3nREFmMgtcZ5SY3X+DDaRGREBHYvWtz2AzhQSmMEr03nEBqZcQ kJWY/ctrAqPALCTnzUJyHoStJfH9UStQnAPIlpc4eF4WIqwp8ezeJ3YIW1viybsLrAsY2VYx ChSl5iRWGuklFhTkpOol5+duYgSHfaHzDsZjy6wOMQpwMCrx8F6wnh0hxJpYVlyZCwwjDmYl Ed5HsUAh3pTEyqrUovz4otKc1OJDjBMZgX6cyCwlmpwPjMq8knhDExMDE2NjM2NjcxNzWgor ifN67J8RISSQnliSmp2aWpBaBHMUEwenVAPjSnmTk96LldqOv/q17tCPkN9V9o3fbgh0rm/Q OXrDRfn636vhGSdnpKl+rTkn52noJvrX0KCMyeLXescT8rYbdjLmKyU4RervyV+XuSs1NfT+ 97lrdf109hxcYMt76vb8G+4MxffuHJ988lVi8OLmG/YOc07J/1aaOXXd69IDHt2MXWEJlxeu UmIpzkg01GIuKk4EAFLAdFvuAgAA X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v4 0/3] Remove TimerLib dependency from DP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 18:19:31 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Feb 3, 2017, at 9:47 AM, Carsey, Jaben wrote: > > I am good with this change. I like the idea of changing platforms that build the shell from source in a separate patch series. > > Reviewed-by: Jaben Carsey > Mike, This looks good. Reviewed-by: Andrew Fish > Thanks, Andrew Fish >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Michael Kinney >> Sent: Thursday, February 2, 2017 8:56 PM >> To: edk2-devel@lists.01.org >> Cc: Andrew Fish ; Gao, Liming ; Yao, >> Jiewen ; Carsey, Jaben ; >> Zeng, Star >> Subject: [edk2] [PATCH v4 0/3] Remove TimerLib dependency from DP >> Importance: High >> >> Current DP implementation depends on TimerLib, as different platforms may >> implement and use their own TimerLib, it makes the dp needs to be built by >> platform. The TimerLib dependency can be removed by using performance >> property configuration table to make DP to be generic. >> >> There was a discussion on edk2-devel about supporting use of different TimerLib >> instances in different modules and updating the performance log to support >> measurements with different timer rates. A complete solution for this has not >> been found. >> >> This patch series that allows the DP command to get the timer rate from a >> system configuration table is useful on its own because it allows the DP shell >> command to be independent of the TimerLib used to collect the performance >> logs. >> >> V3: >> Define and install performance property configuration table instead of >> extending PEI performance log HOB. As user may want to only dump DXE or >> SMM performance data, then PeiPerformanceLib will be not linked and PEI >> performance log HOB will be not built. >> >> V4: >> Change name of field in PERFORMANCE_PROPERTY from CpuFreq to Frequency. >> >> Cc: Andrew Fish >> Cc: Michael Kinney >> Cc: Liming Gao >> Cc: Jiewen Yao >> Cc: Cinnamon Shia >> Cc: Jaben Carsey >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Star Zeng >> >> Star Zeng (3): >> MdeModulePkg: Add performance property configuration table >> PerformancePkg Dp_App: Remove TimerLib dependency >> ShellPkg UefiDpLib: Remove TimerLib dependency >> >> MdeModulePkg/Include/Guid/Performance.h | 12 +++++++- >> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 23 ++++++++++++-- >> .../DxeCorePerformanceLib.inf | 2 ++ >> .../DxeCorePerformanceLibInternal.h | 3 +- >> .../SmmCorePerformanceLib/SmmCorePerformanceLib.c | 18 +++++++++++ >> .../SmmCorePerformanceLib.inf | 5 +++- >> PerformancePkg/Dp_App/Dp.c | 35 +++++++++++----------- >> PerformancePkg/Dp_App/Dp.inf | 6 ++-- >> PerformancePkg/Dp_App/DpInternal.h | 6 ++-- >> PerformancePkg/Dp_App/DpProfile.c | 3 +- >> PerformancePkg/Dp_App/DpStrings.uni | 10 ++++--- >> PerformancePkg/Dp_App/DpTrace.c | 25 ++-------------- >> PerformancePkg/Dp_App/DpUtilities.c | 3 +- >> PerformancePkg/Dp_App/Literals.c | 3 +- >> ShellPkg/Library/UefiDpLib/Dp.c | 29 +++++++----------- >> ShellPkg/Library/UefiDpLib/DpInternal.h | 6 ++-- >> ShellPkg/Library/UefiDpLib/DpProfile.c | 3 +- >> ShellPkg/Library/UefiDpLib/DpTrace.c | 25 ++-------------- >> ShellPkg/Library/UefiDpLib/DpUtilities.c | 3 +- >> ShellPkg/Library/UefiDpLib/Literals.c | 3 +- >> ShellPkg/Library/UefiDpLib/UefiDpLib.inf | 6 ++-- >> ShellPkg/Library/UefiDpLib/UefiDpLib.uni | 3 +- >> ShellPkg/ShellPkg.dsc | 3 +- >> 23 files changed, 117 insertions(+), 118 deletions(-) >> >> -- >> 2.6.3.windows.1 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel