From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.protonmail.ch (mail1.protonmail.ch [185.70.40.18]) by mx.groups.io with SMTP id smtpd.web11.6821.1581404965900797685 for ; Mon, 10 Feb 2020 23:09:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@protonmail.com header.s=default header.b=WNdW4QrU; spf=pass (domain: protonmail.com, ip: 185.70.40.18, mailfrom: vit9696@protonmail.com) Date: Tue, 11 Feb 2020 07:09:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1581404962; bh=5/zp3PGJ8OBSVdPLQ8kh6rhbJXFbfsXoamqk4+kpGvg=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=WNdW4QrUjcOawx80t2I3SU/W4/PFWY5b2A7UjNOFZhAkvmYgISYcbCpPXIDQThlgS UsqFCmbtbDRMnI3+Nr/SF5HBvfQQF9+9p4uFcN4kIDT15aUYP0RoqmsPD2cmadllSB YvAdXGxhAe7c6rNrZNUNQKJtSRYyOSiOLC9EuAZw= To: "Gao, Liming" , zhiguang.liu@intel.com, steven.shi@intel.com From: "Vitaly Cheptsov" Cc: "devel@edk2.groups.io" Reply-To: vit9696 Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Message-ID: <7ED61A40-41D8-46E6-A8E9-3C6555D50C0E@protonmail.com> In-Reply-To: References: <20200210105919.19192-1-vit9696@protonmail.com> <20200210105919.19192-2-vit9696@protonmail.com> <7399fb4286314a9bb4c0378a6622b844@intel.com> <15F24239275957C5.19576@groups.io> Feedback-ID: p9QuX-L1wMgUm6nrSvNrf8juLupNs0VSnzXGVXuYDxlEahFdWtaedWDMB9zpwGDklGt7kzs1-RBc0cqz327Gcg==:Ext:ProtonMail MIME-Version: 1.0 X-Spam-Status: No, score=-0.7 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT,HTML_FONT_LOW_CONTRAST, HTML_MESSAGE shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Groupsio-MsgNum: 54186 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="---------------------8d0f028f372c8807c6a954bbcd3bc434"; charset=UTF-8 -----------------------8d0f028f372c8807c6a954bbcd3bc434 Cc: "devel@edk2.groups.io" Content-Type: multipart/alternative; boundary="Apple-Mail=_605EDFAB-B210-4B04-A976-B0B5C9620F8C" Date: Tue, 11 Feb 2020 10:08:12 +0300 From: vit9696 In-Reply-To: Message-Id: <7ED61A40-41D8-46E6-A8E9-3C6555D50C0E@protonmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) References: <20200210105919.19192-1-vit9696@protonmail.com> <20200210105919.19192-2-vit9696@protonmail.com> <7399fb4286314a9bb4c0378a6622b844@intel.com> <15F24239275957C5.19576@groups.io> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB To: "Gao, Liming" , zhiguang.liu@intel.com, steven.shi@intel.com X-Mailer: Apple Mail (2.3608.60.0.2.5) --Apple-Mail=_605EDFAB-B210-4B04-A976-B0B5C9620F8C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Liming, Done. As a side note, I am not positive how can 7990438f1437f47990a8890dee= 51978cb8dbc25c[1] resolve BZ 2415[2]. The bug was about CLANG38, and the to= olchain updated was CLANGPDB. While it makes sense to update CLANGPDB with = this flag to stay clean (it will not make a difference for clang in GNU mod= e), CLANGPDB has nothing to do to CLANG38. Best wishes, Vitaly [1] https://bugzilla.tianocore.org/show_bug.cgi?id=3D2415 [2] https://github.com/tianocore/edk2/commit/7990438f1437f47990a8890dee519= 78cb8dbc25c > 11 =D1=84=D0=B5=D0=B2=D1=80. 2020 =D0=B3., =D0=B2 09:02, Gao, Liming =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >=20 > Vitaly: > Can you update this patch based on the latest edk2 trunk? I will catch= it for edk2 Q1 stable tag. > > Thanks > Liming > From: devel@edk2.groups.io > On Behalf Of Liming Gao > Sent: Tuesday, February 11, 2020 1:34 PM > To: vit9696 >; de= vel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for = CLANGPDB > > Reviewed-by: Liming Gao > > > From: vit9696 >= =20 > Sent: Tuesday, February 11, 2020 3:23 AM > To: Gao, Liming >; de= vel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for = CLANGPDB > > Liming, > > We did run several of our projects based on EDK II in X64 mode, DEBUG, R= ELEASE, NOOPT. Noticed no change from XCODE5. > > We also tried building several EDK builtin packages like CryptoPkg, MdeP= kg, MdeModulePkg. > > Best wishes, > Vitaly > > =D0=92 =D0=BF=D0=BD, =D1=84=D0=B5=D0=B2=D1=80. 10, 2020 =D0=B2 16:47, Ga= o, Liming > =D0=BF=D0=B8= = =D1=88=D0=B5=D1=82: > Vitaly: > This change is good. Can you your test for it? I verify this patch for O= vmf platform on Windows. It can make ovmf pass build with CLANGPDB. >=20 > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Vitaly Cheptsov via Gr= oups.Io > > Sent: Monday, February 10, 2020 6:59 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CL= ANGPDB > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2397 > > > > Signed-off-by: Vitaly Cheptsov > > > --- > > BaseTools/Conf/tools_def.template | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_= def.template > > index feee2bbf16..6bf6c5768e 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -2755,11 +2755,11 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CL= ANG38_AARCH64_DLINK_FLAGS) -flto -Wl > > DEFINE CLANGPDB_IA32_PREFIX =3D ENV(CLANG_BIN) > > DEFINE CLANGPDB_X64_PREFIX =3D ENV(CLANG_BIN) > > > > -DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-windows > > -DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows > > +DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-windows-gnu > > +DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows-gnu > > > > DEFINE CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-t= autological-compare -Wno-tautological-constant-out- > > of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varar= gs -Wno-unknown-warning-option -Wno-microsoft-enum- > > forward-reference > > -DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB= _WARNING_OVERRIDES) -fno-stack-protector - > > mms-bitfields -Wno-address -Wno-shift-negative-value -Wno-unknown-prag= mas -Wno-incompatible-library-redeclaration -fno- > > asynchronous-unwind-tables -mno-implicit-float -ftrap-function=3Dundef= ined_behavior_has_been_optimized_away_by_clang - > > funsigned-char -fno-ms-extensions -Wno-null-dereference -fms-compatibi= lity -mno-stack-arg-probe > > +DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB= _WARNING_OVERRIDES) -fno-stack-protector - > > fno-asynchronous-unwind-tables -funsigned-char -ftrap-function=3Dundef= ined_behavior_has_been_optimized_away_by_clang -Wno- > > address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatib= le-library-redeclaration -Wno-null-dereference -mno- > > implicit-float -mms-bitfields -mno-stack-arg-probe -nostdlib -nostdlib= inc > > > > ########################### > > # CLANGPDB IA32 definitions > > -- > > 2.21.1 (Apple Git-122.3) > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > > > View/Reply Online (#54130): https://edk2.groups.io/g/devel/message/541= 30 > > Mute This Topic: https://groups.io/mt/71134286/1759384 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D >=20 > > >=20 --Apple-Mail=_605EDFAB-B210-4B04-A976-B0B5C9620F8C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Liming,
Done. As a side note, I am not positive = how can 7990438f1437f47990a8890dee51978cb8dbc25c[1] resolve BZ = 2415[2]. The bug was about CLANG38, and the toolchain updated was CLANGPDB.= While it makes sense to update CLANGPDB with this flag to stay clean (it w= ill not make a difference for clang in GNU mode), CLANGPDB has nothing to d= o to CLANG38.

Bes= t wishes,
Vitaly

<= /div>
[1] https://bugzilla.tianocore.org/show_bug.cgi= ?id=3D2415
[2] https= ://github.com/tianocore/edk2/commit/7990438f1437f47990a8890dee51978cb8dbc25= c


11 =D1=84=D0= =B5=D0=B2=D1=80. 2020 =D0=B3., =D0=B2 09:02, Gao, Liming <liming.gao@intel.com> =D0=BD= =D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):

Vitaly:
  Can you update this p= atch based on the latest edk2 trunk? I will catch it for edk2 Q1 stable tag= .
&n= bsp;
Thanks
Liming
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
Sent: Tuesday, February 11, 2020 1:3= 4 PM
To: vit9696 <vit9696@protonm= ail.com>; devel@edk2.groups.io
Subject: Re: [edk2-d= evel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB
 =
Reviewed-by: Liming Gao <liming.gao@intel.com>
 
From:=  vit9696 <vit9696@protonmail.= com> 
Sent: Tuesday, February 11, 2020 3:23 AM
To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io=
Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode= for CLANGPDB
 
Liming,
 
We did run several of our proj= ects based on EDK II in X64 mode, DEBUG, RELEASE, NOOPT. Noticed no change = from XCODE5.
 
We also tried building several EDK builtin packages= like CryptoPkg, MdePkg, MdeModulePkg.
 =
Best wishes,<= /div>
Vitaly
 <= /o:p>
=D0=92 =D0=BF=D0=BD, =D1=84=D0= = =B5=D0=B2=D1=80. 10, 2020 =D0=B2 16:47, Gao, Liming <liming.gao@intel.com> =D0=BF=D0=B8=D1=88=D0=B5=D1=82:

Vitaly:
Thi= s change is good. Can you your test for it? I verify this patch for Ovmf pl= atform on Windows. It can make ovmf pass build with CLANGPDB.

Thanks
Liming
> -----Origina= l Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Vitaly Cheptsov via Groups.Io> Sent: Monday, February 10, 2020 6:59 PM
>= ; To: devel@edk2.groups.io
> Subject: [edk2-devel]= [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB
><= br class=3D"">> REF: <= a href=3D"https://bugzilla.tianocore.org/show_bug.cgi?id=3D2397" style=3D"c= olor: purple; text-decoration: underline;" class=3D"">https://bugzilla.tian= ocore.org/show_bug.cgi?id=3D2397
>
> = Signed-off-by: Vitaly Cheptsov <vit9696@p= rotonmail.com>
> ---
> BaseTools/C= onf/tools_def.template | 6 +++---
> 1 file changed, 3 inse= rtions(+), 3 deletions(-)
>
> diff --git = a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index feee2bbf16..6bf6c5768e 100755
> --- = a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf= /tools_def.template
> @@ -2755,11 +2755,11 @@ RELEASE_CLAN= G38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl
> DEFINE CLANGPDB_IA32_PREFIX =3D ENV(CLANG_BIN)
> DEFINE CLANGPDB_X64_PREFIX =3D ENV(CLANG_BIN)
>
> -DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-window= s
> -DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown= -windows
> +DEFINE CLANGPDB_IA32_TARGET =3D -target i686-u= nknown-windows-gnu
> +DEFINE CLANGPDB_X64_TARGET =3D -targ= et x86_64-unknown-windows-gnu
>
> DEFINE = CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-tautological-= compare -Wno-tautological-constant-out-
> of-range-compare= -Wno-empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warni= ng-option -Wno-microsoft-enum-
> forward-reference
> -DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(C= LANGPDB_WARNING_OVERRIDES) -fno-stack-protector -
> mms-bi= tfields -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-in= compatible-library-redeclaration -fno-
> asynchronous-unwi= nd-tables -mno-implicit-float -ftrap-function=3Dundefined_behavior_has_been= _optimized_away_by_clang -
> funsigned-char -fno-ms-extens= ions -Wno-null-dereference -fms-compatibility -mno-stack-arg-probe
> +DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(C= LANGPDB_WARNING_OVERRIDES) -fno-stack-protector -
> fno-as= ynchronous-unwind-tables -funsigned-char -ftrap-function=3Dundefined_behavi= or_has_been_optimized_away_by_clang -Wno-
> address -Wno-s= hift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-redeclar= ation -Wno-null-dereference -mno-
> implicit-float -mms-bi= tfields -mno-stack-arg-probe -nostdlib -nostdlibinc
>
> ###########################
> # CLANGPDB IA= 32 definitions
> --
> 2.21.1 (Apple Git-1= 22.3)
>
>
> -=3D-=3D-=3D= -=3D-=3D-=3D
> Gro= ups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#54130): = https://edk2.groups.io/g/devel/message/54130
> Mute Th= is Topic: https://groups.io/mt/71134286/1759384
> Group Owner: = devel+owner@edk2.groups.io
> Unsubscribe: = https://edk2.groups.io/g/devel/unsub<= /a> [liming.gao@intel.com]
>= -=3D-=3D-=3D-=3D-=3D-=3D

 
=
 

--Apple-Mail=_605EDFAB-B210-4B04-A976-B0B5C9620F8C-- -----------------------8d0f028f372c8807c6a954bbcd3bc434 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wsBmBAEBCAAQBQJeQlMaCRBPsoxt7Hy0xQAKCRBPsoxt7Hy0xafNCACErBGq oyerXXJ4Dv6HBQx/b0qzo7YRwz7MIxVs3vBf/2NV1W9yigzJjjjSa1zCUWTS 4f23KXN0LOzacDyF35FI0JyW4RuhSnPoGJ3VkyonaiOxnp5Ne4oWD1fs54dW 8RwegODj5vX0eBeN/VXQoAOSoixt1eChFS0NaSX/IdTfqvyeQ/rFhgQvtmpJ uIXCJhOiBdWZT5K5thBxh2w+Q1/rquDI0pXElxp1Z8VWffIIEZs0IO0OY598 F20AlcDsWNFrOmglkyFnBqd2TyHF6mwLRahFIDQ4d8ibLZur1zksD8YDVmV2 y6Apr/OADbjYHMjb4i0/k33CQQu+ykO3URLm =DwZD -----END PGP SIGNATURE----- -----------------------8d0f028f372c8807c6a954bbcd3bc434--