From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ml01.01.org (Postfix) with ESMTP id 4DB671A1DED for ; Wed, 10 Aug 2016 18:55:37 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 10 Aug 2016 18:55:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,502,1464678000"; d="scan'208";a="1033526122" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 10 Aug 2016 18:55:36 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 18:55:36 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Aug 2016 18:55:36 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.8]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Thu, 11 Aug 2016 09:55:34 +0800 From: "Tian, Feng" To: Shaveta Leekha , Linaro UEFI Mailman List , "edk2-devel@lists.01.org" CC: "Tian, Feng" Thread-Topic: SATA AHCI issue Thread-Index: AdHdlQoTkMMxDwLeSvqGPu7iPmB3BgAAz1fgAAJ5bNAE7gJn8AAC2RPgAAHeECAAHhfkUAAKpG/QAAELvtAAABEXsAAHc0VwACURGyAADZITgAAdS4ZQ Date: Thu, 11 Aug 2016 01:55:33 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE538822157@SHSMSX101.ccr.corp.intel.com> References: <7F1BAD85ADEA444D97065A60D2E97EE538817A7E@SHSMSX101.ccr.corp.intel.com> <7F1BAD85ADEA444D97065A60D2E97EE5388217A4@SHSMSX101.ccr.corp.intel.com> <7F1BAD85ADEA444D97065A60D2E97EE538821A38@SHSMSX101.ccr.corp.intel.com> <7F1BAD85ADEA444D97065A60D2E97EE538821D8C@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: SATA AHCI issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 01:55:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Shaveta I saw the Tftp implemention of UefiShell splits the whole procedure to two = steps, read the file from tftp sever at first, then write the file to speci= fied destination. Do you know which step gets the timeout error? The 1st step is total irrelevant with HDD access. And I didn't see any diff= erence between the 2nd steps and other common write operations. So I am als= o curious on this. I would suggest you to add debug message to Tftp.c & Ahc= iMode.c to see what happens. Thanks Feng -----Original Message----- From: Shaveta Leekha [mailto:shaveta.leekha@nxp.com]=20 Sent: Wednesday, August 10, 2016 7:50 PM To: Tian, Feng ; Linaro UEFI Mailman List ; edk2-devel@lists.01.org Subject: RE: SATA AHCI issue Hi Feng, PRD table entries are 16Byte aligned, as specified by AHCI spec also, it ha= s 4 DWs. I have tried two HDD, but issue is same, TIMEOUT issue. I have also tried copying one file on SATA HDD to another file on same SATA= HDD(filesize > 4MB), No issue occur in this scenario. USB support is not yet there on our platform, so couldn't try that scenario= . Still not sure, where could be the issue? Thanks and Regards, Shaveta -----Original Message----- From: Tian, Feng [mailto:feng.tian@intel.com] Sent: Wednesday, August 10, 2016 10:49 AM To: Shaveta Leekha ; Linaro UEFI Mailman List ; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: SATA AHCI issue PRD entries are organized like AHCI spec Figure 13 said. Thanks Feng -----Original Message----- From: Shaveta Leekha [mailto:shaveta.leekha@nxp.com] Sent: Tuesday, August 9, 2016 7:40 PM To: Tian, Feng ; Linaro UEFI Mailman List ; edk2-devel@lists.01.org Subject: RE: SATA AHCI issue Hi Feng, Yes, I am using Tftp to get the file on HDD. Have tried only one HardDisk, will try SATA disk from other vendors also, t= o get to the root cause. Will also try copying data from SATA to SATA. Are PRD entries aligned in EDK2 code base? (I mean they are aligned on whic= h boundary? 16 Byte? 4KB?) Best Regards, Shaveta -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Tian= , Feng Sent: Tuesday, August 09, 2016 1:38 PM To: Shaveta Leekha ; Linaro UEFI Mailman List ; edk2-devel@lists.01.org Cc: Tian, Feng Subject: Re: [edk2] SATA AHCI issue Hi, Shaveta I saw you are using TFTP cmd to do the test? Did you ever test copying file= from usb stick to the SATA HDD? I just copied a 70M file from usb to SATA and from SATA to SATA. It works w= ell. Does this issue happen at all of your HDDs or only one specific brand model= ? Do you have other helpful info for us to narrow down? Thanks Feng -----Original Message----- From: Shaveta Leekha [mailto:shaveta.leekha@nxp.com] Sent: Tuesday, August 9, 2016 4:03 PM To: Tian, Feng ; Linaro UEFI Mailman List ; edk2-devel@lists.01.org Subject: RE: SATA AHCI issue Hi Feng, Complete stack is: MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf FatPkg/FatPei/FatPei.inf FatPkg/EnhancedFatDxe/Fat.inf Best Regards, Shaveta -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Shav= eta Leekha Sent: Tuesday, August 09, 2016 1:07 PM To: Tian, Feng ; Linaro UEFI Mailman List ; edk2-devel@lists.01.org Subject: Re: [edk2] SATA AHCI issue Hi Feng, Yes for 30MB file, multiple PRD entries would have been created. But I able to write file only upto 4MB size. The protocol stack I am using is: Generic AtaBusDxe driver use EfiAtaPassThruProtocol Generic AtaAtapiPassThr= u driver consumes "EfiIdeControllerInitProtocol" and produces "EfiAtaPassTh= ruProtocol" which is consumed by generic AtaBusDxe driver Platform-specific= SATA driver that produces "EfiIdeControllerInitProtocol I am writing SATA HDD at File level. HDD is formatted with FAT32 which is identified as FileSytem by FATPKG. Snippet of writing onto SATA HDD Filesystem is pasted below. Thanks and Regards, Shaveta UEFI Interactive Shell v2.1 EDK II UEFI v2.50 (LS2080a RDB board EFI Jul 25 2016 00:00:33, 0x00000000) Mapping= table FS0: Alias(s):F6a0a:;BLK0: PciRoot(0x0)/Pci(0x0,0x0)/Sata(0x0,0x0,0x0) Shell>FS0: FS0:\> tftp 192.168.3.161 test2 test Downloading the file 'test2' [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>] 0 Kb -----Original Message----- From: Tian, Feng [mailto:feng.tian@intel.com] Sent: Tuesday, August 09, 2016 8:30 AM To: Shaveta Leekha ; Linaro UEFI Mailman List ; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: SATA AHCI issue Hi, Shaveta No, we will create multiple PRDs if the transfer length is larger than 4M. = each PRD could represent a 4M transfer request and the maximum number of PR= D for each command is 65535. How do you access the HDD? At block level or file level? It happens at all = HDDs or only one specific brand model? Thanks Feng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Shav= eta Leekha Sent: Monday, August 8, 2016 8:07 PM To: Linaro UEFI Mailman List ; edk2-devel@lis= ts.01.org Subject: Re: [edk2] SATA AHCI issue Hi, As per the spec and the code in "AhciMode.c" // According to AHCI 1.3 spec, a PRDT entry can point to a maximum 4MB da= ta block. Does it mean, only one PRD entry is getting transferred successfully? But as the data I am writing onto SATA HDD is 30MB big, what about the rest= of PRDs? What could be went here? Thanks and Regards, Shaveta -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Shav= eta Leekha Sent: Monday, August 08, 2016 5:24 PM To: Linaro UEFI Mailman List ; edk2-devel@lis= ts.01.org Subject: [edk2] SATA AHCI issue Hi, I am facing one Timeout issue while writing big file over my SATA HDD. It in the code of "AhciDmaTransfer " from file AhciMode.c // // Wait for command compelte // FisBaseAddr =3D (UINTN)AhciRegisters->AhciRFis + Port * sizeof (EFI_AHCI_= RECEIVED_FIS); Offset =3D FisBaseAddr + EFI_AHCI_D2H_FIS_OFFSET; Status =3D AhciWaitMemSet ( Offset, EFI_AHCI_FIS_TYPE_MASK, EFI_AHCI_FIS_REGISTER_D2H, This MemSet check fails, what = could be the issue? Timeout ); TimeOut occur while checking FIS_REGISTER_D2H. Any idea about this time out issue? Can it be "Due to un-aligned PRD? Are there multiple PRDs created or single= PRD?" As I am able to write maximum 4MB file on SATA HDD, file above 4MB size fai= led by giving TIMEOUT_ERROR. Thanks and Regards, Shaveta _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel