From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 029091A1DF6 for ; Mon, 22 Aug 2016 20:21:47 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 22 Aug 2016 20:21:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,563,1464678000"; d="scan'208";a="1045667895" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 22 Aug 2016 20:21:47 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 22 Aug 2016 20:21:47 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 22 Aug 2016 20:21:47 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.8]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.181]) with mapi id 14.03.0248.002; Tue, 23 Aug 2016 11:21:45 +0800 From: "Tian, Feng" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Chan, Amy" , "Tian, Feng" Thread-Topic: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific Thread-Index: AQHR8svr7fq40XBy+kiydXMv8sxfj6BV9Q/A Date: Tue, 23 Aug 2016 03:21:43 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE538824F50@SHSMSX101.ccr.corp.intel.com> References: <20160810055611.266232-1-ruiyu.ni@intel.com> <20160810055611.266232-4-ruiyu.ni@intel.com> In-Reply-To: <20160810055611.266232-4-ruiyu.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 03:21:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Do you need directly assert in ResetPlatformSpecific() for this NULL instan= ce? Other series look good to me Reviewed-by: Feng Tian Thanks Feng -----Original Message----- From: Ni, Ruiyu=20 Sent: Wednesday, August 10, 2016 1:56 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Chan, Amy Subject: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement Reset= PlatformSpecific Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian Cc: Amy Chan --- .../BaseResetSystemLibNull.c | 23 ++++++++++++++++++= +++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLib= Null.c b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull= .c index d21a774..b233254 100644 --- a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c +++ b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull +++ .c @@ -1,7 +1,7 @@ /** @file Null Reset System Library instance that only generates ASSERT() conditio= ns. =20 - Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.
+ Copyright (c) 2006 - 2016, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -77,3 +77,24 @@ EnterS3WithImmediateWake ( { ASSERT (FALSE); } + +/** + This function causes a systemwide reset. The exact type of the reset=20 +is defined + by the EFI_GUID that follows the Null-terminated Unicode string passed i= nto ResetData. + If the platform does not recognize the EFI_GUID in ResetData the=20 +platform must pick a + supported reset type to perform.The platform may optionally log the=20 +parameters from + any non-normal reset that occurs. + + @param[in] DataSize The size, in bytes, of ResetData. + @param[in] ResetData The data buffer starts with a Null-terminated str= ing, followed + by the EFI_GUID. +**/ +VOID +EFIAPI +ResetPlatformSpecific ( + IN UINTN DataSize, + IN VOID *ResetData + ) +{ + ResetCold (); +} -- 2.9.0.windows.1