From: "Tian, Feng" <feng.tian@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laszlo Ersek <lersek@redhat.com>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
"Tian, Feng" <feng.tian@intel.com>
Subject: Re: [PATCH] MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver
Date: Wed, 12 Oct 2016 08:51:57 +0000 [thread overview]
Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE566E3175C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu84iW6W2sxde1gBwVrsNZCvBn8PZ0wBBH19OQmM_+E6rw@mail.gmail.com>
Seems nobody objects this path.
reviewed-by: Feng Tian <feng.tian@intel.com>
Thanks
Feng
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
Sent: Wednesday, October 12, 2016 4:36 PM
To: Laszlo Ersek <lersek@redhat.com>
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
Subject: Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver
On 12 October 2016 at 08:08, Laszlo Ersek <lersek@redhat.com> wrote:
> On 10/12/16 04:36, Ni, Ruiyu wrote:
>> I agree with Ard. Building PciBusDxe driver as EBC ARCH is supported
>> from tool perspective, but doesn't make much sense in real world.
>> So the patch is just to resolve the build failure in EBC ARCH.
>
> If Ard is fine with the EBC default for
> PcdPciDegradeResourceForOptionRom that this patch results in, then I
> don't object.
>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
>
Yes, I am fine with that, as long as the default remains FALSE for AARCH64
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> _______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-10-12 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 5:01 [PATCH] MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver Ruiyu Ni
2016-10-11 10:52 ` Laszlo Ersek
2016-10-11 17:03 ` Ard Biesheuvel
2016-10-12 2:36 ` Ni, Ruiyu
2016-10-12 7:08 ` Laszlo Ersek
2016-10-12 8:36 ` Ard Biesheuvel
2016-10-12 8:51 ` Tian, Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F1BAD85ADEA444D97065A60D2E97EE566E3175C@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox