From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 408F61A1E3E for ; Wed, 19 Oct 2016 01:20:52 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 19 Oct 2016 01:20:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,513,1473145200"; d="scan'208";a="1046830695" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 19 Oct 2016 01:20:51 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 19 Oct 2016 01:20:51 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 19 Oct 2016 01:20:50 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0248.002; Wed, 19 Oct 2016 16:20:47 +0800 From: "Tian, Feng" To: Gary Lin , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Tian, Feng" Thread-Topic: [edk2] [PATCH 18/33] MdeModulePkg/Core: Fix typos in comments Thread-Index: AQHSKdbsXNsaw9m7D02RH/uawz3/9KCvb59g Date: Wed, 19 Oct 2016 08:20:46 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE566E3732C@SHSMSX101.ccr.corp.intel.com> References: <20161019070138.16424-1-glin@suse.com> <20161019070138.16424-19-glin@suse.com> In-Reply-To: <20161019070138.16424-19-glin@suse.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 18/33] MdeModulePkg/Core: Fix typos in comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 08:20:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Feng Tian Thanks Feng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gary= Lin Sent: Wednesday, October 19, 2016 3:01 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [edk2] [PATCH 18/33] MdeModulePkg/Core: Fix typos in comments - paramters -> parameters - funciton -> function - dependecy -> dependency - evauated -> evaluated - genric -> generic - retore -> restore - Protocl -> Protocol - availible -> available - elasped -> elapsed - sarted -> started - boundry -> boundary - permenent -> permanent - debuging -> debugging - availble -> available Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- MdeModulePkg/Core/Dxe/DxeMain.h | 20 ++++++++++---------= - MdeModulePkg/Core/Dxe/DxeMain/DxeProtocolNotify.c | 2 +- MdeModulePkg/Core/Dxe/Event/Timer.c | 2 +- MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 4 ++-- MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 4 ++-- MdeModulePkg/Core/Dxe/Hand/Locate.c | 2 +- MdeModulePkg/Core/Dxe/Image/Image.c | 4 ++-- MdeModulePkg/Core/Dxe/Mem/Page.c | 2 +- MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 12 ++++++------ MdeModulePkg/Core/Pei/FwVol/FwVol.c | 2 +- MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- MdeModulePkg/Core/Pei/PeiMain.h | 4 ++-- MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 4 ++-- MdeModulePkg/Core/PiSmmCore/Dependency.c | 4 ++-- MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 2 +- MdeModulePkg/Core/PiSmmCore/Locate.c | 2 +- 16 files changed, 36 insertions(+), 36 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/DxeMain.h b/MdeModulePkg/Core/Dxe/DxeMai= n.h index aefeeb7..327d23a 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.h +++ b/MdeModulePkg/Core/Dxe/DxeMain.h @@ -109,8 +109,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITH= ER EXPRESS OR IMPLIED. =20 =20 /// -/// EFI_DEP_REPLACE_TRUE - Used to dynamically patch the dependecy express= ion -/// to save time. A EFI_DEP_PUSH is evauated one a= n +/// EFI_DEP_REPLACE_TRUE - Used to dynamically patch the dependency expres= sion +/// to save time. A EFI_DEP_PUSH is evaluated one = an /// replaced with EFI_DEP_REPLACE_TRUE. If PI spec'= s Vol 2 /// Driver Execution Environment Core Interface use= 0xff /// as new DEPEX opcode. EFI_DEP_REPLACE_TRUE shoul= d be @@ -141,7 +141,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITH= ER EXPRESS OR IMPLIED. =20 #else /// -/// For genric EFI machines make the default allocations 4K aligned +/// For generic EFI machines make the default allocations 4K aligned /// #define EFI_ACPI_RUNTIME_PAGE_ALLOCATION_ALIGNMENT (EFI_PAGE_SIZE) #define DEFAULT_PAGE_ALLOCATION (EFI_PAGE_SIZE) @@ -246,9 +246,9 @@ typedef struct { UINTN ExitDataSize; =20 /// Pointer to exit data from started image VOID *ExitData; =20 - /// Pointer to pool allocation for context save/retore + /// Pointer to pool allocation for context save/restore VOID *JumpBuffer; =20 - /// Pointer to buffer for context save/retore + /// Pointer to buffer for context save/restore BASE_LIBRARY_JUMP_BUFFER *JumpContext; =20 /// Machine type from PE image UINT16 Machine; =20 @@ -256,7 +256,7 @@ typedef struct { EFI_EBC_PROTOCOL *Ebc; =20 /// Runtime image list EFI_RUNTIME_IMAGE_ENTRY *RuntimeData; =20 - /// Pointer to Loaded Image Device Path Protocl + /// Pointer to Loaded Image Device Path Protocol EFI_DEVICE_PATH_PROTOCOL *LoadedImageDevicePath; =20 /// PeCoffLoader ImageContext PE_COFF_LOADER_IMAGE_CONTEXT ImageContext; @@ -445,7 +445,7 @@ CoreNoti= fyOnProtocolInstallation ( =20 =20 /** - Return TRUE if all AP services are availible. + Return TRUE if all AP services are available. =20 @retval EFI_SUCCESS All AP services are available @retval EFI_NOT_FOUND At least one AP service is not available @@ -473,= 7 +473,7 @@ CalculateEfiHdrCrc ( /** Called by the platform code to process a tick. =20 - @param Duration The number of 100ns elasped since the las= t call + @param Duration The number of 100ns elapsed since the las= t call to TimerTick =20 **/ @@ -1097,7 +1097,7 @@ CoreLocateDevicePath ( @retval EFI_NOT_FOUND No handles match the search. @retval EFI_OUT_OF_RESOURCES There is not enough pool memory to store = the matching results. - @retval EFI_INVALID_PARAMETER One or more paramters are not valid. + @retval EFI_INVALID_PARAMETER One or more parameters are not valid. =20 **/ EFI_STATUS @@ -1458,7 +1458,7 @@ CoreLoadImage ( unloaded. =20 @retval EFI_SUCCESS The image has been unloaded. - @retval EFI_UNSUPPORTED The image has been sarted, and does not = support + @retval EFI_UNSUPPORTED The image has been started, and does not= support unload. @retval EFI_INVALID_PARAMPETER ImageHandle is not a valid image handle. =20 diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeProtocolNotify.c b/MdeModuleP= kg/Core/Dxe/DxeMain/DxeProtocolNotify.c index 034520c..ea7c610 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeProtocolNotify.c +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeProtocolNotify.c @@ -76,7 +76,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST GUID_TO_STRING_PROTOC= OL_ENTRY mMissingProtoc }; =20 /** - Return TRUE if all AP services are availible. + Return TRUE if all AP services are available. =20 @retval EFI_SUCCESS All AP services are available @retval EFI_NOT_FOUND At least one AP service is not available diff --g= it a/MdeModulePkg/Core/Dxe/Event/Timer.c b/MdeModulePkg/Core/Dxe/Event/Time= r.c index 087e55e..6cd4e6c 100644 --- a/MdeModulePkg/Core/Dxe/Event/Timer.c +++ b/MdeModulePkg/Core/Dxe/Event/Timer.c @@ -187,7 +187,7 @@ CoreInitializeTimer ( /** Called by the platform code to process a tick. =20 - @param Duration The number of 100ns elasped since the las= t call + @param Duration The number of 100ns elapsed since the las= t call to TimerTick =20 **/ diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c b/MdeModulePkg/Core/Dxe/Fw= Vol/FwVol.c index 0ca765d..fe12d6e 100644 --- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c +++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c @@ -554,7 +554,7 @@ FvCheck ( DEBUG ((EFI_D_ERROR, "Found a FFS3 formatted file: %g in a non-FFS= 3 formatted FV.\n", &CacheFfsHeader->Name)); FfsHeader =3D (EFI_FFS_FILE_HEADER *) ((UINT8 *) FfsHeader + FFS_F= ILE2_SIZE (CacheFfsHeader)); // - // Adjust pointer to the next 8-byte aligned boundry. + // Adjust pointer to the next 8-byte aligned boundary. // FfsHeader =3D (EFI_FFS_FILE_HEADER *) (((UINTN) FfsHeader + 7) & ~= 0x07); continue; @@ -589,7 +589,7 @@ FvCheck ( } =20 // - // Adjust pointer to the next 8-byte aligned boundry. + // Adjust pointer to the next 8-byte aligned boundary. // FfsHeader =3D (EFI_FFS_FILE_HEADER *)(((UINTN)FfsHeader + 7) & ~0x07); =20 diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c b/MdeModulePkg/C= ore/Dxe/FwVolBlock/FwVolBlock.c index fffd821..f031ef1 100644 --- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c +++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c @@ -234,7 +234,7 @@ FwVolBlockReadBlock ( =20 if (Offset > FvbDevice->LbaCache[LbaIndex].Length) { // - // all exceed boundry, read nothing. + // all exceed boundary, read nothing. // *NumBytes =3D 0; return EFI_BAD_BUFFER_SIZE; @@ -243,7 +243,7 @@ FwVolBlockReadBlock ( NumOfBytesRead =3D *NumBytes; if (Offset + NumOfBytesRead > FvbDevice->LbaCache[LbaIndex].Length) { // - // partial exceed boundry, read data from current postion to end. + // partial exceed boundary, read data from current postion to end. // NumOfBytesRead =3D FvbDevice->LbaCache[LbaIndex].Length - Offset; } diff --git a/MdeModulePkg/Core/Dxe/Hand/Locate.c b/MdeModulePkg/Core/Dxe/Ha= nd/Locate.c index d2b6da8..80df0d4 100644 --- a/MdeModulePkg/Core/Dxe/Hand/Locate.c +++ b/MdeModulePkg/Core/Dxe/Hand/Locate.c @@ -640,7 +640,7 @@ Done: @retval EFI_NOT_FOUND No handles match the search. @retval EFI_OUT_OF_RESOURCES There is not enough pool memory to store = the matching results. - @retval EFI_INVALID_PARAMETER One or more paramters are not valid. + @retval EFI_INVALID_PARAMETER One or more parameters are not valid. =20 **/ EFI_STATUS diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Im= age/Image.c index 351382b..4a8a16d 100644 --- a/MdeModulePkg/Core/Dxe/Image/Image.c +++ b/MdeModulePkg/Core/Dxe/Image/Image.c @@ -507,7 +507,7 @@ CoreLoadPeImage ( } =20 // - // Allocate memory of the correct memory type aligned on the required im= age boundry + // Allocate memory of the correct memory type aligned on the required=20 + image boundary // DstBufAlocated =3D FALSE; if (DstBuffer =3D=3D 0) { @@ -1857,7 +1857,7 @@ Done: unloaded. =20 @retval EFI_SUCCESS The image has been unloaded. - @retval EFI_UNSUPPORTED The image has been sarted, and does not = support + @retval EFI_UNSUPPORTED The image has been started, and does not= support unload. @retval EFI_INVALID_PARAMPETER ImageHandle is not a valid image handle. =20 diff --git a/MdeModulePkg/Core/Dxe/Mem/Page.c b/MdeModulePkg/Core/Dxe/Mem/P= age.c index b02bafb..bda4f63 100644 --- a/MdeModulePkg/Core/Dxe/Mem/Page.c +++ b/MdeModulePkg/Core/Dxe/Mem/Page.c @@ -204,7 +204,7 @@ CoreAddRange ( // If we are in EFI 1.10 compatability mode no event groups will be // found and nothing will happen we we call this function. These events // will get signaled but since a lock is held around the call to this - // function the notificaiton events will only be called after this funci= ton + // function the notificaiton events will only be called after this=20 + function // returns and the lock is released. // CoreNotifySignalList (&gEfiEventMemoryMapChangeGuid); diff --git a/MdeMo= dulePkg/Core/Pei/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Pei/Dispatcher= /Dispatcher.c index 715e9d2..3934ed0 100644 --- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c +++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c @@ -671,8 +671,8 @@ PeiCheckAndSwitchStack ( =20 if (Private->SwitchStackSignal) { // - // Before switch stack from temporary memory to permenent memory, calc= ulate the heap and stack - // usage in temporary memory for debuging. + // Before switch stack from temporary memory to permanent memory, calc= ulate the heap and stack + // usage in temporary memory for debugging. // DEBUG_CODE_BEGIN (); UINT32 *StackPointer; @@ -709,10 +709,10 @@ PeiCheckAndSwitchStack ( // // Reserve the size of new stack at bottom of physical memory // - // The size of new stack in permenent memory must be the same size=20 + // The size of new stack in permanent memory must be the same size // or larger than the size of old stack in temporary memory. // But if new stack is smaller than the size of old stack, we also res= erve - // the size of old stack at bottom of permenent memory. + // the size of old stack at bottom of permanent memory. // NewStackSize =3D RShiftU64 (Private->PhysicalMemoryLength, 1); NewStackSize =3D ALIGN_VALUE (NewStackSize, EFI_PAGE_SIZE); @@ -789,7 = +789,7 @@ PeiCheckAndSwitchStack ( =20 // // Temporary Ram Support PPI is provided by platform, it will copy=20 - // temporary memory to permenent memory and do stack switching. + // temporary memory to permanent memory and do stack switching. // After invoking Temporary Ram Support PPI, the following code's=20 // stack is in permanent memory. // @@ -1142,7 +1142,7 @@ PeiDispatcher ( if ((Private->PeiMemoryInstalled) && (Private->Fv[FvCount].Pei= mState[PeimCount] =3D=3D PEIM_STATE_REGISITER_FOR_SHADOW) && \ (Private->HobList.HandoffInformationTable->BootMode !=3D B= OOT_ON_S3_RESUME || PcdGetBool (PcdShadowPeimOnS3Boot))) { // - // If memory is availble we shadow images by default for per= formance reasons. + // If memory is available we shadow images by default for pe= rformance reasons. // We call the entry point a 2nd time so the module knows it= 's shadowed. // //PERF_START (PeiServices, L"PEIM", PeimFileHandle, 0); diff= --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/= FwVol.c index 6ca41ee..d2eb0bc 100644 --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c @@ -2019,7 +2019,7 @@ FindNextCoreFvHandle ( /** After PeiCore image is shadowed into permanent memory, all build-in FvPp= i should be re-installed with the instance in permanent memory and all cached FvP= pi pointers in - PrivateData->Fv[] array should be fixed up to be pointed to the one in p= ermenant + PrivateData->Fv[] array should be fixed up to be pointed to the one=20 + in permanent memory. =20 @param PrivateData Pointer to PEI_CORE_INSTANCE. diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/C= ore/Pei/Memory/MemoryServices.c index 2f9b9de..4efe143 100644 --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c @@ -222,7 +222,7 @@ PeiAllocatePages ( =20 /** =20 - Pool allocation service. Before permenent memory is discoveried, the poo= l will=20 + Pool allocation service. Before permanent memory is discoveried, the=20 + pool will be allocated the heap in the temporary memory. Genenrally, the size of h= eap in temporary=20 memory does not exceed to 64K, so the biggest pool size could be allocat= ed is=20 64K. diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMai= n.h index 2498320..69eea51 100644 --- a/MdeModulePkg/Core/Pei/PeiMain.h +++ b/MdeModulePkg/Core/Pei/PeiMain.h @@ -1119,7 +1119,7 @@ PeiRegisterForShadow ( @param OldCoreData Pointer to Old PeiCore's private data. If NULL, PeiCore is entered at first time, stack/= heap in temporary memory. If not NULL, PeiCore is entered at second time, s= tack/heap has been moved - to permenent memory. + to permanent memory. =20 **/ VOID @@ -1732,7 +1732,7 @@ extern EFI_PEI_PCI_CFG2_PPI gPeiDefaultPciCfg2Ppi; /** After PeiCore image is shadowed into permanent memory, all build-in FvPp= i should be re-installed with the instance in permanent memory and all cached FvP= pi pointers in - PrivateData->Fv[] array should be fixed up to be pointed to the one in p= ermenant + PrivateData->Fv[] array should be fixed up to be pointed to the one=20 + in permanent memory. =20 @param PrivateData Pointer to PEI_CORE_INSTANCE. diff --git a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c b/MdeModulePkg/Core/Pe= i/PeiMain/PeiMain.c index 956200f..fed34f3 100644 --- a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c +++ b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c @@ -218,7 +218,7 @@ PeiCore ( SetPeiServicesTablePointer ((CONST EFI_PEI_SERVICES **)&OldCoreData-= >Ps); =20 // - // Update HandOffHob for new installed permenent memory + // Update HandOffHob for new installed permanent memory // HandoffInformationTable =3D OldCoreData->HobList.HandoffInformationT= able; if (OldCoreData->HeapOffsetPositive) { @@ -238,7 +238,7 @@ PeiCore ( =20 // // After the whole temporary memory is migrated, then we can allocat= e page in - // permenent memory. + // permanent memory. // OldCoreData->PeiMemoryInstalled =3D TRUE; =20 diff --git a/MdeModulePkg/Core/PiSmmCore/Dependency.c b/MdeModulePkg/Core/P= iSmmCore/Dependency.c index 44f693a..deaf4b4 100644 --- a/MdeModulePkg/Core/PiSmmCore/Dependency.c +++ b/MdeModulePkg/Core/PiSmmCore/Dependency.c @@ -19,8 +19,8 @@ #include "PiSmmCore.h" =20 /// -/// EFI_DEP_REPLACE_TRUE - Used to dynamically patch the dependecy express= ion -/// to save time. A EFI_DEP_PUSH is evauated one a= n +/// EFI_DEP_REPLACE_TRUE - Used to dynamically patch the dependency expres= sion +/// to save time. A EFI_DEP_PUSH is evaluated one = an /// replaced with EFI_DEP_REPLACE_TRUE. If PI spec'= s Vol 2 /// Driver Execution Environment Core Interface use= 0xff /// as new DEPEX opcode. EFI_DEP_REPLACE_TRUE shoul= d be diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c b/MdeModulePkg/Core/P= iSmmCore/Dispatcher.c index 8b34778..87f4617 100644 --- a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c +++ b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c @@ -517,7 +517,7 @@ SmmLoadImage ( ImageContext.ImageAddress =3D (EFI_PHYSICAL_ADDRESS)DstBuffer; } // - // Align buffer on section boundry + // Align buffer on section boundary // ImageContext.ImageAddress +=3D ImageContext.SectionAlignment - 1; ImageContext.ImageAddress &=3D ~((EFI_PHYSICAL_ADDRESS)(ImageContext.Sec= tionAlignment - 1)); diff --git a/MdeModulePkg/Core/PiSmmCore/Locate.c b/Md= eModulePkg/Core/PiSmmCore/Locate.c index 705d6d4..a7220ba 100644 --- a/MdeModulePkg/Core/PiSmmCore/Locate.c +++ b/MdeModulePkg/Core/PiSmmCore/Locate.c @@ -430,7 +430,7 @@ SmmLocateHandle ( @retval EFI_NOT_FOUND No handles match the search. @retval EFI_OUT_OF_RESOURCES There is not enough pool memory to store = the matching results. - @retval EFI_INVALID_PARAMETER One or more paramters are not valid. + @retval EFI_INVALID_PARAMETER One or more parameters are not valid. =20 **/ EFI_STATUS -- 2.10.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel