Re: USB hub port reset

["Tian, Feng" <feng.tian@intel.com>]

I don't catch what you mean. We have had 10ms delay for port reset. Which line of UsbHub.c do you think there is problem? 

Quote from USB2.0 spec:
"Hubs must be able to accept all hub requests and devices must be able to accept a SetAddress() request (refer to
Section 11.24.2 and Section 9.4 respectively) after the reset recovery time 10 ms (TRSTRCY) after the reset is
removed."

Thanks
Feng

-----Original Message-----
From: Anbazhagan, Baraneedharan [mailto:anbazhagan@hp.com] 
Sent: Monday, November 14, 2016 11:33 AM
To: Tian, Feng <feng.tian@intel.com>; edk2-devel@lists.01.org
Subject: RE: USB hub port reset

I didn't mean to have extra delays. Am asking whether EDKII have to be updated for 10ms reset recovery time regardless of port status to align with spec?


>From: Tian, Feng [mailto:feng.tian@intel.com] 
>Sent: Sunday, November 13, 2016 7:46 PM
>To: Anbazhagan, Baraneedharan <anbazhagan@hp.com>; edk2-devel@lists.01.org
>Cc: Tian, Feng <feng.tian@intel.com>
>Subject: RE: USB hub port reset
>
>Hi, Baranee
>
>Linux wait 10 + 40 ms (TRSTRCY = 10 ms, plus extra 40 ms). Do you mean EDKII should be same with linux to wait more time?
>
>Thanks
>Feng
>
>From: Anbazhagan, Baraneedharan [mailto:anbazhagan@hp.com] 
>Sent: Sunday, November 13, 2016 11:53 AM
>To: mailto:edk2-devel@lists.01.org; Tian, Feng <mailto:feng.tian@intel.com>
>Subject: USB hub port reset
>
>EDK2 have reset recovery time of 10ms for hub port based on port status reset bit but USB spec doesn't mention that port status can be used for t6/reset recovery time. Could you please clarify?
>
>USB vendor mentions EDK2 doesn't have reset recovery time on hub port reset and also highlighting EDK2 hub port reset differs from https://github.com/torvalds/linux/blob/master/drivers/usb/core/hub.c#L2789
>
>-Baranee