From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7852D81DCB for ; Sun, 13 Nov 2016 20:38:21 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 13 Nov 2016 20:38:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,488,1473145200"; d="scan'208";a="1068046546" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 13 Nov 2016 20:38:25 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 13 Nov 2016 20:38:25 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 13 Nov 2016 20:38:25 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.239]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Mon, 14 Nov 2016 12:38:21 +0800 From: "Tian, Feng" To: "Anbazhagan, Baraneedharan" , "edk2-devel@lists.01.org" CC: "Tian, Feng" Thread-Topic: USB hub port reset Thread-Index: AdI9P9a4p+GKnaQeTV6wi4G+bYD8YgA2K+ggAABY8XAABZq8YA== Date: Mon, 14 Nov 2016 04:38:21 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE566E4F285@SHSMSX101.ccr.corp.intel.com> References: <7F1BAD85ADEA444D97065A60D2E97EE566E4F108@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: USB hub port reset X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 04:38:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I don't catch what you mean. We have had 10ms delay for port reset. Which l= ine of UsbHub.c do you think there is problem?=20 Quote from USB2.0 spec: "Hubs must be able to accept all hub requests and devices must be able to a= ccept a SetAddress() request (refer to Section 11.24.2 and Section 9.4 respectively) after the reset recovery time= 10 ms (TRSTRCY) after the reset is removed." Thanks Feng -----Original Message----- From: Anbazhagan, Baraneedharan [mailto:anbazhagan@hp.com]=20 Sent: Monday, November 14, 2016 11:33 AM To: Tian, Feng ; edk2-devel@lists.01.org Subject: RE: USB hub port reset I didn't mean to have extra delays. Am asking whether EDKII have to be upda= ted for 10ms reset recovery time regardless of port status to align with sp= ec? >From: Tian, Feng [mailto:feng.tian@intel.com]=20 >Sent: Sunday, November 13, 2016 7:46 PM >To: Anbazhagan, Baraneedharan ; edk2-devel@lists.01.org >Cc: Tian, Feng >Subject: RE: USB hub port reset > >Hi, Baranee > >Linux wait 10 + 40 ms (TRSTRCY =3D 10 ms, plus extra 40 ms). Do you mean E= DKII should be same with linux to wait more time? > >Thanks >Feng > >From: Anbazhagan, Baraneedharan [mailto:anbazhagan@hp.com]=20 >Sent: Sunday, November 13, 2016 11:53 AM >To: mailto:edk2-devel@lists.01.org; Tian, Feng >Subject: USB hub port reset > >EDK2 have reset recovery time of 10ms for hub port based on port status re= set bit but USB spec doesn't mention that port status can be used for t6/re= set recovery time. Could you please clarify? > >USB vendor mentions EDK2 doesn't have reset recovery time on hub port rese= t and also highlighting EDK2 hub port reset differs from https://github.com= /torvalds/linux/blob/master/drivers/usb/core/hub.c#L2789 > >-Baranee