Re: [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name.

["Tian, Feng" <feng.tian@intel.com>]

Reviewed-by: Feng Tian <feng.tian@intel.com>

Thanks
Feng

-----Original Message-----
From: Yao, Jiewen 
Sent: Thursday, December 1, 2016 4:51 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Fan, Jeff <jeff.fan@intel.com>
Subject: [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name.

To prevent potential build failure.

Cc: Feng Tian <feng.tian@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
 MdeModulePkg/Application/CapsuleApp/AppSupport.c | 8 ++++----  MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/MdeModulePkg/Application/CapsuleApp/AppSupport.c b/MdeModulePkg/Application/CapsuleApp/AppSupport.c
index 6aea76a..a5fd0ca 100644
--- a/MdeModulePkg/Application/CapsuleApp/AppSupport.c
+++ b/MdeModulePkg/Application/CapsuleApp/AppSupport.c
@@ -74,7 +74,7 @@ GetArg (
 
 **/
 EFI_STATUS
-StrToBuf (
+InternalStrToBuf (
   OUT UINT8    *Buf,
   IN  UINTN    BufferLength,
   IN  CHAR16   *Str
@@ -135,7 +135,7 @@ StrToBuf (
 
 **/
 EFI_STATUS
-StrToGuid (
+InternalStrToGuid (
   IN  CHAR16   *Str,
   OUT EFI_GUID *Guid
   )
@@ -185,7 +185,7 @@ StrToGuid (
   //
   // Get the following 8 bytes data
   //
-  StrToBuf (&Guid->Data4[0], 2, Str);
+  InternalStrToBuf (&Guid->Data4[0], 2, Str);
   //
   // Skip 2 byte hex chars
   //
@@ -196,7 +196,7 @@ StrToGuid (
   } else {
     return EFI_UNSUPPORTED;
   }
-  StrToBuf (&Guid->Data4[2], 6, Str);
+  InternalStrToBuf (&Guid->Data4[2], 6, Str);
 
   return EFI_SUCCESS;
 }
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
index 5137259..5b8c147 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
@@ -155,7 +155,7 @@ WriteFileFromBuffer (
 
 **/
 EFI_STATUS
-StrToGuid (
+InternalStrToGuid (
   IN  CHAR16   *Str,
   OUT EFI_GUID *Guid
   );
@@ -782,7 +782,7 @@ UefiMain (
         //
         // FMP->GetImage()
         //
-        Status = StrToGuid(Argv[3], &ImageTypeId);
+        Status = InternalStrToGuid(Argv[3], &ImageTypeId);
         if (EFI_ERROR(Status)) {
           Print (L"Invalid ImageTypeId - %s\n", Argv[3]);
           return Status;
--
2.7.4.windows.1