From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4645881EA4 for ; Thu, 1 Dec 2016 00:52:37 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 01 Dec 2016 00:52:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,723,1477983600"; d="scan'208";a="792960392" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 01 Dec 2016 00:52:36 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 1 Dec 2016 00:52:36 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 1 Dec 2016 00:52:36 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.239]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.142]) with mapi id 14.03.0248.002; Thu, 1 Dec 2016 16:52:34 +0800 From: "Tian, Feng" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Fan, Jeff" , "Tian, Feng" Thread-Topic: [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name. Thread-Index: AQHSS7Agy0w4nw328kae2KjyZCKFvaDyyP3A Date: Thu, 1 Dec 2016 08:52:33 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE566E56CA8@SHSMSX101.ccr.corp.intel.com> References: <1480582283-19488-1-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1480582283-19488-1-git-send-email-jiewen.yao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 08:52:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Feng Tian Thanks Feng -----Original Message----- From: Yao, Jiewen=20 Sent: Thursday, December 1, 2016 4:51 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Fan, Jeff Subject: [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name. To prevent potential build failure. Cc: Feng Tian Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Application/CapsuleApp/AppSupport.c | 8 ++++---- MdeModulePk= g/Application/CapsuleApp/CapsuleApp.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/AppSupport.c b/MdeModulePk= g/Application/CapsuleApp/AppSupport.c index 6aea76a..a5fd0ca 100644 --- a/MdeModulePkg/Application/CapsuleApp/AppSupport.c +++ b/MdeModulePkg/Application/CapsuleApp/AppSupport.c @@ -74,7 +74,7 @@ GetArg ( =20 **/ EFI_STATUS -StrToBuf ( +InternalStrToBuf ( OUT UINT8 *Buf, IN UINTN BufferLength, IN CHAR16 *Str @@ -135,7 +135,7 @@ StrToBuf ( =20 **/ EFI_STATUS -StrToGuid ( +InternalStrToGuid ( IN CHAR16 *Str, OUT EFI_GUID *Guid ) @@ -185,7 +185,7 @@ StrToGuid ( // // Get the following 8 bytes data // - StrToBuf (&Guid->Data4[0], 2, Str); + InternalStrToBuf (&Guid->Data4[0], 2, Str); // // Skip 2 byte hex chars // @@ -196,7 +196,7 @@ StrToGuid ( } else { return EFI_UNSUPPORTED; } - StrToBuf (&Guid->Data4[2], 6, Str); + InternalStrToBuf (&Guid->Data4[2], 6, Str); =20 return EFI_SUCCESS; } diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePk= g/Application/CapsuleApp/CapsuleApp.c index 5137259..5b8c147 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c @@ -155,7 +155,7 @@ WriteFileFromBuffer ( =20 **/ EFI_STATUS -StrToGuid ( +InternalStrToGuid ( IN CHAR16 *Str, OUT EFI_GUID *Guid ); @@ -782,7 +782,7 @@ UefiMain ( // // FMP->GetImage() // - Status =3D StrToGuid(Argv[3], &ImageTypeId); + Status =3D InternalStrToGuid(Argv[3], &ImageTypeId); if (EFI_ERROR(Status)) { Print (L"Invalid ImageTypeId - %s\n", Argv[3]); return Status; -- 2.7.4.windows.1