public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Tian, Feng" <feng.tian@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Tian, Feng" <feng.tian@intel.com>
Subject: Re: [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration
Date: Tue, 20 Dec 2016 01:14:22 +0000	[thread overview]
Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE5699900DF@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1482132023-10416-7-git-send-email-dandan.bi@intel.com>

Reviewed-by: Feng Tian <feng.tian@Intel.com>

Thanks
Feng

-----Original Message-----
From: Bi, Dandan 
Sent: Monday, December 19, 2016 3:20 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>
Subject: [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration

Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c
index 9625f4d..c9b4ffc 100644
--- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c
+++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c
@@ -186,10 +186,11 @@ TerminalConOutOutputString (
   UTF8_CHAR                   Utf8Char;
   CHAR8                       GraphicChar;
   CHAR8                       AsciiChar;
   EFI_STATUS                  Status;
   UINT8                       ValidBytes;
+  CHAR8                       CrLfStr[2];
   //
   //  flag used to indicate whether condition happens which will cause
   //  return EFI_WARN_UNKNOWN_GLYPH
   //
   BOOLEAN                     Warning;
@@ -324,11 +325,12 @@ TerminalConOutOutputString (
           // the next character, but the driver thinks it has wrapped
           // already.  Print CR LF to synchronize the terminal with
           // the driver, but only if we're not in the middle of
           // printing an escape sequence.
           //
-          CHAR8 CrLfStr[] = {'\r', '\n'};
+          CrLfStr[0] = '\r';
+          CrLfStr[1] = '\n';
 
           Length = sizeof(CrLfStr);
 
           Status = TerminalDevice->SerialIo->Write (
                                                 TerminalDevice->SerialIo,
-- 
1.9.5.msysgit.1



  reply	other threads:[~2016-12-20  1:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19  7:20 [patch 0/8] Fix coding style issues Dandan Bi
2016-12-19  7:20 ` [patch 1/8] SecurityPkg/FmpAuthenticationLib: Fix Guid format issues Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 2/8] IntelSiliconPkg: Fix " Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 3/8] MdeModulePkg/CapsuleApp: Fix Guid " Dandan Bi
2016-12-19  7:32   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules Dandan Bi
2016-12-19  7:33   ` Yao, Jiewen
2016-12-19  7:20 ` [patch 5/8] MdeModulePkg/EmmcDxe: Avoid Non-Boolean type used as Boolean Dandan Bi
2016-12-19  7:38   ` Tian, Feng
2016-12-19  7:20 ` [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration Dandan Bi
2016-12-20  1:14   ` Tian, Feng [this message]
2016-12-19  7:20 ` [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue Dandan Bi
2016-12-20  1:18   ` Tian, Feng
2016-12-19  7:20 ` [patch 8/8] MdeModulePkg/NonDiscoverableDeviceRegistrationLib: Fix coding style issues Dandan Bi
2016-12-19 13:44   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7F1BAD85ADEA444D97065A60D2E97EE5699900DF@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox