* [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.
@ 2016-12-22 15:45 Jiewen Yao
2016-12-23 1:13 ` Tian, Feng
2016-12-23 2:01 ` Zeng, Star
0 siblings, 2 replies; 3+ messages in thread
From: Jiewen Yao @ 2016-12-22 15:45 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Star Zeng
UEFI specification does not require ImageIndex check,
it only requires ImageTypeId check.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
index 3ba3b9c..af08886 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
@@ -1013,8 +1013,7 @@ ProcessFmpCapsuleImage (
continue;
}
- if (CompareGuid(&ImageHeader->UpdateImageTypeId, &TempFmpImageInfo->ImageTypeId) &&
- ImageHeader->UpdateImageIndex == TempFmpImageInfo->ImageIndex) {
+ if (CompareGuid(&ImageHeader->UpdateImageTypeId, &TempFmpImageInfo->ImageTypeId)) {
AbortReason = NULL;
if (ImageHeader->Version >= EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION) {
if(ImageHeader->UpdateHardwareInstance != 0){
--
2.7.4.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.
2016-12-22 15:45 [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check Jiewen Yao
@ 2016-12-23 1:13 ` Tian, Feng
2016-12-23 2:01 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Tian, Feng @ 2016-12-23 1:13 UTC (permalink / raw)
To: Yao, Jiewen, edk2-devel@lists.01.org; +Cc: Zeng, Star, Tian, Feng
Reviewed-by: Feng Tian <feng.tian@Intel.com>
Thanks
Feng
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiewen Yao
Sent: Thursday, December 22, 2016 11:45 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.
UEFI specification does not require ImageIndex check, it only requires ImageTypeId check.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
index 3ba3b9c..af08886 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
@@ -1013,8 +1013,7 @@ ProcessFmpCapsuleImage (
continue;
}
- if (CompareGuid(&ImageHeader->UpdateImageTypeId, &TempFmpImageInfo->ImageTypeId) &&
- ImageHeader->UpdateImageIndex == TempFmpImageInfo->ImageIndex) {
+ if (CompareGuid(&ImageHeader->UpdateImageTypeId,
+ &TempFmpImageInfo->ImageTypeId)) {
AbortReason = NULL;
if (ImageHeader->Version >= EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION) {
if(ImageHeader->UpdateHardwareInstance != 0){
--
2.7.4.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.
2016-12-22 15:45 [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check Jiewen Yao
2016-12-23 1:13 ` Tian, Feng
@ 2016-12-23 2:01 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Zeng, Star @ 2016-12-23 2:01 UTC (permalink / raw)
To: Yao, Jiewen, edk2-devel@lists.01.org; +Cc: Tian, Feng, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Yao, Jiewen
Sent: Thursday, December 22, 2016 11:45 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.
UEFI specification does not require ImageIndex check, it only requires ImageTypeId check.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
index 3ba3b9c..af08886 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
@@ -1013,8 +1013,7 @@ ProcessFmpCapsuleImage (
continue;
}
- if (CompareGuid(&ImageHeader->UpdateImageTypeId, &TempFmpImageInfo->ImageTypeId) &&
- ImageHeader->UpdateImageIndex == TempFmpImageInfo->ImageIndex) {
+ if (CompareGuid(&ImageHeader->UpdateImageTypeId,
+ &TempFmpImageInfo->ImageTypeId)) {
AbortReason = NULL;
if (ImageHeader->Version >= EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION) {
if(ImageHeader->UpdateHardwareInstance != 0){
--
2.7.4.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-23 2:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-22 15:45 [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check Jiewen Yao
2016-12-23 1:13 ` Tian, Feng
2016-12-23 2:01 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox