From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF80781E9C for ; Thu, 19 Jan 2017 16:42:08 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 19 Jan 2017 16:42:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,256,1477983600"; d="scan'208";a="1115250966" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 19 Jan 2017 16:42:08 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 16:42:08 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 16:42:07 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Fri, 20 Jan 2017 08:42:05 +0800 From: "Tian, Feng" To: Laszlo Ersek , "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Fan, Jeff" , "Ni, Ruiyu" , "Ma, Maurice" , "Agyeman, Prince" , "Steele, Kelly" , "Leif Lindholm" CC: "Gao, Liming" , Ard Biesheuvel , "Tian, Feng" Thread-Topic: [edk2] [PATCH 0/7] Make the event empty function in UefiLib public Thread-Index: AQHScJCUvrRPxHCpEEahv/JmmV2wJqE/FhOAgAAAvgCAAXP30A== Date: Fri, 20 Jan 2017 00:42:04 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE5699AADA6@SHSMSX101.ccr.corp.intel.com> References: <1484636920-180432-1-git-send-email-star.zeng@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B818420@shsmsx102.ccr.corp.intel.com> <03db0f4d-610f-7cbf-76d1-a85938833c3d@redhat.com> In-Reply-To: <03db0f4d-610f-7cbf-76d1-a85938833c3d@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/7] Make the event empty function in UefiLib public X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 00:42:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MdeModulePkg reviewed-by: Feng Tian =20 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Thursday, January 19, 2017 6:30 PM To: Zeng, Star ; edk2-devel@lists.01.org ; Kinney, Michael D ; Fan, Jeff ; Tian, Feng ; Ni, Ruiyu ; Ma, Maurice ; Agyeman, Prince ; Steele, Kelly ; Leif Lindholm Cc: Gao, Liming ; Ard Biesheuvel Subject: Re: [edk2] [PATCH 0/7] Make the event empty function in UefiLib pu= blic Hi Star, On 01/19/17 11:27, Zeng, Star wrote: > Hi, >=20 > Please kindly help take a review to the patches. :) >=20 > So far, I have got the RB from Liming and Ard to MdePkg and ArmPlatformPk= g. I didn't ignore the series, it's just that I don't co-maintain any of the p= ackages being modified. Thanks Laszlo > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, January 17, 2017 3:09 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming=20 > ; Kinney, Michael D=20 > ; Fan, Jeff ; Tian,=20 > Feng ; Ni, Ruiyu ; Ma,=20 > Maurice ; Agyeman, Prince=20 > ; Steele, Kelly ;=20 > Leif Lindholm ; Ard Biesheuvel=20 > ; Laszlo Ersek > Subject: [PATCH 0/7] Make the event empty function in UefiLib public >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D298 >=20 > We found there are many event empty functions in EDK2 code base, these pa= tches are to make the event empty function in UefiLib public, then this eve= nt empty function can be used to remove the duplication in drivers and othe= r libraries. >=20 > In CorebootPayloadPkg/QuarkPlatformPkg/ArmPlatformPkg, EfiEventGroupSigna= l from UefiLib can be used to remove the duplication of event empty functio= n. >=20 > Cc: Liming Gao > Cc: Michael Kinney > Cc: Jeff Fan > Cc: Feng Tian > Cc: Ruiyu Ni > Cc: Maurice Ma > Cc: Prince Agyeman > Cc: Kelly Steele > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Laszlo Ersek >=20 > Star Zeng (7): > MdePkg UefiLib: Make the event empty function public > IntelFrameworkPkg UefiLib: Make the event empty function public > MdeModulePkg: Use EfiEventEmptyFunction from UefiLib > IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib > CorebootPayloadPkg: Use EfiEventGroupSignal from UefiLib > QuarkPlatformPkg: Use EfiEventGroupSignal from UefiLib > ArmPlatformPkg: Use EfiEventGroupSignal from UefiLib >=20 > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 36 ++--------------= --- .../Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 3 +- > .../PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 3 +- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > .../Universal/BdsDxe/BdsEntry.c | 20 +---------- > .../Library/FrameworkUefiLib/UefiLib.c | 42 +++++++++++-----= ------ > .../Library/FrameworkUefiLib/UefiLibInternal.h | 20 +---------- > .../Library/FrameworkUefiLib/UefiNotTiano.c | 4 +-- > MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 23 ++---------- > MdeModulePkg/Core/Dxe/DxeMain.h | 18 +--------- > MdeModulePkg/Core/Dxe/Event/Event.c | 4 +-- > MdeModulePkg/Library/UefiBootManagerLib/BmHotkey.c | 19 ++-------- .../= Universal/Console/ConSplitterDxe/ConSplitter.c | 22 ++---------- .../Unive= rsal/Console/ConSplitterDxe/ConSplitter.h | 18 +--------- > .../Universal/DriverSampleDxe/DriverSample.c | 20 ++--------- > .../Universal/SetupBrowserDxe/Presentation.c | 20 ++--------- > MdePkg/Include/Library/UefiLib.h | 18 +++++++++- > MdePkg/Library/UefiLib/UefiLib.c | 42 +++++++++++-----= ------ > MdePkg/Library/UefiLib/UefiLibInternal.h | 20 +---------- > MdePkg/Library/UefiLib/UefiNotTiano.c | 10 +++--- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > 21 files changed, 91 insertions(+), 321 deletions(-) >=20 > -- > 2.7.0.windows.1 >=20 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel