From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A00E882009 for ; Sun, 5 Feb 2017 16:52:26 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 05 Feb 2017 16:52:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="40154356" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 05 Feb 2017 16:52:26 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 5 Feb 2017 16:52:26 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 5 Feb 2017 16:52:26 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Mon, 6 Feb 2017 08:52:22 +0800 From: "Tian, Feng" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Tian, Feng" Thread-Topic: [Patch] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic Thread-Index: AQHSfb20sqLEjWssrE+2O0RmoDbm2qFbKwRg Date: Mon, 6 Feb 2017 00:52:22 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE5699AEDC1@SHSMSX101.ccr.corp.intel.com> References: <1486085670-13760-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1486085670-13760-1-git-send-email-liming.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 00:52:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Feng Tian Thanks Feng -----Original Message----- From: Gao, Liming=20 Sent: Friday, February 3, 2017 9:35 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [Patch] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to= match code logic Cc: Star Zeng Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c b/MdeModulePkg/Core/PiS= mmCore/PiSmmIpl.c index d3a5cda..7a4f4df 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c @@ -1,7 +1,7 @@ /** @file SMM IPL that produces SMM related runtime protocols and load the SMM Cor= e into SMRAM =20 - Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availa= ble=20 under the terms and conditions of the BSD License which accompanies this= =20 distribution. The full text of the license may be found at =20 @@ -508,7 +508,7 @@ SmmCommunicationCommunicate ( } =20 // - // If we are not in SMM, don't allow call SmiManage() directly when SMRA= M is closed or locked. + // Before SetVirtualAddressMap(), we are in SMM or SMRAM is open and unl= ock, call SmiManage() directly. // if ((!gSmmCorePrivate->InSmm) && (!mSmmAccess->OpenState || mSmmAccess->= LockState)) { return EFI_INVALID_PARAMETER; --=20 2.8.0.windows.1