From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9380182009 for ; Sun, 5 Feb 2017 16:54:36 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 05 Feb 2017 16:54:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="62193548" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 05 Feb 2017 16:54:36 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 5 Feb 2017 16:54:36 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 5 Feb 2017 16:54:35 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Mon, 6 Feb 2017 08:54:32 +0800 From: "Tian, Feng" To: Laszlo Ersek , edk2-devel-01 CC: Al Stone , Ard Biesheuvel , Igor Mammedov , Leo Duran , "Michael Tsirkin" , Phil Dennis-Jordan , "Zeng, Star" , "Tian, Feng" Thread-Topic: [PATCH 1/2] MdeModulePkg/AcpiTableDxe: condense whitespace around FADT.{DSDT,X_DSDT} Thread-Index: AQHSfLSgTLf/GcoDy0yIGEUgb1HXRaFbLbqQ Date: Mon, 6 Feb 2017 00:54:31 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE5699AEDDA@SHSMSX101.ccr.corp.intel.com> References: <20170201175654.19425-1-lersek@redhat.com> <20170201175654.19425-2-lersek@redhat.com> In-Reply-To: <20170201175654.19425-2-lersek@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] MdeModulePkg/AcpiTableDxe: condense whitespace around FADT.{DSDT, X_DSDT} X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 00:54:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Feng Tian Thanks Feng -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Thursday, February 2, 2017 1:57 AM To: edk2-devel-01 Cc: Al Stone ; Ard Biesheuvel ;= Tian, Feng ; Igor Mammedov ; Leo= Duran ; Michael Tsirkin ; Phil Den= nis-Jordan ; Zeng, Star Subject: [PATCH 1/2] MdeModulePkg/AcpiTableDxe: condense whitespace around = FADT.{DSDT,X_DSDT} This patch incurs no functional changes, it just removes some whitespace, a= nd also makes sure we always assign AcpiTableInstance->Fadt3->Dsdt first, and AcpiTableInstance->Fadt3->XDsdt second. The goal is to separate the syntactic changes from the functional c= hanges implemented by the next patch. Cc: Al Stone Cc: Ard Biesheuvel Cc: Feng Tian Cc: Igor Mammedov Cc: Leo Duran Cc: Michael Tsirkin Cc: Phil Dennis-Jordan Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: NOTE for people on the CC list: =20 If you are not presently subscribed to edk2-devel and wish to comment o= n this patch publicly, you need to subscribe first, and wait for the subscription request to *complete* (see your inbox), *before* sending your followup. This is not ideal, but edk2-devel requires subscription before reflecting messages from someone. =20 Subscribe at . Thanks= . MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 20 ++++++--= ------------ 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c b= /MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c index 7f95b9dc709d..7795ff7269ca 100644 --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c @@ -646,16 +646,12 @@ AddTableToList ( AcpiTableInstance->Fadt3->FirmwareCtrl =3D 0; } if ((UINT64)(UINTN)AcpiTableInstance->Dsdt3 < BASE_4GB) { - AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN) AcpiTableInst= ance->Dsdt3; + AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN)=20 + AcpiTableInstance->Dsdt3; ZeroMem (&AcpiTableInstance->Fadt3->XDsdt, sizeof (UINT64)); } else { - Buffer64 =3D (UINT64) (UINTN) AcpiTableIn= stance->Dsdt3; - CopyMem ( - &AcpiTableInstance->Fadt3->XDsdt, - &Buffer64, - sizeof (UINT64) - ); AcpiTableInstance->Fadt3->Dsdt =3D 0; + Buffer64 =3D (UINT64) (UINTN) AcpiTableInstance->Dsdt3; + CopyMem (&AcpiTableInstance->Fadt3->XDsdt, &Buffer64, sizeof=20 + (UINT64)); } =20 // @@ -850,14 +846,10 @@ AddTableToList ( // if (AcpiTableInstance->Fadt3 !=3D NULL) { if ((UINT64)(UINTN)AcpiTableInstance->Dsdt3 < BASE_4GB) { - AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN) AcpiTableIn= stance->Dsdt3; + AcpiTableInstance->Fadt3->Dsdt =3D (UINT32) (UINTN)=20 + AcpiTableInstance->Dsdt3; } - Buffer64 =3D (UINT64) (UINTN) AcpiTableIn= stance->Dsdt3; - CopyMem ( - &AcpiTableInstance->Fadt3->XDsdt, - &Buffer64, - sizeof (UINT64) - ); + Buffer64 =3D (UINT64) (UINTN) AcpiTableInstance->Dsdt3; + CopyMem (&AcpiTableInstance->Fadt3->XDsdt, &Buffer64, sizeof=20 + (UINT64)); =20 // // Checksum FADT table -- 2.9.3