From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F1F10803D3 for ; Sun, 19 Mar 2017 19:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489976792; x=1521512792; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9uwG0aTnwsXaEgxopX+yaZx1pRHH7JuD4b6oAoSkvCo=; b=nA+9busHdfSngFWSLRcEj8+wrz7j4aVTHWmaF9F2lT8BZrVTC6+Vw5iS L8l2N4k7Rtiz69gdkIIgtmQQW8hVfQ==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2017 19:26:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,191,1486454400"; d="scan'208";a="946069119" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 19 Mar 2017 19:26:29 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Mar 2017 19:26:30 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Mar 2017 19:26:29 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Mon, 20 Mar 2017 10:26:27 +0800 From: "Tian, Feng" To: "Zeng, Star" , Laszlo Ersek , edk2-devel-01 CC: Ard Biesheuvel , "Wu, Hao A" , Leif Lindholm , "Tian, Feng" Thread-Topic: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages Thread-Index: AQHSn1+8G3s1g47rtkGTzzgitQbkfKGcexYAgACHjHA= Date: Mon, 20 Mar 2017 02:26:26 +0000 Message-ID: <7F1BAD85ADEA444D97065A60D2E97EE5699BBA08@SHSMSX101.ccr.corp.intel.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-4-lersek@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B835B1D@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B835B1D@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 02:26:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ok to me as well. Reviewed-by: Feng Tian Thanks Feng -----Original Message----- From: Zeng, Star=20 Sent: Monday, March 20, 2017 10:16 AM To: Laszlo Ersek ; edk2-devel-01 Cc: Ard Biesheuvel ; Tian, Feng ; Wu, Hao A ; Leif Lindholm ; Zeng, Star Subject: RE: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal= catenation in info messages I am ok with this patch. Feng and Hao, do you have any comments? Thanks, Star -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Saturday, March 18, 2017 4:47 AM To: edk2-devel-01 Cc: Ard Biesheuvel ; Tian, Feng ; Wu, Hao A ; Leif Lindholm ; Zeng, Star Subject: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal cat= enation in info messages RamDiskDxe installs the RamDiskAcpiCheck() Ready To Boot callback function.= If EFI_ACPI_TABLE_PROTOCOL and/or EFI_ACPI_SDT_PROTOCOL are not found, the= n informational messages are logged, and the RAM disks are not published to= the (nonexistent) NFIT table. The logic is fine, but the info messages are not concatenated correctly fro= m multiple string literals -- the second parts are passed as (unused) argum= ents to DEBUG(). Fix the typos. Cc: Ard Biesheuvel Cc: Feng Tian Cc: Hao Wu Cc: Leif Lindholm Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c b/MdeMo= dulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c index d1dd13a8197b..b2bafc58bb71 100644 --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c @@ -74,7 +74,7 @@ RamDiskAcpiCheck ( if (EFI_ERROR (Status)) { DEBUG (( EFI_D_INFO, - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol,", + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol, " "unable to publish RAM disks to NFIT.\n" )); return; @@ -91,7 +91,7 @@ RamDiskAcpiCheck ( if (EFI_ERROR (Status)) { DEBUG (( EFI_D_INFO, - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol,", + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol, " "unable to publish RAM disks to NFIT.\n" )); mAcpiTableProtocol =3D NULL; -- 2.9.3