From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 89AF7203BEA3A for ; Fri, 4 May 2018 15:42:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC71DA2C82; Fri, 4 May 2018 22:42:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-129.rdu2.redhat.com [10.10.120.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2DB49108487; Fri, 4 May 2018 22:42:34 +0000 (UTC) To: "Carsey, Jaben" , "edk2-devel@lists.01.org" Cc: "Gao, Liming" , "Zhu, Yonghong" References: <538a46f357b28e3b84e1f94c4519b47e502ec610.1525465447.git.jaben.carsey@intel.com> <4070bbbd-a29f-8ea0-34e3-e8b9a2748498@redhat.com> From: Laszlo Ersek Message-ID: <7a08638a-c924-9f70-9a41-03187cd84b3b@redhat.com> Date: Sat, 5 May 2018 00:42:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 04 May 2018 22:42:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 04 May 2018 22:42:35 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v3 1/1] BaseTools: Ecc - add dict for config file to internal translation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 22:42:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 05/04/18 23:47, Carsey, Jaben wrote: > Thanks. I don’t push BaseTools, but will await Liming or Yonghong to review and push. Ah, sure, I didn't mean that you should skip their review; I thought you'd push the patch after their review (you co-maintain several packages, so technically you can push). But, if they push the patch for you, that's fine as well. :) Thanks! Laszlo > > Yonghong/Liming, Can you strip the trailing space before you commit? > > -Jaben > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Friday, May 04, 2018 2:44 PM >> To: Carsey, Jaben ; edk2-devel@lists.01.org >> Cc: Gao, Liming ; Zhu, Yonghong >> >> Subject: Re: [PATCH v3 1/1] BaseTools: Ecc - add dict for config file to internal >> translation >> Importance: High >> >> Hi Jaben. >> >> On 05/04/18 22:25, Jaben Carsey wrote: >>> Commit eece4292acc80 changed a variable name, which was tied directly to >>> a config file entry. This seperates the internal variable names from >>> the config file entries by having the internal dict accessed through a >>> translation of key words. >>> >>> added a test when this is run straight from command line. >>> >>> Cc: Liming Gao >>> Cc: Yonghong Zhu >>> Cc: Laszlo Ersek >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Jaben Carsey >>> --- >>> BaseTools/Source/Python/Ecc/Configuration.py | 122 >> +++++++++++++++++++- >>> 1 file changed, 119 insertions(+), 3 deletions(-) >>> >>> diff --git a/BaseTools/Source/Python/Ecc/Configuration.py >> b/BaseTools/Source/Python/Ecc/Configuration.py >>> index b5b583be8c4a..d305182a2666 100644 >>> --- a/BaseTools/Source/Python/Ecc/Configuration.py >>> +++ b/BaseTools/Source/Python/Ecc/Configuration.py >>> @@ -1,7 +1,7 @@ >>> ## @file >>> # This file is used to define class Configuration >>> # >>> -# Copyright (c) 2008 - 2017, Intel Corporation. All rights reserved.
>>> +# Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.
>>> # This program and the accompanying materials >>> # are licensed and made available under the terms and conditions of the >> BSD License >>> # which accompanies this distribution. The full text of the license may be >> found at >>> @@ -20,6 +20,109 @@ from Common.DataType import * >>> from Common.String import * >>> from Common.LongFilePathSupport import OpenLongFilePath as open >>> >>> +_ConfigFileToInternalTranslation = { >>> + # not same >>> + "ModifierList":"ModifierSet", >>> + >> >> Git complains that the above line contains trailing whitespace. >> >> But, that can be removed when you push this patch. >> >> Reviewed-by: Laszlo Ersek >> >> I've also run the Ecc tool (I didn't try to execute the self-test), and >> now it seems to work fine. >> >> Tested-by: Laszlo Ersek >> >> Thanks! >> Laszlo