From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.72]) by mx.groups.io with SMTP id smtpd.web10.15380.1603730062440321591 for ; Mon, 26 Oct 2020 09:34:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=C2z+jITT; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.223.72, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgOblWJ6KV+gZGBaoMDwvsSIz1CrpXjHRVXTyCkSlRnWFIxF2qTXXakZbGDcA9H7WRHlACANcFpaFsQ0QFRIpihCXFmj9KImRfRHUWxhl4uw8sC9kZC1lwkTFpeeZ4C05PYdJ/vAkyaWSBPvCb0r0kiGgIFi2LLp+xoTbNbna8gUctdV3o21T0y5/le/tmPd9rvnNRhIJocHDlYZ+EDct7Qbh7YKUyp+QOuj/52j75OZhIvhOTc1/rAB5oo0exuLKSqNP8JWK29waCrRDDm5BTf2N1PQ+2srMTPhz4Tu/L4/pd4HysmCXGOTzz/ou/eYXhRnuX9o9ZFYgu3y8XfiiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VHA9LgtBY+zxG5HxdRse9uuawg1D5H/OMf67oPzan7M=; b=X7gM0+srrOWBOaqqhUXJghISk+RzUQLNVYPi5V+NuesspAss9ri0dx/s1LJ4KPeL2V0ja57yJ51mUAyCLK17vbwSMAzpUk8NkfGtGpD3oHNiwpYhAhBNdIhNPulGvArVk8mSNkLJliYOUcRRaadG6DsCFsQosliaJ0z0hlmThSTHTISifleOC72B+Wo10XEGLyNBH+JWX4ahd0v8+3MBWAElQ0sk84WDiLGR9x/gQe1/JiMa5J6SqVui38RbhdmE7ytz8FgILS6nBX0qrlCtRMnD7Sd7YJqu3zBb+f1AkTypM2riLY/AqEe3KRKP+K7tgHhVgJUMFlL9BrAY+bWa8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VHA9LgtBY+zxG5HxdRse9uuawg1D5H/OMf67oPzan7M=; b=C2z+jITTrIIterpTATM/zzzhm8uEyzJQYjmdn+qQMLXmcG2cHyZLTys1ySUDXQgxLrL4roY9nyYknP6dXG54Ks0VoCF9dCxXJmB99NnnRiEElr/Nd+4t77xco0MaV7DyZLaZCvTczuhDPaW+v/ZvotEbuJi5rZF4Q+b5ao7+Yqs= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB3867.namprd12.prod.outlook.com (2603:10b6:5:1cf::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.27; Mon, 26 Oct 2020 16:34:16 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba%6]) with mapi id 15.20.3499.018; Mon, 26 Oct 2020 16:34:16 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiDlm57lpI06IOWbnuWkjTogW1BBVENIIHYyIDAxLzExXSBNZGVQa2csIE92bWZQa2c6IENsZWFuIHVwIEdIQ0IgZmllbGQgb2Zmc2V0cyBhbmQgc2F2ZSBhcmVh?= To: gaoliming , devel@edk2.groups.io, lersek@redhat.com, 'Ray Ni' , "'Dong, Eric'" , 'Michael D Kinney' CC: 'Brijesh Singh' , 'Zhiguang Liu' , 'Jordan Justen' , 'Ard Biesheuvel' References: <523f270e4e6f7a62cdbebc541b442bd766e7ab3a.1602864557.git.thomas.lendacky@amd.com> <000d01d6a5b9$03d14ef0$0b73ecd0$@byosoft.com.cn> <93c3b271-ccdb-6242-ce23-957eb73a66c0@amd.com> <006f01d6a67d$80b77d80$82267880$@byosoft.com.cn> <8734b948-e36c-81f4-43ae-6c63fba1374b@amd.com> <004401d6a744$b6208e90$2261abb0$@byosoft.com.cn> <008b01d6a812$4a331df0$de9959d0$@byosoft.com.cn> <4f1962a2-f417-4c27-1ddb-957b3d3abeb0@redhat.com> <000401d6a8e8$4b15d790$e14186b0$@byosoft.com.cn> From: "Lendacky, Thomas" Message-ID: <7a298343-a73d-ac5a-af90-a58ad9e97937@amd.com> Date: Mon, 26 Oct 2020 11:34:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <000401d6a8e8$4b15d790$e14186b0$@byosoft.com.cn> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0601CA0018.namprd06.prod.outlook.com (2603:10b6:803:2f::28) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.30.118] (165.204.77.1) by SN4PR0601CA0018.namprd06.prod.outlook.com (2603:10b6:803:2f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24 via Frontend Transport; Mon, 26 Oct 2020 16:34:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 422edb17-1cbf-46cb-6b05-08d879ccfb02 X-MS-TrafficTypeDiagnostic: DM6PR12MB3867: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AZEQMfbDVPxHxRHzQ0SjamT7tQcDB+uACEShK7R7WVQMna4L5KEQb8IfL1owX2FtQFZ4azqG7/jrILoNnGHctzTIWem4zAKkGjs3eiDE6qu8Jx3+Bib1l8PAXq7bCxJvtpwOpB41Yd3pQBimxLuJHl3+3hZDLxBnDiljIirCJcVcKPuhURVeaj1pK9KQ7qdpFkpb3DlqqoGL4T2kce/kIpP0R6l64yA1bfg0sZRl0WeK/+szj4aH8Jaat8518qSHejqRahWdcreDglFB4f7ZPVXAg9BgUA+8g3XwMhH+Hadw0/qGMon8ZwHHudIuf2Rd0FpjitKjudzyPxUTTO97C0AcC9JAS7+nlncbZ/pxOZOWyHuew5bxLkk6FeYr//4Yhi/Ht7uv8FfqgNbprZqxFjjGTigUkIc4CAMvI8SfaaKh5aEWcb7KxpY97XVYBSCVNNpFHhCZtfKQkJojgbf8HQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(39860400002)(396003)(346002)(53546011)(110136005)(8936002)(54906003)(478600001)(45080400002)(224303003)(4326008)(966005)(5660300002)(66946007)(66476007)(31686004)(66556008)(2616005)(36756003)(186003)(52116002)(83380400001)(16526019)(316002)(2906002)(6486002)(16576012)(956004)(26005)(86362001)(31696002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: yfsXX7MMdCk//iDsmUrQqAZegeWZdNod1CyY7XH3iQU2yZfy/2cfo4rbbC94JVdAdTz7bgCG7nicUKiwFiPWsxswGKg1YC3nU9iOvCf9DhhDKI60yUXUStMlfZ2D7mfxHu/PUt95eLmlCMF4O9sVYukSgd3+VkR11IZjRVbQE57SILLI/0fp9n2lteQGQxX2RVun7kmHOMDwOGSVIM/8M98t3mY8hKQ6taVLOppj3a/PD0ZczOvkta695IMziQ8MyDhhO8DndK/MrGAh6B+M1FJZ4fC+ADWPxjhHTFvPsBWnOtChiB+sxnoSn3tEXrLX1g6Sk75QgKerD8WRnTaKGCvRnTtDI98ZPWjW2FyUAZCxl5jMaLmMrsDQ6+JbedHGeftANefrhGbGCmI7CvUZTZurKN7qlqfZmMpuzSr2sezkRGNYYiHKZH7QAl1svslqhmGJGguYqNSy6s61LXZMQ7GOZMbawv2UoX/wL4+hh7Ehnh8EC+DJgGmidYos3+OqDoWsyOjwtQDmyq9ast4mSHESrsLl4SfBeJq5UNBlew8D83TUXLdp8KbYjVUxKpNmpoXBf8eqCMSqnXVuHD5+o1ZIEghQN7v5qObm6teRsYugjidA5V8+tKhEOjMsQKEkBvyFnuk8iC9YaqPM/meRAg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 422edb17-1cbf-46cb-6b05-08d879ccfb02 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2020 16:34:16.7192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4ByWuVeQ46PNHbAOj8yu1dq77xKYSz75CxwARgF3BEnCb9y3LPAkje5rkGG20ewVJIIKIFtfDjYySIhhvPyBQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3867 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/22/20 9:57 PM, gaoliming wrote: > Laszlo: > I agree Bisectability is important. I want to consider the impact and b= alance the change. Now, this change will update UefiCpuPkg. I also want to = collect the feedback from UefiCpuPkg maintainer: Ray and Eric.=20 Ray/Eric, Any feedback on this question (specifically for patch #10 of this series, not this patch)? I'd also prefer to maintain bisectability and therefore submit the changes to the UefiCpuPkg and OvmfPkg in the same patch. Thanks, Tom >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66536+4905953+8761045@groups.= io >> =E4=BB=A3=E8=A1=A8 Laszl= o Ersek >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8822=E6=97= =A5 21:13 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; deve= l@edk2.groups.io; >> thomas.lendacky@amd.com >> =E6=8A=84=E9=80=81: 'Brijesh Singh' ; 'Michael D= Kinney' >> ; 'Zhiguang Liu' ; >> 'Jordan Justen' ; 'Ard Biesheuvel' >> >> =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5= =A4=8D: =E5=9B=9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: [PATCH v2 01/11] MdePkg, >> OvmfPkg: Clean up GHCB field offsets and save area >> >> On 10/22/20 03:25, gaoliming wrote: >>> Tom: >>> For the patch in UefiCpuPkg, this changes the library interface. So,= the >> consumer and producer code is required to be changed together. There is= no >> good compatible way to do it. I still prefer to separate them for the d= ifferent >> package. Although the first commit breaks the tree, your patch is the p= atch >> serial, they will be merged together. Its impact should be small. >> >> I really disagree here. Bisectability is way more important, in my >> opinion, than avoiding a multi-package patch. >> >> I agree we should avoid multi-package patches as much as we can -- but >> not more than we can. Bisectability (=3D keeping the tree buildable at >> every commit) is very important, in my opinion. >> >> Thanks, >> Laszlo >> >> >> >>=20 >> >=20 >=20 >=20