From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id BFA861A1E89
 for <edk2-devel@ml01.01.org>; Tue, 11 Oct 2016 05:45:02 -0700 (PDT)
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
 (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 4884C3F1F8;
 Tue, 11 Oct 2016 12:45:02 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-32.phx2.redhat.com
 [10.3.116.32])
 by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u9BCj0WS007613; Tue, 11 Oct 2016 08:45:01 -0400
To: Yonghong Zhu <yonghong.zhu@intel.com>, edk2-devel@ml01.01.org
References: <1476151236-43084-1-git-send-email-yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>, Bruce Cran <bruce@cran.org.uk>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <7a2c6de2-a856-d8e0-ffb4-38a9c863f199@redhat.com>
Date: Tue, 11 Oct 2016 14:45:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1476151236-43084-1-git-send-email-yonghong.zhu@intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Tue, 11 Oct 2016 12:45:02 +0000 (UTC)
Subject: Re: [Patch V4] BaseTools: support the NOOPT target with the GCC tool chains
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2016 12:45:02 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 10/11/16 04:00, Yonghong Zhu wrote:
> Update the tools_def.template to add NOOPT support with GCC tool chains.
> Also disable -flto and -Os in NOOPT target for GCC5.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Conf/tools_def.template | 98 +++++++++++++++++++++++++++++----------
>  1 file changed, 73 insertions(+), 25 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Bruce, can you please test this like before, with both GCC49 and GCC5?
None of them should jump around.

Thanks!
Laszlo