From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Fu Siyuan <siyuan.fu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Anthony Perard <anthony.perard@citrix.com>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v2 3/3] OvmfPkg: Replace obsoleted network drivers from platform DSC/FDF.
Date: Tue, 6 Nov 2018 15:58:48 +0100 [thread overview]
Message-ID: <7a2f90cd-7aae-dc45-2412-0b663249e5c9@redhat.com> (raw)
In-Reply-To: <CAKv+Gu-bQaLGun2iW_u58VUGQohXJLukZqd0FCAUNtLnFgycgg@mail.gmail.com>
On 11/06/18 12:26, Ard Biesheuvel wrote:
> On 5 November 2018 at 23:46, Laszlo Ersek <lersek@redhat.com> wrote:
>> Assuming we consider "NetworkPkg/IScsiDxe/IScsiDxe.inf" an integral part
>> of the edk2 networking stack, without which (and its OpenSSL dependency)
>> noone would ever want to build OVMF, this patch is OK.
>>
>> I don't know what other OVMF users think about this; personally I'm ok
>> with it.
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>
> I think that is fine.
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Since the delta between NETWORK_IP6_ENABLE on vs off is decreasing,
> any chance we could drop it altogether at some point?
I believe I'd prefer flipping the default value at the most. UEFI has
been gaining new features like there's no tomorrow, and I find the
parallel (?) growth of the OVMF binary (mainly DXEFV) uncomfortable.
I'd like to continue offering knobs to keep the included features under
control.
Thanks
Laszlo
next prev parent reply other threads:[~2018-11-06 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 10:49 [PATCH v2 0/3] Delete TCP, PXE, iSCSI driver in MdeModulePkg Fu Siyuan
2018-11-05 10:49 ` [PATCH v2 1/3] Vlv2TbltDevicePkg: Replace obsoleted drivers from platform DSC/FDF Fu Siyuan
2018-11-05 10:54 ` Wei, David
2018-11-05 10:49 ` [PATCH v2 2/3] ArmVirtPkg: Replace obsoleted network " Fu Siyuan
2018-11-05 22:36 ` Laszlo Ersek
2018-11-06 0:54 ` Fu, Siyuan
2018-11-06 14:58 ` Laszlo Ersek
2018-11-05 10:49 ` [PATCH v2 3/3] OvmfPkg: " Fu Siyuan
2018-11-05 22:46 ` Laszlo Ersek
2018-11-06 11:26 ` Ard Biesheuvel
2018-11-06 14:58 ` Laszlo Ersek [this message]
2018-11-06 15:00 ` Ard Biesheuvel
2018-11-05 16:47 ` [PATCH v2 0/3] Delete TCP, PXE, iSCSI driver in MdeModulePkg Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a2f90cd-7aae-dc45-2412-0b663249e5c9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox