From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA4012117CEBE for ; Tue, 6 Nov 2018 06:59:01 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 406158830E; Tue, 6 Nov 2018 14:59:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-95.rdu2.redhat.com [10.10.120.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2AB375D75E; Tue, 6 Nov 2018 14:58:52 +0000 (UTC) To: Ard Biesheuvel Cc: Fu Siyuan , "edk2-devel@lists.01.org" , Anthony Perard , Jordan Justen References: <20181105104918.82104-1-siyuan.fu@intel.com> <20181105104918.82104-4-siyuan.fu@intel.com> <90f82933-1468-c402-b71b-549d49cdb263@redhat.com> From: Laszlo Ersek Message-ID: <7a2f90cd-7aae-dc45-2412-0b663249e5c9@redhat.com> Date: Tue, 6 Nov 2018 15:58:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 06 Nov 2018 14:59:01 +0000 (UTC) Subject: Re: [PATCH v2 3/3] OvmfPkg: Replace obsoleted network drivers from platform DSC/FDF. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 14:59:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/06/18 12:26, Ard Biesheuvel wrote: > On 5 November 2018 at 23:46, Laszlo Ersek wrote: >> Assuming we consider "NetworkPkg/IScsiDxe/IScsiDxe.inf" an integral part >> of the edk2 networking stack, without which (and its OpenSSL dependency) >> noone would ever want to build OVMF, this patch is OK. >> >> I don't know what other OVMF users think about this; personally I'm ok >> with it. >> >> Reviewed-by: Laszlo Ersek >> > > I think that is fine. > > Reviewed-by: Ard Biesheuvel > > Since the delta between NETWORK_IP6_ENABLE on vs off is decreasing, > any chance we could drop it altogether at some point? I believe I'd prefer flipping the default value at the most. UEFI has been gaining new features like there's no tomorrow, and I find the parallel (?) growth of the OVMF binary (mainly DXEFV) uncomfortable. I'd like to continue offering knobs to keep the included features under control. Thanks Laszlo