From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.13020.1596297305272655209 for ; Sat, 01 Aug 2020 08:55:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TX9ibgyL; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596297304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E52NUJSPGdSlQ8bCfIcRlq2oTqB+x19PdFY8Laex2do=; b=TX9ibgyLPGmgvvs9a3I+lnX8wnqFp3zJe1HZyQuINMDDlD8T56HyBYucjVGNYEGDlSx3rJ FVQhrrUIx1Y7vTCH/dKzNhr65GN67laZ32raBt47N/0uF31+WG+eTN4DJQM//DzTxrN6YK dtjq3ryw8d/Yr6G81MVFM+1C8lvB0Gk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-245-HwgrlhlhNiCXRbL49NFK_w-1; Sat, 01 Aug 2020 11:54:55 -0400 X-MC-Unique: HwgrlhlhNiCXRbL49NFK_w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CB8C800685; Sat, 1 Aug 2020 15:54:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 885F978545; Sat, 1 Aug 2020 15:54:47 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor From: "Laszlo Ersek" To: Sean Brogan , rebecca@bsdio.com, Andrew Fish , Leif Lindholm , Michael D Kinney Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan L Justen , Liming Gao References: <20200713054131.479627-1-rebecca@bsdio.com> <20200713054131.479627-2-rebecca@bsdio.com> <88d22f36-c210-f626-fe70-b2eb3c5fcd3c@redhat.com> <162169B0F92549B8.20689@groups.io> <52be7a58-9e2b-92a0-5f15-22a9dd59b0e4@redhat.com> <48628363-3c1b-7d24-6dbc-95e739ac389d@redhat.com> <7d432e20-b410-5510-ac29-9396f7ebf982@redhat.com> Message-ID: <7a32227c-5889-a9f5-54e4-8f5bf1d772c0@redhat.com> Date: Sat, 1 Aug 2020 17:54:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <7d432e20-b410-5510-ac29-9396f7ebf982@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/31/20 23:14, Laszlo Ersek wrote: > Regarding actual actions: I'm going to be away for a short while now. > Plus, I'm not entirely sure what exactly is being prevented by the > current state of the tree (i.e., how grave the regression is). > > (1) If the current issue interferes with work on, and usability of, > other packages (that is, anything *not* OvmfPkg), then I would request > that one of the stewards please revert 656419f922c0 ("Add BhyvePkg, to > support the bhyve hypervisor", 2020-07-31). For such a revert, please > add at once: > > Acked-by: Laszlo Ersek > > This is because the IRL stuff I've got queued up does not allow me to > participate in the revert, urgently, either from the reviewer side, or > even from the submitter side. (I wouldn't like to simply push a revert > without formal review, and I don't have time to *post* the revert > urgently). I was about to disappear for a bit, and logged back in only > because I snuck a peek on the mailing list archive, and noticed the > problem report. > > After the revert, Rebecca and I can collaborate on the next version of > the patch (I can review that incrementally against the one being > reverted under this option). > > (2) If, on the other hand, the current issue is restricted to OvmfPkg > (and even OvmfPkg platforms other than bhyve can be built), then I'd > like to ask that we keep commit 656419f922c0, and that Rebecca please > submit an incremental fix (per the above suggestions, assuming they work). > > ... Upon re-reading your comment "causing the other packages to fail", I > think we have case (1); if that's right, then please proceed accordingly. I'm proposing a fix here, rather than a revert: [edk2-devel] [PATCH] OvmfPkg: fix DEC spec violation introduced by Bhyve addition https://edk2.groups.io/g/devel/message/63619 http://mid.mail-archive.com/20200801155024.16439-1-lersek@redhat.com The posting includes links to a fetchable topic branch and to a personal CI build. I'd really prefer merging this patch, instead of a "revert & redo". Thanks Laszlo