From: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
To: devel@edk2.groups.io
Cc: jiewen.yao@intel.com, jordan.l.justen@intel.com,
kraxel@redhat.com, sebastien.boeuf@intel.com
Subject: [PATCH v3 03/11] OvmfPkg/CloudHv: Connect serial console
Date: Tue, 11 Jan 2022 11:20:45 +0100 [thread overview]
Message-ID: <7a8084c2484596459c4b554aeef1fda3b013bc11.1641894685.git.sebastien.boeuf@intel.com> (raw)
In-Reply-To: <cover.1641894685.git.sebastien.boeuf@intel.com>
From: Sebastien Boeuf <sebastien.boeuf@intel.com>
Cloud Hypervisor doesn't emulate any LPC bridge, therefore we simply
need to rely on the serial I/O port to be connected as a console.
It reuses the code from Xen since it's very generic.
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 6 ++----
OvmfPkg/CloudHv/CloudHvX64.fdf | 6 +-----
OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 +++++++-
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc
index 5e11942d08..d6d34a4677 100644
--- a/OvmfPkg/CloudHv/CloudHvX64.dsc
+++ b/OvmfPkg/CloudHv/CloudHvX64.dsc
@@ -828,11 +828,9 @@
OvmfPkg/VirtioGpuDxe/VirtioGpu.inf
#
- # ISA Support
+ # Serial Support
#
- OvmfPkg/SioBusDxe/SioBusDxe.inf
- MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
- MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
+ MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
#
# SMBIOS Support
diff --git a/OvmfPkg/CloudHv/CloudHvX64.fdf b/OvmfPkg/CloudHv/CloudHvX64.fdf
index f35458551b..5ce3233bf7 100644
--- a/OvmfPkg/CloudHv/CloudHvX64.fdf
+++ b/OvmfPkg/CloudHv/CloudHvX64.fdf
@@ -290,11 +290,7 @@ INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
-INF OvmfPkg/SioBusDxe/SioBusDxe.inf
-!if $(SOURCE_DEBUG_ENABLE) == FALSE
-INF MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
-!endif
-INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
+INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
INF OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
index 0918c35f1f..51016a5548 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
@@ -418,10 +418,16 @@ PlatformBootManagerBeforeConsole (
SaveS3BootScript ();
}
+ //
// We need to connect all trusted consoles for TCG PP. Here we treat all
// consoles in OVMF to be trusted consoles.
+ //
+ // Cloud Hypervisor doesn't emulate any LPC bridge, which is why it must
+ // rely on the serial I/O port to be connected as a console. It reuses the
+ // definition from Xen as it is very generic.
+ //
PlatformInitializeConsole (
- XenDetected () ? gXenPlatformConsole : gPlatformConsole
+ (XenDetected () || PcdGet16 (PcdOvmfHostBridgePciDevId) == CLOUDHV_DEVICE_ID) ? gXenPlatformConsole : gPlatformConsole
);
//
--
2.30.2
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2022-01-11 10:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 10:20 [PATCH v3 00/11] Create new target for Cloud Hypervisor Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 01/11] OvmfPkg/CloudHv: Add " Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 02/11] OvmfPkg/CloudHv: Replace legacy 8254 PIT with local APIC timer Boeuf, Sebastien
2022-01-11 10:20 ` Boeuf, Sebastien [this message]
2022-01-11 10:35 ` [PATCH v3 03/11] OvmfPkg/CloudHv: Connect serial console Yao, Jiewen
2022-01-11 10:20 ` [PATCH v3 04/11] OvmfPkg/CloudHv: Remove legacy 8259 PIC support Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 05/11] OvmfPkg/CloudHv: Remove Q35 specifics Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 06/11] OvmfPkg/CloudHv: Reduce dependency on QemuFwCfg Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 07/11] OvmfPkg/CloudHv: Remove video support Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 08/11] OvmfPkg/CloudHv: Remove USB support Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 09/11] OvmfPkg/CloudHv: Remove CSM support Boeuf, Sebastien
2022-01-11 10:20 ` [PATCH v3 10/11] OvmfPkg/CloudHv: add Maintainers.txt entry Boeuf, Sebastien
2022-01-11 10:35 ` [edk2-devel] " Yao, Jiewen
2022-01-11 10:20 ` [PATCH v3 11/11] OvmfPkg: Add CloudHvX64 to the CI Boeuf, Sebastien
2022-01-11 10:36 ` Yao, Jiewen
2022-01-11 12:14 ` [PATCH v3 00/11] Create new target for Cloud Hypervisor Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a8084c2484596459c4b554aeef1fda3b013bc11.1641894685.git.sebastien.boeuf@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox