From: "Rebecca Cran via groups.io" <rebecca=os.amperecomputing.com@groups.io>
To: devel@edk2.groups.io, mikuback@linux.microsoft.com
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard
Date: Wed, 6 Sep 2023 13:46:58 -0600 [thread overview]
Message-ID: <7a883569-657c-477d-9478-baa07b8370fb@os.amperecomputing.com> (raw)
In-Reply-To: <20230906172931.1812-1-mikuback@linux.microsoft.com>
On 9/6/2023 11:29 AM, Michael Kubacki via groups.io wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> The include guard is incomplete and does not define the macro.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> MdePkg/Library/BaseRngLib/BaseRngLibInternals.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> index a9cbce15302f..d0abcc3452ee 100644
> --- a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> +++ b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> @@ -9,6 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> #ifndef BASE_RNGLIB_INTERNALS_H_
> +#define BASE_RNGLIB_INTERNALS_H_
>
> /**
> Generates a 16-bit random number.
Reviewed-by: Rebecca Cran <rebecca@os.amperecomputing.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108343): https://edk2.groups.io/g/devel/message/108343
Mute This Topic: https://groups.io/mt/101198135/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-06 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 17:29 [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard Michael Kubacki
2023-09-06 19:46 ` Rebecca Cran via groups.io [this message]
2023-09-07 22:00 ` Michael D Kinney
2023-09-08 0:39 ` 回复: " gaoliming via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a883569-657c-477d-9478-baa07b8370fb@os.amperecomputing.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox