From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6AFB8AC1A1B for ; Wed, 6 Sep 2023 22:17:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qmsHDX19TK5USx0G46qKeBmBDObPSaLsLJ3bi8aRfv4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694038646; v=1; b=aN8fGczuWwSNEdDZmqlJZTOuV0Wvh8ZgngUV1FilO0xPwZzVx4tQGErBKYXXtQsqdxP4kyAl RB+1QlLdCiA8DpzqBG57ocyquq3OOTzBP1123HWhExL/ioF5RSqTQYT4sanx8KN47aOd4OXKqnF 6k8JWFmxhG7Env7PHinKn93o= X-Received: by 127.0.0.2 with SMTP id q1UmYY7687511x2gpcQR4LFI; Wed, 06 Sep 2023 15:17:26 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.114]) by mx.groups.io with SMTP id smtpd.web11.106.1694029628014174782 for ; Wed, 06 Sep 2023 12:47:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cC2aX4nUSFN/vSBcpJOi33Hidvmzd6Gy1rSsTKCJosKySl4qYScwU1J43hLoJHC6WvHBpnohzV1jHxrzRSkxE97wsCGwC/utWRrlNGokJJZE8M8sUj69kfupBgsOkpiH+hqc+uMtEqrUAuk5PLuLP8+ycmim4wgJqsuzejnOXsh50kagzmYrwmC9W9yXFwjLyJEIdZxNFG2AWRt6RUz9sDl/py9D9SrmNfE/OMb8KshLJAiOqIZr1jqONVRB/4GzL4RVF3jSf5YkLZYu8zkQdTbo4EXAXh/AOKnx9YZyPeuxhgncWHa0lafSJtcW6FQMoW8LGiTDsbqF1w6v41SPXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9PlaJBqn0pvZM62FO5vie26N/pxvyyP+FOLa2oSG1I=; b=TmiIcqvIXK19aIywcg2rK5RX4/PkUcvNxGAK/kINikV/yletrpRqYNCukHVPqQJo9aMtoeL0pFF2qddrqf8QUFYxbJP3fk2OfuhZt1yf9tk/vse2sv86AUi5TORdfXfYtQErWz5GIaRTU54Jqa2ZhwjbqfT41qKVtCzeTcVWwvF05oFkoVttmVvVtzYfNU5CoQW4h04AU6AUeZh/KWdUIQJ2jt9ZwbhGIxRA7u7oJ6QuDzvfzjN0+M5ZrRrrrnckuyvAiZtgmD4hZ35i1NR8epW2byfoHXodXx4ZvlPIMtwIkIcoHkTjVAHZnMy4r9m+jNFaEKb0kkIEYWxUXiEgqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by MW4PR01MB6273.prod.exchangelabs.com (2603:10b6:303:65::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Wed, 6 Sep 2023 19:47:04 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::2f51:a94f:516e:2d89]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::2f51:a94f:516e:2d89%6]) with mapi id 15.20.6745.034; Wed, 6 Sep 2023 19:47:03 +0000 Message-ID: <7a883569-657c-477d-9478-baa07b8370fb@os.amperecomputing.com> Date: Wed, 6 Sep 2023 13:46:58 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Rebecca Cran References: <20230906172931.1812-1-mikuback@linux.microsoft.com> From: "Rebecca Cran via groups.io" In-Reply-To: <20230906172931.1812-1-mikuback@linux.microsoft.com> X-ClientProxiedBy: CH0PR03CA0002.namprd03.prod.outlook.com (2603:10b6:610:b0::7) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|MW4PR01MB6273:EE_ X-MS-Office365-Filtering-Correlation-Id: bbd51388-2f57-4911-e2b1-08dbaf120b51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 8f6bV5W/Clo6a7DfcZNds6OLurUaX3apbpbtHtCe9hMDiJVuwpcxTfeTpUEkOpDM0UBWEJH8qT80D/fReGO799tA2mmAX5KIVbK/iAMYVX6wAvopiw4SRSsHeYJvlOJlW7429gTfuJ2qsBKikGnSjFn2jm9iS7R3r0sH/i6A8VZU7fCYNF9Gp1VHPDPulQKa23OEBuu252nj7j/3aW021im0FlKjuLhK2B6sVffEsAdCTFR2x3voRKDL10uVJvFluTkV/ngGyyq+tEoft8ghc6HNbyY7pex8S4C00psvVnf5iQJJ2cJW4hcjB52MUqak9uZSAhMMGyBC79VEFXLOfANmcdh8QPNsUlnTuhboBWnLbvRJ617gODeUn7OSzid9pNIFDhugsA72MS0jntqEuyr4Crp0uHsJYXI0BNg7NjLQ9xTo2SCu2pEpBajcsq6FL4kY/2KXrErNNQo8Pq2QPQYKI+f/I8YpGUQJLOeu4UPJy9lKv2DMLMAon72I+sSidIklAWBWTkdXISh+XYXdm8FUvRF/ySRsRFyZesfCcu6OaibeXPriIjZ1jkFhkp6W3NoZGMerj4RsDMaRrKiNWsFo/zdP6woLyM9LD3pzB7TCLe7s4qcUQHNasXvNo92N X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW5Jb3JoNnhNU3pHNkUvamZyaUprWXpaSElFYVpSbzNJbG9LTmtQK21Cb24v?= =?utf-8?B?M3FkTjhPMjIwL0lDV20wOTZLWkxPT0RnMG5GTEVjQzU0TU44RG5jUkt3R1lu?= =?utf-8?B?aXBzVE1ncTZlaC9UMzA5WUcyNU5DZEM3RU1OTnVwZFhub3JVNUZwbzFGdjFl?= =?utf-8?B?RDVQSmhUNmdPN3V6cmVET2FyWE5kcEkxZXZvTUNWeUJ0Z0tBOXc2NzRZRmFh?= =?utf-8?B?Y2ZoTXFRbWN5TmwrczdEZnZFeWtqNlVYZlBhTTNDbWFGT1gwb2dmenh3REhw?= =?utf-8?B?MytOTlJmVnpic1R1L1FHaGRjdzBJdHlHTmtJeTBZSkxHK3dhSForLzdLQm9R?= =?utf-8?B?UytJZUtHeDRVakw2bTBONXlUYkhNMFNnbU5tNWhKRmVkK0pnZ2hEOWxpajk0?= =?utf-8?B?Ny9iQjV5bkdmVThpV0xQSnZLT3pHM0xIR1g1UFVFRUF5R0Vza2s3bTJnck5Z?= =?utf-8?B?eE1DUmk1T0h0SUlYamlNdGJ6NHQ4SnhkN0FiVHQrdnQwSGR0U0ZPM1hkSzU2?= =?utf-8?B?Q1VFemJhV0hTZERpSHIwN2Y2SjZST3llRzFCTndnTGxUQnpTS3ZMMWppVDVI?= =?utf-8?B?elBQZzBtOUlZVUJML1R6VSs1TDl6UWtnaHM1Z1B0Y29qZGZtK0xwRHJPZkFw?= =?utf-8?B?NWVDTFVQaVZWWCtsbFZ4dHdaOGtVL1ZBYm1MTVFrTWJmcnJSakp2TXpIaGJl?= =?utf-8?B?ckkvclkwRkh4QzFpdDRLdGc5SEVQeWtkcklwbWMzVkEwY0xjNFhpcVB6ckZD?= =?utf-8?B?cTA4ZUg2RnZzLzd6em5zdTd1MzF3Qkd3QXR5L1VIVHNXVzlrK3pJK3lIaGh6?= =?utf-8?B?Sk51WGFob1k3T3E3c1l1dWMxMXBXTnhlVHVIZHV5TE9uNXE2QnFHanUxU2g0?= =?utf-8?B?NFJTSVhDcUM1blVHQlZVR1NDbVREYWpnUjNuVHdWdTNYQXMwTWxUaXJ5SjVC?= =?utf-8?B?UlF2NStGa2hINWY2M1VCSkZRRjFZY3hhek9EOFJpWkpWRkVFUFZQSXFjblhC?= =?utf-8?B?MzdHUmtXZ3Rpamhjd0FyYlVDM25RT1VuNWwybW8zeDRKOG9Fa3FUMTVZTXR1?= =?utf-8?B?eS9HT09rNWZDMnRTdUJnaG8vczBsVzlBQXk4ejl3L09GNUprcjRUK2UzSzlj?= =?utf-8?B?NWFTTzh1blpCdURKc3BncWZjKzErTU1Ed3gwZStOZkg5Q2JYa0IrYklkbzNj?= =?utf-8?B?Q25FNlhHZmkvbnNZNTNXWmZOQXdBQUd2aXFxR2RNUjA2bm9CMFhHNGNDZUtM?= =?utf-8?B?NlpyZkxFd1NUdkphMkphSTFtOWEwdkJvQ1FXS0NKS3VqR0IwVGk2QWhFdmRn?= =?utf-8?B?NWZZT0hYNTJxVFE0aEdIdHc3RWRYS2QrMXNZeCtXeXdNR1hscDBsMDJLMytZ?= =?utf-8?B?NkxSb0ZoSDJqUG4xUWtZb1BpSU44L2UxSHkyWjNzS0UralBxWEtaTGd2dzJO?= =?utf-8?B?MDdFaXFSY0JxZjRMZUtLMk9CYnNjMVV5bjRjRWx3cTRySlZDSi91K2NTTjJP?= =?utf-8?B?cSszWTNHOXV3Z1h4L2ZPQTdRcDY4NDIxK3hGUm1lbzFjb2IvYmdFRCt5SGZp?= =?utf-8?B?dGNZMDVVMi9wTU1EM3Urb0QvMDduS0VZc3MydU9oWU5xVWhpcXE4dnV4VEtH?= =?utf-8?B?TzlZRTMzMmxKdGkxT1VLMTNwS0hjdnpwOGhmY1dtUHlDOEJFNWcrOWx3Mzlx?= =?utf-8?B?d3h5bVA2dHRqT1U4R3Y4Z3o4VHZLWUtkR3EzK01ZZDNOa0VWZFEreC9yNUp4?= =?utf-8?B?M1pnV3NGVFNCbVp3aHQvQkZkOC9MUDdBZkVTM1NycHJQdUdtdGVDQWZHWkEv?= =?utf-8?B?cmdDL3JrMGM1OW9jQ1A1SnQ1RGt3VlNLSXdrUEo2akpqQTFxY0d1RUN5SWhy?= =?utf-8?B?bWV1R0cyeXdvWVYwR2xYVjF6eEJ2YXBRZDBaYzJXZHQrSTJsMExteTdpMXBJ?= =?utf-8?B?dmQzRXJRRGFvc3VBU2o4K2VyL1dlM21LUTZyakNtZERNRTZ2STYzcmZaT3Rk?= =?utf-8?B?Y1hUeHhVVnJKVlROVGlrMUFzL01ZN2dIZ1pLM2gyWVM5VE1jekVFcGVaSERJ?= =?utf-8?B?RnAya0c3aDc1bSt0M3c3WURRTHJ2dVhFQVN5djAwc2M3T2x0ZmlTUCsvdmRi?= =?utf-8?B?LzE4UVhoaGlOTVdCTTNSUThXb29hTnhHbGJDbDNQZytGckgya2dydjVGV29J?= =?utf-8?Q?ayh+f6ml8qS621dolqJcRLg=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbd51388-2f57-4911-e2b1-08dbaf120b51 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2023 19:47:03.8426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tPtt5m4FXXpi3CymSLyg37vseGDlrEvBQAJGLaqj43zqgrpqKUPAeT8aU/YDUVEHj/cNmRZKchucA8mvFVOag+1/LtTvQv87LNEb/5tv79y0XuQC2NTXGboxjIqXVoge X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6273 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bOhMg22BE4tIFfC0MNCXWxXVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aN8fGczu; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 9/6/2023 11:29 AM, Michael Kubacki via groups.io wrote: > From: Michael Kubacki >=20 > The include guard is incomplete and does not define the macro. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Rebecca Cran > Signed-off-by: Michael Kubacki > --- > MdePkg/Library/BaseRngLib/BaseRngLibInternals.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h b/MdePkg/Lib= rary/BaseRngLib/BaseRngLibInternals.h > index a9cbce15302f..d0abcc3452ee 100644 > --- a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h > +++ b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h > @@ -9,6 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > =20 > #ifndef BASE_RNGLIB_INTERNALS_H_ > +#define BASE_RNGLIB_INTERNALS_H_ > =20 > /** > Generates a 16-bit random number. Reviewed-by: Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108343): https://edk2.groups.io/g/devel/message/108343 Mute This Topic: https://groups.io/mt/101198135/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-