From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.4186.1622104418403016079 for ; Thu, 27 May 2021 01:33:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fUUD1888; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nO7nCfJr0mm/+AOLTajywrXK6V0Ww+OxbRYnrdPLXoo=; b=fUUD18887yZ1+1Ovld9ghsQIdslef9yE6f8uCJyFgMiFlLYgYA/xm6BiQ6nw6dgRKK2vYI q0uwHdqY3mszNcxYpW94O0WapjbftLeO7eUubd6WV3b9KGHHdV97PNNNHk/gSIZ3XP7UHL 5I2/D2jjca9GYhRi6VKDBG84Dw+ZsXs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-Uxb56OhVPHW-PU8Rg3u1NQ-1; Thu, 27 May 2021 04:33:35 -0400 X-MC-Unique: Uxb56OhVPHW-PU8Rg3u1NQ-1 Received: by mail-wm1-f70.google.com with SMTP id z62-20020a1c65410000b0290179bd585ef9so1670462wmb.7 for ; Thu, 27 May 2021 01:33:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nO7nCfJr0mm/+AOLTajywrXK6V0Ww+OxbRYnrdPLXoo=; b=KcngzTJu07AFLQzGVaFCWk3XwsV4VNC/Gl3UsVE2miIlvjs7s8pjoI2dItBazpLG3v acipRyyw0mf1PDB97SKsPbt9MjduDjCpCrCrzSernQAyiLuXE9BBEosaQyOVYuBSr5/q +7Vn93Js9YS6vZTOQ6bSiaEzc9/K4rNbLFCCyZ8xYm3UqsqmDpX/iJIUwuxg9PE0aQGL YztuVdgATljyH2sfoyo52fcnItO0pQB/oIZdTYdGVL4XPPmA0DTO1if6zbvYfoRyjIHk +7Y5mzaVy0k2+8rKfWdqu2ElER884PFd7CHYvzzAup7KNxqCq+4j+iUkvc7kheHaQjFP 5Qjg== X-Gm-Message-State: AOAM532l2xMYNT1AGluNPhFB3EBjCMpoyUhw72SgfD4QD5kgD5EcrmO0 k/jBkSeGwUyXMia1s/V1grJ0Zzkq4Y7tRVcSr2CtnKVnLnPcRJUygCmF++DRVgM2lmY2eFAXNqB jJ/QQ9U/HF8+Mlg== X-Received: by 2002:adf:e110:: with SMTP id t16mr2052901wrz.359.1622104414594; Thu, 27 May 2021 01:33:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGuvQPoTA7PAJ/VSFZdQ//HZ8HahgUYaeo5p6yyogyXJgsA2B4708X5q7v2NOo7U16HvLxqg== X-Received: by 2002:adf:e110:: with SMTP id t16mr2052878wrz.359.1622104414434; Thu, 27 May 2021 01:33:34 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id b15sm2150522wru.64.2021.05.27.01.33.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:33:33 -0700 (PDT) Subject: Re: [PATCH 34/43] OvmfPkg/PciHostBridgeLibScan: remove PcdOvmfHostBridgePciDevId To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall , Peter Grehan , Rebecca Cran References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-35-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <7aa98683-5f03-4738-baa9-5575f5836868@redhat.com> Date: Thu, 27 May 2021 10:33:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-35-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The "OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf" > instance is used in the following platforms in edk2: > > OvmfPkg/Bhyve/BhyveX64.dsc > OvmfPkg/OvmfXen.dsc > > Neither Bhyve nor Xen provide a Q35 board, therefore the expression > > PcdGet16 (PcdOvmfHostBridgePciDevId) != INTEL_Q35_MCH_DEVICE_ID > > always evaluates to TRUE, in the PciHostBridgeLibScan instance. > > Replace the expression with constant TRUE, eliminating the PCD dependency. > > (In effect, this reports that the root bridge being registered does not > support extended PCI config space.) > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf | 4 ---- > OvmfPkg/Library/PciHostBridgeLibScan/XenSupport.c | 4 +--- > 2 files changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daude