From: rebecca@bsdio.com
To: Laszlo Ersek <lersek@redhat.com>,
devel@edk2.groups.io, bob.c.feng@intel.com, liming.gao@intel.com,
leif.lindholm@linaro.org, michael.d.kinney@intel.com,
afish@apple.com
Subject: Re: [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Date: Mon, 15 Jul 2019 20:13:44 -0600 [thread overview]
Message-ID: <7ab50474-dcc4-d252-1764-d56027bc60e8@bsdio.com> (raw)
In-Reply-To: <c6863835-6e8d-b688-4855-a01494bfa75e@redhat.com>
On 2019-07-15 19:37, Laszlo Ersek wrote:
>
> (Sorry if the reason was already given and I missed it:)
>
> Why is this an improvement?
>
> The docs at <https://man.openbsd.org/pwd.1> say:
>
> "pwd also exists as a built-in to ksh(1), which may have a different
> default behavior". Is that the reason?
No, it's mainly as a (very minor) optimization: `pwd` runs the command
(even as a built-in), whereas $PWD simply evaluates the value of the
variable.
Also, modern scripts as I understand it should generally use $(...) to
run commands, instead of `...`.
--
Rebecca Cran
next prev parent reply other threads:[~2019-07-16 2:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 22:25 [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command rebecca
2019-07-15 22:25 ` [PATCH 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh' rebecca
2019-07-16 1:39 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed rebecca
2019-07-16 1:40 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing rebecca
2019-07-16 1:40 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions rebecca
2019-07-16 2:16 ` Laszlo Ersek
2019-07-16 2:27 ` rebecca
2019-07-16 10:38 ` Laszlo Ersek
2019-07-15 22:25 ` [PATCH 6/6] edksetup.sh: Add quotes and explicit checks in test statements rebecca
2019-07-16 1:47 ` Laszlo Ersek
2019-07-16 1:53 ` Laszlo Ersek
2019-07-16 2:20 ` [edk2-devel] " rebecca
2019-07-16 10:34 ` Laszlo Ersek
2019-07-16 1:37 ` [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command Laszlo Ersek
2019-07-16 2:13 ` rebecca [this message]
2019-07-16 10:32 ` Laszlo Ersek
2019-07-16 10:36 ` Laszlo Ersek
2019-07-16 9:16 ` Leif Lindholm
2019-07-16 11:40 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ab50474-dcc4-d252-1764-d56027bc60e8@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox