From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mx.groups.io with SMTP id smtpd.web10.7112.1618364663076922241 for ; Tue, 13 Apr 2021 18:44:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=uUJSnsbC; spf=pass (domain: nuviainc.com, ip: 209.85.215.174, mailfrom: rebecca@nuviainc.com) Received: by mail-pg1-f174.google.com with SMTP id g35so13236013pgg.9 for ; Tue, 13 Apr 2021 18:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gLRQUz53UtFPzkMi3xNuKDFwKFclxMoOqRTyQygR7xU=; b=uUJSnsbCBX706MK29Rl7hjJj8FOEi4Zb/SYVgTUXqf9Bwulgxqcyq/0xOh8civ2Trt 0NSwobiznB0hnEfOXOK6BXCtbyouDMi06zrOcJXTtyVz9ECYlqOTzbLA0b1j+Sz5v0R6 tuSyqQNGlQ3wWyBznbod0VJHipTgHTMj5XBxPdayKi20IMaAPYehesib/quVNVuJB9a9 Y2D365ZbtYjeyzvFCU0Fxq6o6H790FrTrlNcF+55Cp6fmQOTvxomSkq06dE4yu+OD6jq f0iwi/C2Oj5G90NK3Um14cUdoGZoj7D+AoBEANSRqPd0Vbt1rIw77aoPDeUPLwSr/gWk 97nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gLRQUz53UtFPzkMi3xNuKDFwKFclxMoOqRTyQygR7xU=; b=GvqncgcVcMZnmhgWu1Mnt+PzpnCaxMgxLN1u+0eO07TXLVpRMZUwAheDDDGYHMMeEq cBaVoINabFvc7LS7A2hMF4oXBSRGfjWcm3E6NG7VuszNo8atibcyZlb3GVxbFpdO7CV6 inomv73k4JyQ6m5qJgo9KeJy59Kt5fWZ56tzkNVT6VwBkcfw4Ho8if54R3SywkmSWaZm j2Z7yOgQ9MjQLpatq4WatJtrD8EwWMfyqj7nrKa7Q9Kz9FnK5L6oinzRJ1RLLmRLCAAB /nWYFUyGiyD8NhM5EqxajJKH52DlAmf6HJ255Zye3t63izo3q5GZpS71/7NRHdplSmiA nk4Q== X-Gm-Message-State: AOAM533+rksrWUcrvQ/ZdIS/l+rrf4YbBm+vrJUC1AeyJQeOp1n8jHb7 kMJqOc9/qNQW37/Tskq2tBRRhWTosGoQqRTK X-Google-Smtp-Source: ABdhPJweshl7IIkMYMcXQjcrN+8alYvQO8aDJtlalMOxMlxZH21Yq6BkfBCv0b5ZgtkOp9LWPjlJvA== X-Received: by 2002:a62:170e:0:b029:1fa:7161:fd71 with SMTP id 14-20020a62170e0000b02901fa7161fd71mr31506050pfx.35.1618364662677; Tue, 13 Apr 2021 18:44:22 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id b126sm15361887pga.91.2021.04.13.18.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 18:44:22 -0700 (PDT) Subject: Re: [PATCH 1/5] ArmPkg: Allow platforms to override PCI supported state in SmbiosMiscDxe To: Ard Biesheuvel , Leif Lindholm Cc: edk2-devel-groups-io , Ard Biesheuvel References: <20210331021619.19761-1-rebecca@nuviainc.com> <20210331021619.19761-2-rebecca@nuviainc.com> <20210413165117.GC1664@vanye> From: "Rebecca Cran" Message-ID: <7ab5723d-fe80-e828-3491-4294c4eb316d@nuviainc.com> Date: Tue, 13 Apr 2021 19:44:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/13/21 10:53 AM, Ard Biesheuvel wrote: > On Tue, 13 Apr 2021 at 18:51, Leif Lindholm wrote: >> >> On Tue, Mar 30, 2021 at 20:16:15 -0600, Rebecca Cran wrote: >>> Not all platforms support PCI, so introduce a PCD to allow platforms to >>> specify whether they support it. >> >> Are we planning to add one? >> If not, I'd rather skip this until we do. >> These days, I would expect any platform providing SMBIOS tables to >> have PCI. >> > > Also, does it matter? SMBIOS is mostly informational, and whether a > platform 'supports' PCI does not imply that it 'implements' it. And > even if it implements PCI, it may not have any slots. > > IOW, this is PC legacy that we care little about one way or the other, I think.. Yeah, I think there was a comment on the original review that lots of platforms get these values wrong, and nothing depends on them. -- Rebecca Cran > > >> No further comments on this set. >> >> / >> Leif >> >>> Signed-off-by: Rebecca Cran >>> --- >>> ArmPkg/ArmPkg.dec | 1 + >>> ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 + >>> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 4 ++++ >>> 3 files changed, 6 insertions(+) >>> >>> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec >>> index a8a22c649ff8..51ac2191c85a 100644 >>> --- a/ArmPkg/ArmPkg.dec >>> +++ b/ArmPkg/ArmPkg.dec >>> @@ -125,6 +125,7 @@ [PcdsFixedAtBuild.common] >>> # >>> # SMBIOS PCDs >>> # >>> + gArmTokenSpaceGuid.PcdPlatformSupportsPCI|TRUE|BOOLEAN|0x30000052 >>> gArmTokenSpaceGuid.PcdSystemProductName|L""|VOID*|0x30000053 >>> gArmTokenSpaceGuid.PcdSystemVersion|L""|VOID*|0x30000054 >>> gArmTokenSpaceGuid.PcdBaseBoardManufacturer|L""|VOID*|0x30000055 >>> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >>> index 60d8fe31c219..ebc4c99ac436 100644 >>> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >>> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >>> @@ -71,6 +71,7 @@ [Pcd] >>> gArmTokenSpaceGuid.PcdFdSize >>> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor >>> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString >>> + gArmTokenSpaceGuid.PcdPlatformSupportsPCI >>> gArmTokenSpaceGuid.PcdSystemBiosRelease >>> gArmTokenSpaceGuid.PcdEmbeddedControllerFirmwareRelease >>> gArmTokenSpaceGuid.PcdSystemProductName >>> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c >>> index 5aea32521bd3..a06f814aeb7c 100644 >>> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c >>> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c >>> @@ -13,6 +13,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> >>> @@ -264,6 +265,9 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) >>> UnicodeStrToAsciiStrS (Version, StrStart, VerStrLen + 1); >>> StrStart += VerStrLen + 1; >>> UnicodeStrToAsciiStrS (ReleaseDate, StrStart, DateStrLen + 1); >>> + >>> + SmbiosRecord->BiosCharacteristics.PciIsSupported = FixedPcdGetBool (PcdPlatformSupportsPCI); >>> + >>> // >>> // Now we have got the full smbios record, call smbios protocol to add this record. >>> // >>> -- >>> 2.26.2 >>>