public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	edk2-devel@ml01.01.org, leif.lindholm@linaro.org
Subject: Re: [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library
Date: Wed, 3 Aug 2016 11:56:48 +0200	[thread overview]
Message-ID: <7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com> (raw)
In-Reply-To: <1470212464-28071-2-git-send-email-ard.biesheuvel@linaro.org>

On 08/03/16 10:21, Ard Biesheuvel wrote:
> This library is only used by the various PrePi implementations, all of
> which are of type SEC.

You can actually enforce that client module type restriction, by setting

    LIBRARY_CLASS                  = MemoryAllocationLib|SEC

Can you try that, in addition to the MODULE_TYPE change?

Just an idea, of course.

Thanks,
Laszlo

> So make this library SEC as well. This may affect
> the build options used by the platform.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
> index 21f6eb1e14bc..ea3d0f5da9c2 100644
> --- a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
> +++ b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
> @@ -15,7 +15,7 @@ [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = PrePiMemoryAllocationLib
>    FILE_GUID                      = 4f14c900-51a9-11e0-afbf-0002a5d5c51b
> -  MODULE_TYPE                    = PEIM
> +  MODULE_TYPE                    = SEC
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = MemoryAllocationLib
>  
> 




  reply	other threads:[~2016-08-03  9:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  8:21 [PATCH 0/2] ArmVirtPkg EmbeddedPkg: fix build for CLANG35/ARM Ard Biesheuvel
2016-08-03  8:21 ` [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library Ard Biesheuvel
2016-08-03  9:56   ` Laszlo Ersek [this message]
2016-08-03 10:00     ` Ard Biesheuvel
2016-08-03 11:21       ` Laszlo Ersek
2016-08-03 12:50         ` Ard Biesheuvel
2016-08-03 13:07           ` Leif Lindholm
2016-08-03  8:21 ` [PATCH 2/2] ArmVirtPkg ARM: make relocatable PrePi users build with CLANG35 Ard Biesheuvel
2016-08-03 10:00   ` Laszlo Ersek
2016-08-03 10:02     ` Ard Biesheuvel
2016-08-03 11:19       ` Laszlo Ersek
2016-08-03 12:51         ` Ard Biesheuvel
2016-08-03 13:46 ` [PATCH 0/2] ArmVirtPkg EmbeddedPkg: fix build for CLANG35/ARM Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox