From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 597C61A1E21 for ; Wed, 3 Aug 2016 02:56:51 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB7C1C057EC6; Wed, 3 Aug 2016 09:56:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u739un2N011566; Wed, 3 Aug 2016 05:56:49 -0400 To: Ard Biesheuvel , edk2-devel@ml01.01.org, leif.lindholm@linaro.org References: <1470212464-28071-1-git-send-email-ard.biesheuvel@linaro.org> <1470212464-28071-2-git-send-email-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com> Date: Wed, 3 Aug 2016 11:56:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1470212464-28071-2-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 03 Aug 2016 09:56:50 +0000 (UTC) Subject: Re: [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2016 09:56:51 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/03/16 10:21, Ard Biesheuvel wrote: > This library is only used by the various PrePi implementations, all of > which are of type SEC. You can actually enforce that client module type restriction, by setting LIBRARY_CLASS = MemoryAllocationLib|SEC Can you try that, in addition to the MODULE_TYPE change? Just an idea, of course. Thanks, Laszlo > So make this library SEC as well. This may affect > the build options used by the platform. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf > index 21f6eb1e14bc..ea3d0f5da9c2 100644 > --- a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf > +++ b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf > @@ -15,7 +15,7 @@ [Defines] > INF_VERSION = 0x00010005 > BASE_NAME = PrePiMemoryAllocationLib > FILE_GUID = 4f14c900-51a9-11e0-afbf-0002a5d5c51b > - MODULE_TYPE = PEIM > + MODULE_TYPE = SEC > VERSION_STRING = 1.0 > LIBRARY_CLASS = MemoryAllocationLib > >