From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA132211B5A34 for ; Tue, 29 Jan 2019 06:21:58 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 06:21:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,537,1539673200"; d="scan'208";a="314522560" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 29 Jan 2019 06:21:58 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 49FE6580550; Tue, 29 Jan 2019 06:21:56 -0800 (PST) Message-ID: <7abad46eb05e9ce750636b24c4caea71a9d4e8b4.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Tue, 29 Jan 2019 15:21:54 +0100 In-Reply-To: <20181106175833.26964-4-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-4-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 14:22:00 -0000 X-List-Received-Date: Tue, 29 Jan 2019 14:22:00 -0000 X-List-Received-Date: Tue, 29 Jan 2019 14:22:00 -0000 X-List-Received-Date: Tue, 29 Jan 2019 14:22:00 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace > all #include references with lowercase ones as well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +- > IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 +- > IntelUndiPkg/GigUndiDxe/Decode.c | 2 +- > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 2 +- > IntelUndiPkg/GigUndiDxe/Dma.c | 2 +- > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 2 +- > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 +- > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 +- > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 2 +- > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 8 ++++--- > - > IntelUndiPkg/GigUndiDxe/Init.c | 2 +- > IntelUndiPkg/GigUndiDxe/StartStop.c | 2 +- > IntelUndiPkg/GigUndiDxe/StartStop.h | 2 +- > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 2 +- > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 0 > IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c} | 2 +- > IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h} | 0 > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 2 +- > 18 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c > b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c > index b0320b11839b..8918c538e447 100644 > --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c > +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c > @@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > ******************************************************************** > *******/ > #include "Uefi.h" > > -#include "E1000.h" > +#include "e1000.h" > > > #include "AdapterInformation.h" > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c > b/IntelUndiPkg/GigUndiDxe/ComponentName.c > index 1473bfbed0af..70baf00f4a5d 100644 > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > > #include "ComponentName.h" > #include "DeviceSupport.h" > diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c > b/IntelUndiPkg/GigUndiDxe/Decode.c > index 88e8be315bd1..14060db0d050 100644 > --- a/IntelUndiPkg/GigUndiDxe/Decode.c > +++ b/IntelUndiPkg/GigUndiDxe/Decode.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > #include > > /** This routine determines the operational state of the UNDI. It > updates the state flags in the > diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h > b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h > index f309044d9b9d..e156b587f6a7 100644 > --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h > +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #ifndef DEVICE_SUPPORT_H_ > #define DEVICE_SUPPORT_H_ > > -#include "E1000.h" > +#include "e1000.h" > > typedef struct BRAND_STRUCT_S BRAND_STRUCT; > > diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c > b/IntelUndiPkg/GigUndiDxe/Dma.c > index 76a3fcf69601..bf94c1e2fd54 100644 > --- a/IntelUndiPkg/GigUndiDxe/Dma.c > +++ b/IntelUndiPkg/GigUndiDxe/Dma.c > @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > > -#include "E1000.h" > +#include "e1000.h" > > #include "Dma.h" > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c > b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c > index 118c1b2b9b04..20d40ab672ef 100644 > --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c > +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > #include "DriverConfiguration.h" > > /* Protocol structure tentative definition */ > diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c > b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c > index a9f176ce5324..559f2133281e 100644 > --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c > +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > #include "DriverDiagnostics.h" > > /* Protocol structures tentative definitions */ > diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c > b/IntelUndiPkg/GigUndiDxe/DriverHealth.c > index b1af371e06db..b5b7db5fd814 100644 > --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c > +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > > > /** Retrieves the health status of a controller in the platform. > diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h > b/IntelUndiPkg/GigUndiDxe/EepromConfig.h > index e0d31f6a151d..272292d107e1 100644 > --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h > +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #ifndef EEPROM_CONFIG_H_ > #define EEPROM_CONFIG_H_ > > -#include "E1000.h" > +#include "e1000.h" > > // EEPROM power management bit definitions > #define E1000_INIT_CONTROL_WORD1 0x0A > diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > index 2d2d0707a686..0e4462733df6 100644 > --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > @@ -72,8 +72,8 @@ DriverConfiguration.c > DriverConfiguration.h > DriverDiagnostics.c > DriverDiagnostics.h > -E1000.h > -E1000.c > +e1000.h > +e1000.c > e1000_80003es2lan.h > e1000_80003es2lan.c > e1000_82571.h > @@ -92,8 +92,8 @@ e1000_manage.h > e1000_manage.c > e1000_nvm.h > e1000_nvm.c > -E1000_osdep.h > -E1000_osdep.c > +e1000_osdep.h > +e1000_osdep.c > e1000_phy.h > e1000_phy.c > e1000_regs.h > diff --git a/IntelUndiPkg/GigUndiDxe/Init.c > b/IntelUndiPkg/GigUndiDxe/Init.c > index 47ed03eb0849..74b933674589 100644 > --- a/IntelUndiPkg/GigUndiDxe/Init.c > +++ b/IntelUndiPkg/GigUndiDxe/Init.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > #include "Init.h" > #include "DeviceSupport.h" > #include "Decode.h" > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c > b/IntelUndiPkg/GigUndiDxe/StartStop.c > index 10ab4e51bf44..32bed7ce288d 100644 > --- a/IntelUndiPkg/GigUndiDxe/StartStop.c > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > #include "StartStop.h" > > EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID; > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h > b/IntelUndiPkg/GigUndiDxe/StartStop.h > index 24304d6cc3a7..255f17aabaa4 100644 > --- a/IntelUndiPkg/GigUndiDxe/StartStop.h > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #ifndef START_STOP_H_ > #define START_STOP_H_ > > -#include "E1000.h" > +#include "e1000.h" > > #define EFI_DRIVER_STOP_PROTOCOL_GUID \ > { 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \ > diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c > b/IntelUndiPkg/GigUndiDxe/e1000.c > similarity index 99% > rename from IntelUndiPkg/GigUndiDxe/E1000.c > rename to IntelUndiPkg/GigUndiDxe/e1000.c > index fad20d988441..6f8529abf046 100644 > --- a/IntelUndiPkg/GigUndiDxe/E1000.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > #include "DeviceSupport.h" > > > diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h > b/IntelUndiPkg/GigUndiDxe/e1000.h > similarity index 100% > rename from IntelUndiPkg/GigUndiDxe/E1000.h > rename to IntelUndiPkg/GigUndiDxe/e1000.h > diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c > b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c > similarity index 99% > rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.c > rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.c > index 0d0047a93048..3aa18e735dee 100644 > --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING > IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ******************************************************************** > *******/ > -#include "E1000.h" > +#include "e1000.h" > > /** Reads from the PCI capabality region. > > diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h > b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > similarity index 100% > rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.h > rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.h > diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h > b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h > index ed2ffc427093..ec67d000e9ae 100644 > --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h > +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #ifndef __WOLIMPL_H > #define __WOLIMPL_H > > -#include > +#include > #define WOL_1G 2 > > typedef UNDI_PRIVATE_DATA *WOL_ADAPTER_HANDLE_TYPE;