Re: [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 2/28/19 2:29 PM, Feng, Bob C wrote:
> Hi Phil,
> 
> Your suggested code is good but it still print the call stack. I changed it a little, it only print the error message now.
> 
> Thanks,
> Bob 
> 
> -----Original Message-----
> From: Feng, Bob C 
> Sent: Thursday, February 28, 2019 9:19 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1509
> 
> Add python3-distutils Ubuntu package checking.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Tests/RunTests.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/BaseTools/Tests/RunTests.py b/BaseTools/Tests/RunTests.py index 0dd65632d0..356c1d600c 100644
> --- a/BaseTools/Tests/RunTests.py
> +++ b/BaseTools/Tests/RunTests.py
> @@ -17,10 +17,17 @@
>  #
>  import os
>  import sys
>  import unittest
>  
> +try:
> +    import distutils.util
> +except ModuleNotFoundError:
> +    sys.exit('''
> +Python reported: "No module named 'distutils.uitl'"

Again: 'uitl' -> 'util'
Can the maintainer fix that typo before applying?

Although I find the current error message a bit opaque for the user.
To be clearer and tell the user this is not a problem within EDK2 but in
his setup, I suggest a more explicit "Required module 'distutils.util'
not found".

Regardless, with the 'uitl' typo fixed:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Thanks,

Phil.

> +''')
> +
>  import TestTools
>  
>  def GetCTestSuite():
>      import CToolsTests
>      return CToolsTests.TheTestSuite()
> --
> 2.20.1.windows.1
>