public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Oram, Isaac W" <isaac.w.oram@intel.com>
To: devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.oram@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/5] IpmiFeaturePkg/GenericIpmi: Fix GCC compilation warnings
Date: Thu, 30 Jun 2022 17:14:06 -0700	[thread overview]
Message-ID: <7af494accd8dea409ebbc05f7a5fa6f1e88f506a.1656634277.git.isaac.w.oram@intel.com> (raw)
In-Reply-To: <cover.1656634277.git.isaac.w.oram@intel.com>

Fix compiler warnings for unused variables.
Fix PeimIpmiInterfaceInit to return initialization status instead of
EFI_SUCCESS.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 .../IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c            | 8 +++-----
 .../IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c       | 3 +--
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c
index 7243d37cc5..cf1929f399 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c
@@ -36,7 +36,6 @@ Returns:
   EFI_STATUS      Status;
   UINT8           KcsData;
   KCS_STATUS      KcsStatus;
-  UINT8           BmcStatus;
   UINT8           RetryCount;
   UINT64          TimeOut;
 
@@ -101,7 +100,7 @@ Returns:
         TimeOut++;
       } while (!KcsStatus.Status.Obf);
 
-      BmcStatus = IoRead8 (KcsPort);
+      IoRead8 (KcsPort);
 
       KcsData = KCS_READ;
       IoWrite8 (KcsPort, KcsData);
@@ -184,7 +183,6 @@ Returns:
 {
   EFI_STATUS      Status;
   KCS_STATUS      KcsStatus;
-  UINT8           KcsData;
   UINT64          TimeOut;
 
   if (Idle == NULL) {
@@ -205,7 +203,7 @@ Returns:
   } while (KcsStatus.Status.Ibf);
 
   if (KcsState == KcsWriteState) {
-    KcsData = IoRead8 (KcsPort);
+    IoRead8 (KcsPort);
   }
 
   if (KcsStatus.Status.State != KcsState) {
@@ -231,7 +229,7 @@ Returns:
   }
 
   if (KcsState == KcsWriteState || (*Idle == TRUE)) {
-    KcsData = IoRead8 (KcsPort);
+    IoRead8 (KcsPort);
   }
 
   return EFI_SUCCESS;
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c
index 14040c089c..3efb772b68 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c
@@ -167,13 +167,12 @@ PeimIpmiInterfaceInit (
 {
   EFI_STATUS  Status;
 
-
   //
   // Performing Ipmi KCS physical layer initialization
   //
   Status = PeiInitializeIpmiKcsPhysicalLayer (PeiServices);
 
-  return EFI_SUCCESS;
+  return Status;
 } // PeimIpmiInterfaceInit()
 
 
-- 
2.36.1.windows.1


  reply	other threads:[~2022-07-01  0:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01  0:14 [edk2-devel][edk2-platforms][PATCH V1 0/5] Resolve GCC compilation warnings Oram, Isaac W
2022-07-01  0:14 ` Oram, Isaac W [this message]
2022-07-01  0:14 ` [edk2-devel][edk2-platforms][PATCH V1 2/5] WhitleyOpenBoardPkg: Fix GCC warnings Oram, Isaac W
2022-07-01  0:14 ` [edk2-devel][edk2-platforms][PATCH V1 3/5] WhitleyOpenBoardPkg: Fix GCC unused variables warnings Oram, Isaac W
2022-07-01  0:14 ` [edk2-devel][edk2-platforms][PATCH V1 4/5] WhitleyOpenBoardPkg: Fix GCC unused variables that are set warnings Oram, Isaac W
2022-07-01  0:14 ` [edk2-devel][edk2-platforms][PATCH V1 5/5] WhitleyOpenBoardPkg: Remove unnecessary code Oram, Isaac W
2022-07-20 22:16 ` [edk2-devel][edk2-platforms][PATCH V1 0/5] Resolve GCC compilation warnings Nate DeSimone
2022-07-20 22:28   ` Oram, Isaac W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7af494accd8dea409ebbc05f7a5fa6f1e88f506a.1656634277.git.isaac.w.oram@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox