From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.32762.1656634461043942097 for ; Thu, 30 Jun 2022 17:14:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ExKbCCJP; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656634461; x=1688170461; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HY4vqt6d6I9O2ZlxtNSLf2ddpvoYoEHUMlG6gGM4CI8=; b=ExKbCCJPCVUG6nx88M2rcWPSUIblhKP1uZiu3GgZwl0/WIMUy2FqxK+e KGHrk4HZk/4axiPTkUwR2H2j8m0wrhoGpQ7qX/+2m3zjNUPsMqmotoShC dEFAOZOM7id2CqvZVAfphYuqzwXhHwBZ/Zzqjj9OxsEP1hEq7aaxfnZSa rjitxclYzBSLZSJUMcjWfUp4RCS6Mor92HvgSHBz3eiLJFb0HlzErO7HD qEFE3G7k4xA5eaV1mCiRNI5QzjlRPc5CcY/vmkbp0pORZfuEnzsm9IrJG Zy1s2jf0cszSyMuY8Tt3NOd0QoxiZHodDUFD92wDMHW0snLv36FVXdjZY g==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="281268317" X-IronPort-AV: E=Sophos;i="5.92,235,1650956400"; d="scan'208";a="281268317" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 17:14:20 -0700 X-IronPort-AV: E=Sophos;i="5.92,235,1650956400"; d="scan'208";a="768313217" Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 17:14:20 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Liming Gao Subject: [edk2-devel][edk2-platforms][PATCH V1 1/5] IpmiFeaturePkg/GenericIpmi: Fix GCC compilation warnings Date: Thu, 30 Jun 2022 17:14:06 -0700 Message-Id: <7af494accd8dea409ebbc05f7a5fa6f1e88f506a.1656634277.git.isaac.w.oram@intel.com> X-Mailer: git-send-email 2.36.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix compiler warnings for unused variables. Fix PeimIpmiInterfaceInit to return initialization status instead of EFI_SUCCESS. Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Isaac Oram --- .../IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c | 8 +++----- .../IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c | 3 +-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c index 7243d37cc5..cf1929f399 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c @@ -36,7 +36,6 @@ Returns: EFI_STATUS Status; UINT8 KcsData; KCS_STATUS KcsStatus; - UINT8 BmcStatus; UINT8 RetryCount; UINT64 TimeOut; @@ -101,7 +100,7 @@ Returns: TimeOut++; } while (!KcsStatus.Status.Obf); - BmcStatus = IoRead8 (KcsPort); + IoRead8 (KcsPort); KcsData = KCS_READ; IoWrite8 (KcsPort, KcsData); @@ -184,7 +183,6 @@ Returns: { EFI_STATUS Status; KCS_STATUS KcsStatus; - UINT8 KcsData; UINT64 TimeOut; if (Idle == NULL) { @@ -205,7 +203,7 @@ Returns: } while (KcsStatus.Status.Ibf); if (KcsState == KcsWriteState) { - KcsData = IoRead8 (KcsPort); + IoRead8 (KcsPort); } if (KcsStatus.Status.State != KcsState) { @@ -231,7 +229,7 @@ Returns: } if (KcsState == KcsWriteState || (*Idle == TRUE)) { - KcsData = IoRead8 (KcsPort); + IoRead8 (KcsPort); } return EFI_SUCCESS; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c index 14040c089c..3efb772b68 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c @@ -167,13 +167,12 @@ PeimIpmiInterfaceInit ( { EFI_STATUS Status; - // // Performing Ipmi KCS physical layer initialization // Status = PeiInitializeIpmiKcsPhysicalLayer (PeiServices); - return EFI_SUCCESS; + return Status; } // PeimIpmiInterfaceInit() -- 2.36.1.windows.1