From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 1F56521B02822 for ; Wed, 28 Nov 2018 14:30:30 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F19B980D; Wed, 28 Nov 2018 14:30:29 -0800 (PST) Received: from supven01-VirtualBox (u203142.arm.com [10.118.30.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C0A653F575; Wed, 28 Nov 2018 14:30:29 -0800 (PST) Message-ID: <7b02763cfd49dc1306058ac48664098db536d539.camel@arm.com> From: Supreeth Venkatesh To: Lokesh B V , edk2-devel@lists.01.org Date: Wed, 28 Nov 2018 16:30:27 -0600 In-Reply-To: <1543397402-19411-3-git-send-email-lokesh.bv@arm.com> References: <1543397402-19411-1-git-send-email-lokesh.bv@arm.com> <1543397402-19411-3-git-send-email-lokesh.bv@arm.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Subject: Re: [edk2-test][PATCH v2] SctPkg/build: Add support for GenBin tool build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 X-List-Received-Date: Wed, 28 Nov 2018 22:30:30 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2018-11-28 at 15:00 +0530, Lokesh B V wrote: > As the GenBin tool is necessary for SCT build, it is appropriate to > support it's build in the SCT build procedure. > > Cc: Supreeth Venkatesh > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Lokesh B V Reviewed-by: Supreeth Venkatesh Pushed with additional changes specified below (inline). > --- > Changes since v1: > * Addressed review comments from the mailing list > * modified Copyright content > > uefi-sct/SctPkg/build.sh | 28 +++++++++++++++------------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh > index 73581c9..a469362 100755 > --- a/uefi-sct/SctPkg/build.sh > +++ b/uefi-sct/SctPkg/build.sh > @@ -1,7 +1,7 @@ > #!/bin/bash > # > # Copyright 2006 - 2015 Unified EFI, Inc.
> -# Copyright (c) 2011 - 2015, ARM Ltd. All rights reserved.
> +# Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of > the BSD License > @@ -228,21 +228,23 @@ else > echo using prebuilt tools > fi > > -# Copy GenBin file to Base tools directory > +rm -f $EDK_TOOLS_PATH/Source/C/bin/GenBin > + > +# build the GenBin if it doesn't yet exist > +echo Building GenBin > +make -C $EDK_TOOLS_PATH/../SctPkg/Tools/Source/GenBin make -C SctPkg/Tools/Source/GenBin is enough here. > +status=$? > +if test $status -ne 0 > +then > +echo Error while building GenBin > + exit -1 > +fi > + > +# Copy GenBin file to Base tools bin directory > DEST_DIR=`GetEdkToolsPathBinDirectory` > # Ensure the directory exist > mkdir -p $DEST_DIR > -case `uname -m` in > - x86_64) > - cp SctPkg/Tools/Bin/GenBin_lin_64 $DEST_DIR/GenBin > - ;; > - x86_32) > - cp SctPkg/Tools/Bin/GenBin_lin_32 $DEST_DIR/GenBin > - ;; > - *) > - cp SctPkg/Tools/Bin/GenBin_lin_32 $DEST_DIR/GenBin > - ;; > -esac > +cp $EDK_TOOLS_PATH/Source/C/bin/GenBin $DEST_DIR/GenBin > > # > # Build the SCT package