From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B7EED2095606A for ; Wed, 14 Mar 2018 22:21:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 22:28:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,308,1517904000"; d="scan'208";a="24671931" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by fmsmga008.fm.intel.com with ESMTP; 14 Mar 2018 22:27:59 -0700 To: Heyi Guo , edk2-devel@lists.01.org Cc: Eric Dong , Ard Biesheuvel , Jordan Justen , Anthony Perard , Prince Agyeman , Michael D Kinney , Laszlo Ersek , Star Zeng References: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org> From: "Ni, Ruiyu" Message-ID: <7b0d2465-1dab-7162-aee6-2703b5f38b07@Intel.com> Date: Thu, 15 Mar 2018 13:27:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org> Subject: Re: [PATCH v6 0/6] Add translation support to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 05:21:38 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/15/2018 12:00 PM, Heyi Guo wrote: > v6: > - Patch 1, 2: implement 3 comments from Laszlo. > - Patch 4: implement 3 comments from Ray. > > Patch v5 inherits the code from RFC v4; we don't restart the version number for > RFC to PATCH change. > > v5: > - Patch 4/6: Modify the code according to the comments from Ray. > - Patch 1/6 and 2/6 are totally new. They add initialization for all fields of > PCI_ROOT_BRIDGE_APERTURE temporary variables in PciHostBridgeLib instances, so > that they will not suffer from extension of PCI_ROOT_BRIDGE_APERTURE > structure. > - Generate a separate patch (3/6) for PciHostBridgeLib.h change. Though it is a > prerequisite for patch 4/6, it does not change the code in PciHostBridge > driver and won't cause any build failure or functional issue. > > > v4: > - Modify the code according to the comments from Ray, Laszlo and Ard (Please see > the notes of Patch 1/3) > - Ignore translation of bus in CreateRootBridge. > > > v3: > - Keep definition of Translation consistent in EDKII code: Translation = device > address - host address. > - Patch 2/2 is split into 2 patches (2/3 and 3/3). > - Refine comments and commit messages to make the code easier to understand. > > > v2: > Changs are made according to the discussion on the mailing list, including: > > - PciRootBridgeIo->Configuration should return CPU view address, as well as > PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view > address - CPU view address. > - Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition. > - PciHostBridge driver internally used Base Address is still based on PCI view > address, and translation offset = CPU view - PCI view, which follows the > definition in ACPI, and not the same as that in UEFI spec. > > Cc: Ruiyu Ni > Cc: Ard Biesheuvel > Cc: Star Zeng > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Michael D Kinney > Cc: Maurice Ma > Cc: Prince Agyeman > Cc: Benjamin You > Cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > > > Heyi Guo (6): > CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init > OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init > MdeModulePkg/PciHostBridgeLib.h: add address Translation > MdeModulePkg/PciHostBridgeDxe: Add support for address translation > MdeModulePkg/PciBus: convert host address to device address > MdeModulePkg/PciBus: return CPU address for GetBarAttributes > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 21 +++ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 3 + > MdeModulePkg/Include/Library/PciHostBridgeLib.h | 19 +++ > CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7 +- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 +- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 129 ++++++++++++++++--- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 135 ++++++++++++++++++-- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 + > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 7 +- > 9 files changed, 306 insertions(+), 31 deletions(-) > Heyi, I have given the Reviewed-by for the whole patch series. So please just add my R-b if you want to send further version of patches. I only have a minor comment for #4 patch. I don't think you need to send another version of #4 patch. You can just change the code when committing. Thanks, Ray -- Thanks, Ray