From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tpilar@solarflare.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=148.163.129.52; helo=dispatch1-us1.ppe-hosted.com;
 envelope-from=tpilar@solarflare.com; receiver=edk2-devel@lists.01.org 
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 30A63211575D7
 for <edk2-devel@lists.01.org>; Mon,  1 Oct 2018 02:23:36 -0700 (PDT)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 A69B0B40062
 for <edk2-devel@lists.01.org>; Mon,  1 Oct 2018 09:23:35 +0000 (UTC)
Received: from tp-desktop.uk.solarflarecom.com (10.17.20.51) by
 ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
 15.0.1395.4; Mon, 1 Oct 2018 02:23:32 -0700
To: <edk2-devel@lists.01.org>
References: <1538186116-3792-1-git-send-email-dongao.guo@intel.com>
From: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>
Message-ID: <7b490137-3c8a-b5e3-9b48-c4ba1a3d588b@solarflare.com>
Date: Mon, 1 Oct 2018 10:23:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1538186116-3792-1-git-send-email-dongao.guo@intel.com>
X-Originating-IP: [10.17.20.51]
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24128.005
X-TM-AS-Result: No-3.210800-4.000000-10
X-TMASE-MatchedRID: e/tT8EyIjJRhgXuWXN7Tdl8trZCvrWkkc3ewuwbSaG4NcckEPxfz2Iu3
 renu5Y0wNoRRbW4nkEZ1VEmx7sTk/6+/EguYor8cOX/V8P8ail1yZ8zcONpAsdmzcdRxL+xwKra
 uXd3MZDWvVLf7RaMfzMLFljlCYi0tuNC9y31FNxEtfrsQdxRC2SVDG+7KfiXD0eU/yc77IF7qcw
 JHRoQQ5b8MFLfHNH3hLanJN+oEoLyttokxeSpL8imrallLEixoqiftjGsrnVLHLBltO4st2n5Cg
 YvfL1UC
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--3.210800-4.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24128.005
X-MDID: 1538385816-1E6Sp5-6iYqX
Subject: Re: [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2018 09:23:37 -0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Wouldn't it be better to fix the warnings in code rather than silencing them?

Tom

On 29/09/18 02:55, Dongao Guo wrote:
> Change-Id: I782962e4994a8edf14beb7ede8b1aabe233dc3a8
> Contributed-under: TianoCore Contribution Agreement 1.1
> ---
>  MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> index 16e91bd..07bc02e 100644
> --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> @@ -109,3 +109,6 @@
>  
>    # Oniguruma: error: variable 'fp' set but not used
>    GCC:*_*_*_CC_FLAGS = -Wno-error=unused-but-set-variable
> +
> +  # Oniguruma: tag_end in parse_callout_of_name
> +  GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized